From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104070 invoked by alias); 27 Mar 2017 19:00:25 -0000 Mailing-List: contact jit-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: Sender: jit-owner@gcc.gnu.org Received: (qmail 103871 invoked by uid 89); 27 Mar 2017 19:00:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: mx1.redhat.com DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 004A94E048 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dmalcolm@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 004A94E048 Message-ID: <1490641205.11099.67.camel@redhat.com> Subject: Re: Alignment not supported? From: David Malcolm To: Florian Weimer Cc: =?UTF-8?Q?=EC=A0=95=EC=9D=B8=EB=B0=B0=28Inbae?= "Jeong)" , jit@gcc.gnu.org Date: Sun, 01 Jan 2017 00:00:00 -0000 In-Reply-To: <87vaqumy7f.fsf@mid.deneb.enyo.de> References: <87fui1pj74.fsf@mid.deneb.enyo.de> <1490622483.11099.31.camel@redhat.com> <87wpbaojxb.fsf@mid.deneb.enyo.de> <1490630429.11099.60.camel@redhat.com> <1490632719.11099.66.camel@redhat.com> <87vaqumy7f.fsf@mid.deneb.enyo.de> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 27 Mar 2017 19:00:07 +0000 (UTC) X-SW-Source: 2017-q1/txt/msg00018.txt.bz2 On Mon, 2017-03-27 at 19:22 +0200, Florian Weimer wrote: > * David Malcolm: > > > Hence all of this pre-existing logic for setting the alignment of a > > type is implemented with the c-family front-end code, which isn't > > available from libgccjit. > > Ah, I assumed it was a c-family target. > > > Alternatively, it might make more sense to go with this earlier API > > idea: > > > > extern gcc_jit_type * > > gcc_jit_type_set_alignment (gcc_jit_type *type, > > int alignment); > > > > or similar ("make_aligned" ? "add_alignment" ?) > > > > I think I prefer the latter approach, as it makes it explicit in > > client > > code linkage metadata what functionality it's using, > > It's also more type-safe and self-documenting. Although “int” > probably isn't exactly the right type here. "unsigned int" ?