From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52516 invoked by alias); 24 Apr 2017 20:34:20 -0000 Mailing-List: contact jit-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: Sender: jit-owner@gcc.gnu.org Received: (qmail 52470 invoked by uid 89); 24 Apr 2017 20:34:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*Ad:U*jit, completed, late X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 45F8F8046A Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dmalcolm@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 45F8F8046A Message-ID: <1493066056.9106.91.camel@redhat.com> Subject: Re: [PATCH] Add gcc_jit_type_get_aligned From: David Malcolm To: Florian Weimer Cc: =?UTF-8?Q?=EC=A0=95=EC=9D=B8=EB=B0=B0=28Inbae?= "Jeong)" , jit@gcc.gnu.org, gcc-patches@gcc.gnu.org Date: Sun, 01 Jan 2017 00:00:00 -0000 In-Reply-To: <1490994792-6645-1-git-send-email-dmalcolm@redhat.com> References: <87y3vmse4n.fsf@mid.deneb.enyo.de> <1490994792-6645-1-git-send-email-dmalcolm@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Mon, 24 Apr 2017 20:34:18 +0000 (UTC) X-SW-Source: 2017-q2/txt/msg00000.txt.bz2 On Fri, 2017-03-31 at 17:13 -0400, David Malcolm wrote: > On Thu, 2017-03-30 at 22:28 +0200, Florian Weimer wrote: > > * David Malcolm: > > > > > Here's a work-in-progress implementation of the idea, adding this > > > entrypoint to the API: > > > > > > extern gcc_jit_type * > > > gcc_jit_type_get_aligned (gcc_jit_type *type, > > > unsigned int alignment_in_bytes); > > > > Should be size_t, not unsigned int. A 2**31 alignment isn't as > > ridiculous as it might seem. x86-64 already has a 2**30 alignment > > requirement in some contexts. > > Thanks; fixed in this version. > > Here's a completed version of the patch. > > It also implements the missing C++ binding > gccjit::type::get_const, needed by a test case. > > Successfully bootstrapped®rtested on x86_64-pc-linux-gnu. > Takes jit.sum from 8609 to 9349 PASS results. > > Release managers: is it acceptable to commit this to trunk in > stage 4? It purely touches jit-related code/testcases, but I > appreciate it's very late to be adding features. > > Otherwise I'll commit it in the next stage 1. I've committed this to trunk (for gcc 8) as r247111. [...snip...]