From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88377 invoked by alias); 20 Mar 2018 19:43:16 -0000 Mailing-List: contact jit-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: Sender: jit-owner@gcc.gnu.org Received: (qmail 88338 invoked by uid 89); 20 Mar 2018 19:43:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.4 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KAM_SHORT,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=HTo:U*ro, Manager X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KAM_SHORT,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Mar 2018 19:43:06 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A7585356F6; Tue, 20 Mar 2018 19:43:05 +0000 (UTC) Received: from ovpn-117-63.phx2.redhat.com (ovpn-117-63.phx2.redhat.com [10.3.117.63]) by smtp.corp.redhat.com (Postfix) with ESMTP id EAB3D1869D; Tue, 20 Mar 2018 19:43:04 +0000 (UTC) Message-ID: <1521574984.5688.36.camel@redhat.com> Subject: Re: Seeking Release Manager approval for: [PATCH] jit: fix link on OS X and Solaris (PR jit/64089 and PR jit/84288) From: David Malcolm To: Rainer Orth Cc: jakub@redhat.com, Richard Biener , FX , gcc patches , jit@gcc.gnu.org Date: Mon, 01 Jan 2018 00:00:00 -0000 In-Reply-To: References: <78D7B2DA-5677-4211-9C4E-F7B1B5AB51B5@gmail.com> <1518556781-10049-1-git-send-email-dmalcolm@redhat.com> <7D041128-A426-4B64-A0A2-8588B7F9984B@gmail.com> <1520604853.2913.118.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 20 Mar 2018 19:43:05 +0000 (UTC) X-IsSubscribed: yes X-SW-Source: 2018-q1/txt/msg00014.txt.bz2 On Tue, 2018-03-20 at 09:38 +0100, Rainer Orth wrote: > Hi David, > > > Release managers: > > > > I'd like to apply FX's patch here: > > https://gcc.gnu.org/ml/gcc-patches/2018-02/msg00881/patch > > to trunk, to fix the build of jit on OS X, and to make it easier to > > fix > > it on Solaris. > > > > This involves touching gcc/configure.ac (and configure). > > > > I've successfully bootstrapped and regression-tested it on x86_64- > > pc- > > linux-gnu. FX reports above that it fixes the build on macOS, and > > Rainer has an (untested) patch on top of it that ought to fix the > > build > > on Solaris: > > https://gcc.gnu.org/ml/gcc-patches/2018-02/msg00835.html > > I've now tested the patch (together with the one from PR jit/84288 > for > several remaining issues). I've needed another snippet for > Solaris/SPARC which links libkstat into xgcc and needs it in > libgccjit.so, too. Bootstrapped without regressions on > i386-pc-solaris2.11 and sparc-sun-solaris2.11. FWIW I've successfully tested this on x86_64-pc-linux-gnu (regenerating the gcc/configure), and, as jit maintainer, it looks good to me [1], though it may still need RM approval given stage 4. Dave [1] ...though I have a slight preference for listing $(EXTRA_GCC_LIBS) on the same line as $(EXTRA_GCC_OBJS) in jit/Make- lang.in, so that these two items needed to embed the driver code into the libgccjit shared library are visually grouped together. > Ok for mainline? > > Rainer >