From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sender4-pp-o90.zoho.com (sender4-pp-o90.zoho.com [136.143.188.90]) by sourceware.org (Postfix) with ESMTPS id B92023858283; Thu, 15 Feb 2024 14:32:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B92023858283 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=zoho.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=zoho.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B92023858283 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=136.143.188.90 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1708007565; cv=pass; b=xQsfSJzAx8Ezztd/obUh40IyoD9uNgiEHfMrZDXvPUgAvI1fULCakW6KnszRNJb0StSJgB7RYHtXeEtLKIF0O2ZkffOCVGLaxwUqwHywVoOGPQSqsUCvJaVTcVh03uvQF6m3qJmAIqthLrAu49KwP07loGiupikTrX9FnSjQN1w= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1708007565; c=relaxed/simple; bh=OI+9obvY4pZGmL054NDZij6v54NYIzVGLm7hSAB0bdM=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=HIymPs3w8GDKdmB0FAuSvQQ66W7vkT/+EMzQjgLUo8RpuMmoNa95GptKP7gq7wIZuUiatkz5cuHoxqDcCcSomikP00cv96r3fzOnDhygMD9yxzObap+tLPYm/HhOHE/wJVNoZoHohlE727GGWtyhpIB9hWNy3zjRU9aHOxz3GV8= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; t=1708007558; cv=none; d=zohomail.com; s=zohoarc; b=P8jFHFTDlDzY6ZR7dwU4Cc9zGYvyNo1yEYUgjooQd6NAZghXVLeqINz+32g7O6Lmr5Yw+bWEmMMhNdLu8M+9NGvmJiM1P8dPyLjzmGoQumiI3mYw2XybtzmDULzzj2lai6hfhhvowV2fIfESangOAccXC3f5B5OwqQ2y4sfy8og= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1708007558; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=OI+9obvY4pZGmL054NDZij6v54NYIzVGLm7hSAB0bdM=; b=FgDKZaH92n4yu7yzc5jU82lsuiF733uUNVNcv19rCd3GCVoZdsxOzalFjGarBT3kD6dOo35g1QERGRrdnrbi6ifaB1R5NbeExmTuLoNmaYGkfRM14patt7Zo/E77f9KU9N0S/qTzA8BXxlT26WuzlFcBP5BunNWeSsLuJVytp28= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=zoho.com; spf=pass smtp.mailfrom=bouanto@zoho.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1708007558; s=zm2022; d=zoho.com; i=bouanto@zoho.com; h=Message-ID:Subject:Subject:From:From:To:To:Cc:Cc:Date:Date:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:MIME-Version:Feedback-ID:Message-Id:Reply-To; bh=OI+9obvY4pZGmL054NDZij6v54NYIzVGLm7hSAB0bdM=; b=g6CFOmxM/dV80k/KzlE2VFFO8vMu77qLcGbpxpy7A/rYj+uTWglHAdvAEMegsWmt FVU8cqDM0yrQ1tKhyz6tOAKeT1wOOKUutPrVXGp+7eRhazHy1m6kqRzU8Kdv6YuARRL rhMlKA4ws83ufTjpE7swFtEhXz+wOlqF5/Z3tXqs= Received: from [192.168.1.172] (38.87.11.6 [38.87.11.6]) by mx.zohomail.com with SMTPS id 17080075567458.599794398935728; Thu, 15 Feb 2024 06:32:36 -0800 (PST) Message-ID: <1528e00046d70c6804736192cd0733c4e90908cf.camel@zoho.com> Subject: Re: [PATCH] libgccjit: Add support for machine-dependent builtins From: Antoni Boucher To: David Malcolm , Andrew Pinski Cc: jit@gcc.gnu.org, gcc-patches@gcc.gnu.org Date: Thu, 15 Feb 2024 09:32:32 -0500 In-Reply-To: References: <184790403bd8227db4054b9e672afbfdf879dc0c.camel@zoho.com> <68c5b0693c8f7a6c6ce59259fdf088106861e4e4.camel@zoho.com> <0f44d7bb2d4baa961112e164cefa1bd0a8ec0b1c.camel@zoho.com> Autocrypt: addr=bouanto@zoho.com; prefer-encrypt=mutual; keydata=mQENBFOSMLQBCADO5aw6Ys8thMQUNzrwAnfJX2wbgWiz0pQ01DjYj22eeIpChkoZn6LWdt4dieq30u2rFi/yQzJ02foHwI2+aL9rU6xz/x4TwqyRJQGMOqklNc3R+pdXmH4WDQkQDWmLxvc07vu+zb8Tx5A6pMDh4J2ncCEhLEUcH39Yq/yg4eBnFwUX6N7kakvHrnScGNqhnSFCacoJeMJUAR+1G7VBSBd++jmnHLnx3mj7QkRZVECJUw2zqiv1yReCC6GU4SvqLjdqm5ZGeoWOqD/NHjBRoEeOVjzp6M/qOjjWRbkJVqmvgfcD8UytSSqqboR35YFT4L+rZt2ri3T12MJb3i5syCAXABEBAAG0IUFudG9uaSBCb3VjaGVyIDxib3VhbnRvQHpvaG8uY29tPokBVgQTAQgAQAIbIwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAFiEEOELC4Uw1Jeb66YE6RVeGAwR4zcEFAlz4QM4FCRLMEZoACgkQRVeGAwR4zcFBQQf/afttJrA/puADQZhrDfkgr0MFvq6iB+GCy1b8BkXimk1TOXTPt87YLehSeijNu3JkYhl5eRc87BNfU9J87KfI/KIy6hZxqlDXk16FhW9bw/7wYEA0hpb3MUn7xLElXDT0ZHaD+KTe8Oun7qfzgx5RlL6r/WODf3CkSpO085R/rfeBqDEx9mVlhDWgq6Az3CZoD+3CqiCKVqmDuHTWz4kwrd9AM5eVcLvvLKnZIdoIp+G5Ao6BvaGlZyfenN1iOSjLy2NXNt4MnUt0lUYEP5KSIIRhHQ8xkUbj7eWUmaahkxhNb3fH3sAPwGnRZrPpb4rgYzNmSk63wWMh9M2xk+rLb7kBDQRTkjC0AQgAumZzsAV/UFWI+dpzebQfma36kKYZZFuseant5sq/HWP553XQ/U6ttJiKyN5MpCqtxvCAoRplf42YhlHuFqgf73WJxoJ6Y+sdyqoBSwlR+ gzAneAmsa8gmmY0wawH0Z2leazjKuS7mJjVEQZg0ZGsiCVRGeRnDqFGzDEzDc9ngWKSoTq0fKzlGy1X85OrtmUrvEbhSo6HP+FoeunHkIqrxu3w3vDoFEXxVQlKI6V3I4nCz5n6DB8WR3L7nsiiTnOiGirPw1ngvWFLW86kkA4FJpayc8Xl3va3SLY+2y4yuROboX2DVI4AC/Qeug/mDiBicPxkP6YfUartQRMe6obkEQARAQABiQE8BBgBCAAmAhsMFiEEOELC4Uw1Jeb66YE6RVeGAwR4zcEFAlz4QRsFCRLMEecACgkQRVeGAwR4zcE56ggAgTgrJInBKC+7552Dpccuo6Clh3wZfjlNLv9/6r5lKEbaNzaTrfhPiAP4WgnluIUmj8amOFLFJpj+BAVNOXpZ4D2R3o9ch8z7fot+fW4Yw+PKIxH4I2xEys8ndoEB3aiQwHjKcGIhkIU7uyMJFQr2aWjdTY0gmXw0YZueHOSLgo7uX4XKxB8fEO/yto/Tff2YBAAq+AtNwt+Gh5YS9rZw7rwUTWMi84yVOlc+zRE79E9NJkvdTwX7IJYo64VzIRNfgHsn7QNdVzuM1XIFHl+Glk6cIlI8s6BO7nEoCn3hTF104fQTAO3fEs+XXZOKXo2lk8faowEoPq5r58StrV0nyg== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.3 MIME-Version: 1.0 Feedback-ID: rr08011228784a4e40d200911daa38e62b000046864d0a3a02ca4419cd478bea3d4453809163e552cf760d06fa:zu08011226c4a09bf0e121d5dcac10c1a3000031a62d7b5655a56f50ed26dbce7c4bd552e9c78a279634cb:rf080112325bfd067ec16ec68bc81cc62c0000109c7005142ba5ecb22bdbb5eb0fe4ef1c298d23969d5d9a621a38103b233f7bf80d12f9:ZohoMail X-ZohoMailClient: External X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: David: Ping On Thu, 2024-02-08 at 08:59 -0500, Antoni Boucher wrote: > David: Ping. >=20 > On Wed, 2024-01-10 at 18:58 -0500, Antoni Boucher wrote: > > Here it is: https://gcc.gnu.org/pipermail/jit/2023q4/001725.html > >=20 > > On Wed, 2024-01-10 at 18:44 -0500, David Malcolm wrote: > > > On Wed, 2024-01-10 at 18:29 -0500, Antoni Boucher wrote: > > > > David: Ping in case you missed this patch. > > >=20 > > > For some reason it's not showing up in patchwork (or, at least, I > > > can't > > > find it there).=C2=A0 Do you have a URL for it there? > > >=20 > > > Sorry about this > > > Dave > > >=20 > > > >=20 > > > > On Sat, 2023-02-11 at 17:37 -0800, Andrew Pinski wrote: > > > > > On Sat, Feb 11, 2023 at 4:31 PM Antoni Boucher via Gcc- > > > > > patches > > > > > wrote: > > > > > >=20 > > > > > > Hi. > > > > > > This patch adds support for machine-dependent builtins in > > > > > > libgccjit > > > > > > (bug 108762). > > > > > >=20 > > > > > > There are two things I don't like in this patch: > > > > > >=20 > > > > > > =C2=A01. There are a few functions copied from the C frontend > > > > > > (common_mark_addressable_vec and a few others). > > > > > >=20 > > > > > > =C2=A02. Getting a target builtin only works from the second > > > > > > compilation > > > > > > since the type information is recorded at the first > > > > > > compilation. > > > > > > I > > > > > > couldn't find a way to get the builtin data without using > > > > > > the > > > > > > langhook. > > > > > > It is necessary to get the type information for type > > > > > > checking > > > > > > and > > > > > > instrospection. > > > > > >=20 > > > > > > Any idea how to fix these issues? > > > > >=20 > > > > > Seems like you should do this patch in a few steps; that is > > > > > split > > > > > it > > > > > up. > > > > > Definitely split out GCC_JIT_TYPE_BFLOAT16 support. > > > > > I also think the vector support should be in a different > > > > > patch > > > > > too. > > > > >=20 > > > > > Splitting out these parts would definitely make it easier for > > > > > review > > > > > and make incremental improvements. > > > > >=20 > > > > > Thanks, > > > > > Andrew Pinski > > > > >=20 > > > > >=20 > > > > >=20 > > > > > >=20 > > > > > > Thanks for the review. > > > >=20 > > >=20 > >=20 >=20