From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82245 invoked by alias); 10 Jan 2019 19:30:44 -0000 Mailing-List: contact jit-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: Sender: jit-owner@gcc.gnu.org Received: (qmail 78064 invoked by uid 89); 10 Jan 2019 19:30:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KAM_SHORT,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=akrl X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KAM_SHORT,SPF_HELO_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Jan 2019 19:30:36 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7D1FA37EEF; Thu, 10 Jan 2019 19:30:34 +0000 (UTC) Received: from ovpn-116-42.phx2.redhat.com (ovpn-116-42.phx2.redhat.com [10.3.116.42]) by smtp.corp.redhat.com (Postfix) with ESMTP id 620E75D757; Thu, 10 Jan 2019 19:30:33 +0000 (UTC) Message-ID: <1547148632.7788.167.camel@redhat.com> Subject: Re: about header file parsing From: David Malcolm To: akrl , Marc =?ISO-8859-1?Q?Nieper-Wi=DFkirchen?= Cc: basile@starynkevitch.net, jit@gcc.gnu.org Date: Tue, 01 Jan 2019 00:00:00 -0000 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 10 Jan 2019 19:30:34 +0000 (UTC) X-IsSubscribed: yes X-SW-Source: 2019-q1/txt/msg00036.txt.bz2 On Thu, 2019-01-10 at 19:06 +0000, akrl wrote: [...] > Hi, > today I've wrote a patch that adds GCC_JIT_STR_NEEDED_LIBRARIES to > gcc_jit_str_option. > This was to specify a space separated list of the libraries to link > against. > I was going to submit the patch for review but this solution seams to > be > more general. FWIW, although it sounds like it's no longer relevant here, I prefer to avoid extending the enum gcc_jit_str_option and enum gcc_jit_int_option enumerations, in favor of adding new API entrypoints, for the ABI- detection reason given here: https://gcc.gnu.org/onlinedocs/jit/topics/contexts.html#options i.e. "Adding entrypoints for each new option means that client code that use the new options can be identified directly from binary metadata, which would not be possible if we instead extended the various enum gcc_jit_*_option." > If we agree on an interface I propose my self to do the patch in > order > to have the occasion to setup the whole process. > > Bests > > Andrea It's great to have new contributors to the project. Andrea: FWIW, the FSF requires some legal paperwork before I can accept non-trivial patches; see: https://gcc.gnu.org/contribute.html#legal If you're hoping to send non-trivial patches, it might be an idea to look into that (unless you already have the FSF paperwork in place?) Thanks Dave