From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53432 invoked by alias); 2 Jul 2019 14:46:36 -0000 Mailing-List: contact jit-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: Sender: jit-owner@gcc.gnu.org Received: (qmail 53413 invoked by uid 89); 2 Jul 2019 14:46:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,KAM_SHORT,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=H*Ad:U*jit, person X-Spam-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,KAM_SHORT,SPF_HELO_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 02 Jul 2019 14:46:34 +0000 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4C585309B15B; Tue, 2 Jul 2019 14:46:13 +0000 (UTC) Received: from ovpn-117-34.phx2.redhat.com (ovpn-117-34.phx2.redhat.com [10.3.117.34]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8F6FF1001B00; Tue, 2 Jul 2019 14:46:11 +0000 (UTC) Message-ID: <1562078770.2530.36.camel@redhat.com> Subject: Re: [PATCH][gcc] libgccjit: check result_type in gcc_jit_context_new_binary_op From: David Malcolm To: Andrea Corallo Cc: "gcc-patches@gcc.gnu.org" , "jit@gcc.gnu.org" , nd Date: Tue, 01 Jan 2019 00:00:00 -0000 In-Reply-To: References: <1560897082.3885.10.camel@redhat.com> <1561391539.3885.22.camel@redhat.com> <1561409068.3885.28.camel@redhat.com> <1561555176.13494.13.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Tue, 02 Jul 2019 14:46:21 +0000 (UTC) X-IsSubscribed: yes X-SW-Source: 2019-q3/txt/msg00001.txt.bz2 On Wed, 2019-06-26 at 15:05 +0000, Andrea Corallo wrote: > David Malcolm writes: > > > On Tue, 2019-06-25 at 08:11 +0000, Andrea Corallo wrote: > > > Hi, > > > third version for this patch with the simplified test. > > > > > > make check-jit pass clean > > > > > > Bests > > > Andrea > > > > > > 2019-06-09 Andrea Corallo andrea.corallo@arm.com > > > > > > * libgccjit.c (gcc_jit_context_new_binary_op): Check result_type > > > to > > > be a > > > numeric type. > > > > > > > > > 2019-06-20 Andrea Corallo andrea.corallo@arm.com > > > > > > * jit.dg/test-error-gcc_jit_context_new_binary_op-bad-res-type.c: > > > New testcase. > > > > Thanks for the updated patch. > > > > This is good for trunk. > > > > (Copying and pasting from my other review): are you working on > > getting > > SVN commit access, or do you want me to commit your two patches on > > your > > behalf? > > > > Thanks > > Dave > > Hi David, > I can work on to get the SVN commit access. > As a maintainer has to sponsor it would you mind being the one? https://www.gnu.org/software/gcc/svnwrite.html says: "a well-established GCC maintainer (including reviewers) can approve for write access any person with GNU copyright assignment papers in place and known to submit good patches." Thanks for your patches so far. I approve of you getting "Write after approval" access to GCC svn, provided the copyright assignment paperwork is in place (which I'm assuming is, based on your @arm.com email address). I'm not quite sure what the next steps are. Dave