From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [63.128.21.74]) by sourceware.org (Postfix) with ESMTP id 9E727385B836 for ; Tue, 31 Mar 2020 01:13:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9E727385B836 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-360-ue07RSPmMn2r3MbPHNsBeA-1; Mon, 30 Mar 2020 21:13:19 -0400 X-MC-Unique: ue07RSPmMn2r3MbPHNsBeA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C98B3107ACC4; Tue, 31 Mar 2020 01:13:17 +0000 (UTC) Received: from ovpn-112-87.phx2.redhat.com (ovpn-112-87.phx2.redhat.com [10.3.112.87]) by smtp.corp.redhat.com (Postfix) with ESMTP id D73381001B2B; Tue, 31 Mar 2020 01:13:16 +0000 (UTC) Message-ID: <15cbf5f7479eae3833dc67d749c7597534dcfa8e.camel@redhat.com> Subject: Re: [PATCH V3][gcc] libgccjit: introduce version entry points From: David Malcolm To: Andrea Corallo Cc: "jit@gcc.gnu.org" , nd , gcc-patches@gcc.gnu.org Date: Mon, 30 Mar 2020 21:13:15 -0400 In-Reply-To: <173d44aa6bde239d25597223c55c1c6a7c1ae9cd.camel@redhat.com> References: <330ed10fb3e66abdbc5d30fdf2ba2fd3c3b30cf6.camel@redhat.com> <878sjivr6m.fsf@arm.com> <173d44aa6bde239d25597223c55c1c6a7c1ae9cd.camel@redhat.com> User-Agent: Evolution 3.32.5 (3.32.5-1.fc30) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-16.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: jit@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Jit mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Mar 2020 01:13:25 -0000 On Mon, 2020-03-30 at 12:09 -0400, David Malcolm via Gcc-patches wrote: > On Sun, 2020-03-29 at 21:31 +0100, Andrea Corallo wrote: > > David Malcolm writes: > > > > > On Wed, 2020-03-18 at 23:51 +0100, Andrea Corallo wrote: > > > Please add the new test to the header in its alphabetical > > > location, > > > i.e. between: > > > > > > /* test-vector-types.cc: We don't use this, since it's C++. */ > > > > > > and > > > > > > /* test-volatile.c */ > > > > > > An entry also needs to be added to the "testcases" array at the > > > end > > > of > > > the header (again, in the alphabetical-sorted location). > > > > I tried adding the test into the "testcases" array but this makes > > the > > threads test failing. > > > > I think this has nothing to do with this patch and happen just > > because > > this test does not define any code. Infact I see the same > > happening > > just adding "test-empty.c" to the "testcases" array on the current > > master. > > > > The error is not very reproducible, I tried a run under valgrind > > but > > have found nothing so far :/ > > > > Dave do you recall if there was a specific reason not to have > > "test-empty.c" into the "testcases" array? > > > > Andrea > > I replied to this as: > > [PATCH] lra: set insn_code_data to NULL when freeing > https://gcc.gnu.org/pipermail/gcc-patches/2020-March/542929.html > > but forgot to set the reply-to in git send-email; sorry. > Andrea: I've pushed my proposed fix for the above to master as 3809bcd6c0ee324cbd855c68cee104c8bf134dbe. Does this fix the issue you were seeing? Thanks Dave