From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10143 invoked by alias); 8 Dec 2014 21:58:43 -0000 Mailing-List: contact jit-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: Sender: jit-owner@gcc.gnu.org Received: (qmail 10124 invoked by uid 89); 8 Dec 2014 21:58:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.98.4 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: resqmta-ch2-01v.sys.comcast.net Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: PING: Re: [PATCH 05/05] Add command-line option-parsing to jit testcases From: Mike Stump In-Reply-To: <1418071451.11824.148.camel@surprise> Date: Wed, 01 Jan 2014 00:00:00 -0000 Cc: gcc-patches@gcc.gnu.org, jit@gcc.gnu.org, Jeff Law Content-Transfer-Encoding: quoted-printable Message-Id: <1B88C10F-930B-4C8B-B1E4-CCB8D1807972@comcast.net> References: <546CCC00.209@redhat.com> <1416965664-15360-1-git-send-email-dmalcolm@redhat.com> <1416965664-15360-6-git-send-email-dmalcolm@redhat.com> <1418071451.11824.148.camel@surprise> To: David Malcolm X-Mailer: Apple Mail (2.1878.6) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20140121; t=1418075919; bh=Dieg+ub9Q/D3vFRfbGhSTJFWb//ZIA+uCoAiX7LLDt4=; h=Received:Received:Content-Type:Mime-Version:Subject:From:Date: Message-Id:To; b=B1f6P9NiW/+qClro0ihxW4rk5CJQSdWwuIG7oFhuqHHOoAJEdyY1tWXlu6upth9q1 KExwvVbAHCeW3hO+yh0Sob72MuMyCDt9DvVHnl4/VFqVIhN8npPcxOOirvFEe8GXUb MJo2+WACo97DB/t/C6waSS8ABbVf3fvP/t1P59lgYCKZ0RNptE5t4FyOH1QyuYw3Zh ajPNCCRV00Bkfk1+wwma4r4V4r4kE/9uTg+EpxmTItLnAX0WtzGA7Q2np63wiHtBxW vAb9jP1E2hzQIHfCLIEH37tm3jB1AI6wWGz/lVUJO3w//bhX2eEHWyk4FkVKrGihPj V0r1++N4g7/zw== X-SW-Source: 2014-q4/txt/msg00239.txt.bz2 On Dec 8, 2014, at 12:44 PM, David Malcolm wrote: > On Tue, 2014-11-25 at 20:34 -0500, David Malcolm wrote: >> Add command-line option-parsing to the testcases, so that we can >> manipulate them without needing a recompile (e.g. varying >> optimization levels etc). >>=20 >> This uses getopt_long, which is a GNU extension to libc. Is that >> acceptable? >=20 > Ping. Specifically, is it acceptable to use getopt_long within the jit > testcases, or should I find another way to do this (e.g. just getopt)? So, the standard by which we measure, does it kill building or testing of a= da on mingwin? If it does, then no, not acceptable. I=92d like to think t= here is nothing you can do in jit.exp that could do that. So, from this pe= rspective, yeah, feel free to do what you want. Git it done first. The se= cond person that wants to port your code to a new machine (a different mach= ine) will trip over all the bad things you did, and someone will then have = to fix them. If you only use what gcc already sues, you will be portable to everything g= cc is portable to. If you use GNU extensions to libc, well, that isn=92t p= ortable enough in general. Heck, even what=92s in libc isn=92t portable en= ough, that=92s half the reason why we have autoconf in the first place. If jit is on by default everywhere, then you need to be portable everywhere= . If only on for linux, then well, it already has GNU extensions in libc. = I don=92t know if it is on by default and you didn=92t say, so, hard to co= mment on it.