From: Trevor Saunders <tbsaunde@tbsaunde.org>
To: Pedro Alves <palves@redhat.com>
Cc: David Malcolm <dmalcolm@redhat.com>,
gcc-patches@gcc.gnu.org, jit@gcc.gnu.org
Subject: Re: [PATCH 1/2] Add OVERRIDE and FINAL macros to coretypes.h
Date: Fri, 01 Jan 2016 00:00:00 -0000 [thread overview]
Message-ID: <20160506183345.GK3628@ball> (raw)
In-Reply-To: <8ce94f18-421f-9466-85cf-e17d9caee151@redhat.com>
On Fri, May 06, 2016 at 07:10:33PM +0100, Pedro Alves wrote:
> On 05/06/2016 06:56 PM, Pedro Alves wrote:
>
> > If building gcc as a C++11 program is supported, then it
> > won't be possible to use these names as symbols for
> > anything else anyway?
>
> Just found out the above is not true. Apparently I've
> been stuck in C++98 for too long... Sorry about the noise.
>
> I was going to suggest to put this in include/ansidecl.h,
> so that all C++ libraries / programs in binutils-gdb use the same
> thing, instead of each reinventing the wheel, and I found
> there's already something there:
>
> /* This is used to mark a class or virtual function as final. */
> #if __cplusplus >= 201103L
> #define GCC_FINAL final
> #elif GCC_VERSION >= 4007
> #define GCC_FINAL __final
> #else
> #define GCC_FINAL
> #endif
>
> From:
>
> https://gcc.gnu.org/ml/gcc-patches/2015-08/msg00455.html
>
> Apparently the patch that actually uses that was reverted,
> as I can't find any use.
Yeah, I wanted to use it to work around gdb not dealing well with stuff
in the anon namespace, but somehow that broke aix, and some people
objected and I haven't gotten back to it.
> I like your names without the GCC_ prefix better though,
> for the same reason of standardizing binutils-gdb + gcc
> on the same symbols.
I agree, though I'm not really sure when gdb / binutils stuff will
support building as C++11.
Trev
>
>
> --
> Thanks,
> Pedro Alves
next prev parent reply other threads:[~2016-05-06 18:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-01 0:00 David Malcolm
2016-01-01 0:00 ` Pedro Alves
2016-01-01 0:00 ` Jason Merrill
2016-01-01 0:00 ` Pedro Alves
2016-01-01 0:00 ` Trevor Saunders [this message]
2016-01-01 0:00 ` Move OVERRIDE/FINAL from gcc/coretypes.h to include/ansidecl.h (was: Re: [PATCH 1/2] Add OVERRIDE and FINAL macros to coretypes.h) Pedro Alves
2016-01-01 0:00 ` Move OVERRIDE/FINAL from gcc/coretypes.h to include/ansidecl.h Bernd Schmidt
2016-01-01 0:00 ` Pedro Alves
2016-01-01 0:00 ` Bernd Schmidt
2016-01-01 0:00 ` Pedro Alves
2016-01-01 0:00 ` [wwwdocs, coding conventions] Mention OVERRIDE/FINAL David Malcolm
2016-01-01 0:00 ` Pedro Alves
2017-01-01 0:00 ` Gerald Pfeifer
2017-01-01 0:00 ` Trevor Saunders
2017-01-01 0:00 ` Gerald Pfeifer
2016-01-01 0:00 ` [PATCH 1/2] Add OVERRIDE and FINAL macros to coretypes.h Pedro Alves
2016-01-01 0:00 ` Jakub Jelinek
2016-01-01 0:00 ` CONSTEXPR macro (was "Re: [PATCH 1/2] Add OVERRIDE and FINAL macros to coretypes.h") David Malcolm
2016-01-01 0:00 ` Jakub Jelinek
2016-01-01 0:00 ` [PATCH 2/2] jit: use FINAL and OVERRIDE throughout David Malcolm
2016-01-01 0:00 ` David Malcolm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160506183345.GK3628@ball \
--to=tbsaunde@tbsaunde.org \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jit@gcc.gnu.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).