From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 8F62D3858C83 for ; Thu, 2 Mar 2023 22:33:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8F62D3858C83 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677796385; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Auv4kVveidgHTFigyxUN3q2ptmteslT4E/8WTHgkMD0=; b=JVHHNFMYbobHWighFasXQlib4bLYw7Z+pKP4BYa5IhqpFD4j9vMsgYlNWlTGFXCr2dkkrt TPLSbOp4PRg1fRjDFW/cwr3X83rlC3sUtT/ROjRRlh4Wor5GIZMJw2GoyWJvTyyMRxfvNh 4zAmKUqqIkk7lhjkhpTkjiALgcc0Flc= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-70-0wFRDffuOlOi3WmQaWQXTg-1; Thu, 02 Mar 2023 17:33:04 -0500 X-MC-Unique: 0wFRDffuOlOi3WmQaWQXTg-1 Received: by mail-qt1-f199.google.com with SMTP id x4-20020ac85384000000b003bfbb485e2dso428876qtp.22 for ; Thu, 02 Mar 2023 14:33:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677796383; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Auv4kVveidgHTFigyxUN3q2ptmteslT4E/8WTHgkMD0=; b=aODFBntgM+8kU+k5SO5n6ESo2pTUCk1nUMQJRQ9ep6WPSA0mZI3jGz/zzlRC9cQ/sj Uwd3HdP2J7/suvvt/Xk+Ms2AXjArtCR7dWzOM91Qrhw9w64y/AesKlmj30hwRV6lNUdv CPSbhLtRqEZy6CJtcQ1V5CJZWsy+lV76/tvurjkx5ge12FTAtRC3O4o68levSW4W2tr1 eD2Lb3UAu6yugFOBc5X/e3O2mrKnq+tx/FtNPijRz3aJF3QC3Em4ZlRT5oMJ1hWnjuMb s7KAzE7VPQmKDgXNPYazCe5qBlbdn3XNmtud0nzw/ZMq8HuC9YPCcyDx2F/UJ4txzI3i L7nQ== X-Gm-Message-State: AO0yUKXY64HoAv5Ud3KVbx9BJprsdSyv9eEx2c9dW8DNnQnh8zmJzSIu j9u33ALFAAFb923kPS5k1uiLsmDP9LsmshutbcgbL8yB2DHZwFBE14d7e0t0g+hftLNBSMPVFQW Id5TSxyQ= X-Received: by 2002:a05:6214:23c9:b0:570:5389:2206 with SMTP id hr9-20020a05621423c900b0057053892206mr19395529qvb.0.1677796383691; Thu, 02 Mar 2023 14:33:03 -0800 (PST) X-Google-Smtp-Source: AK7set+2cK7vKaqZSyCn6Pzl4GBTLzrYDft/FBsEjm5hJFOcDTalfLEB2Zpkj5MAlyfcuDDiML689g== X-Received: by 2002:a05:6214:23c9:b0:570:5389:2206 with SMTP id hr9-20020a05621423c900b0057053892206mr19395508qvb.0.1677796383460; Thu, 02 Mar 2023 14:33:03 -0800 (PST) Received: from t14s.localdomain (c-73-69-212-193.hsd1.ma.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id e3-20020a05620a014300b00742e61999a3sm522433qkn.64.2023.03.02.14.33.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Mar 2023 14:33:03 -0800 (PST) Message-ID: <232081fba9a447be10b80abede13127d4cea213c.camel@redhat.com> Subject: Re: [PATCH] libgccjit: Fix a failing test From: David Malcolm To: Guillaume Gomez Cc: Antoni Boucher , gcc-patches@gcc.gnu.org, jit@gcc.gnu.org Date: Thu, 02 Mar 2023 17:33:02 -0500 In-Reply-To: References: <817e1aaf5f61ebeb2f607d9a7411ca0570e8213f.camel@zoho.com> User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 2023-03-02 at 23:29 +0100, Guillaume Gomez wrote: > Just realized I used whitespace and not a tab. Sorry about that. > Here's the > fixed version... Looks great. Do you have push rights, or do you want me to push this? Thanks Dave >=20 > Le jeu. 2 mars 2023 =C3=A0 23:19, Guillaume Gomez > a > =C3=A9crit : >=20 > > No problem, thanks for the explanations. > >=20 > > I joined the patch with the fixed commit message. > >=20 > > Le jeu. 2 mars 2023 =C3=A0 22:58, David Malcolm a > > =C3=A9crit : > >=20 > > > On Thu, 2022-12-15 at 08:34 +0100, Guillaume Gomez via Jit wrote: > > > > Forgot it indeed, thanks for notifying me! > > > >=20 > > > > I modified the commit message to add it and added it into this > > > > email. > > >=20 > > > Sorry about the delay in reviewing this; for some reason I didn't > > > see > > > the mail. > > >=20 > > > The patch looks good for trunk, but please add a reference to > > > =C2=A0 PR jit/107999 > > > to the subject line and ChangeLog message. > > >=20 > > > Dave > > >=20 > > > >=20 > > > > Le mer. 14 d=C3=A9c. 2022 =C3=A0 16:12, Antoni Boucher > > > > a > > > > =C3=A9crit : > > > >=20 > > > > > Thanks! > > > > >=20 > > > > > In your patch, you're missing this line at the end of the > > > > > commit > > > > > message: > > > > >=20 > > > > > =C2=A0=C2=A0 Signed-off-by: Guillaume Gomez > > > > > > > > > >=20 > > > > > On Wed, 2022-12-14 at 14:39 +0100, Guillaume Gomez via Jit > > > > > wrote: > > > > > > Hi, > > > > > >=20 > > > > > > This fixes bug 107999. > > > > > >=20 > > > > > > Thanks in advance for the review. > > > > >=20 > > > > >=20 > > >=20 > > >=20