From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sender4-pp-o90.zoho.com (sender4-pp-o90.zoho.com [136.143.188.90]) by sourceware.org (Postfix) with ESMTPS id C2BDB3858D20; Thu, 7 Dec 2023 22:26:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C2BDB3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=zoho.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=zoho.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C2BDB3858D20 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=136.143.188.90 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1701987971; cv=pass; b=P6S6hE9ZRaguSiPpWjlyLCqoKE/XtIgLZINaukYv5V8DZpO9FXktJKicq9UQV3q1OTySo3Ukqg9X0WY2OSnEzadSJBWzrla87M+pVO1h+zg4sowmqm4XfARUumMQwnUoz9u+1Q0p0EkbGodUc2A9yqru1yoz5I+bCwYpFSpqYu0= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1701987971; c=relaxed/simple; bh=E5mxsV/qQXnNTNO8e+Bb3kFdh4aJBcLCmMwIzrm+7q4=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=d29oT7o0qdbAzIvoBe1OPfSdHAa6F+bDKi6eGAeGYJ+xuh/43GP/lhrvOt6OUYOt4r/T4O50Vnk45G8iWXEom5ZX5hnxGz2rIVjVfw0hlEkA0CLWwx6CowCyg7ZJtZSmoQXr3BJkyZA/5tAwictA+PusH7PIygwQu2vez7lgp50= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; t=1701987963; cv=none; d=zohomail.com; s=zohoarc; b=kxtLnH9j7V5Cdl02O3XTg2toHTEk3HBGxEdWVcMhINXywxE153g792WHQ4v2kKQVbc+58G5NXqnzWPZEv151DPwsOLXMtZ/zpHYwmcOsN918j9zOzLQm4H/Pd9/Thc1y4iu0taeg8fWKjUU6PbTJ3NKFe5yiY3ERbxKBDhdMJo4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1701987963; h=Content-Type:Cc:Cc:Date:Date:From:From:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=HU4HiBv64EL+BKs1tJ9JhNwmceT5SlYZ3Re66/N+sK0=; b=Aa9LF2Vz0Ze7Rsz7f30XAeEZ4KaMlZWLv2MAoABPP37JoXDm6XMEmy5v3p9XPNsA1qsgKMldsObTOQoP6etSiMfy6fFi+ujP50SskBc3a+Ab5TxMKECyvZbCAfaEy68mON3njluWTEHevdU9DxTv9AQJOvJB8MHEwkwz4jh6VOk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=zoho.com; spf=pass smtp.mailfrom=bouanto@zoho.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1701987963; s=zm2022; d=zoho.com; i=bouanto@zoho.com; h=Message-ID:Subject:Subject:From:From:To:To:Cc:Cc:Date:Date:Content-Type:MIME-Version:Feedback-ID:Message-Id:Reply-To; bh=HU4HiBv64EL+BKs1tJ9JhNwmceT5SlYZ3Re66/N+sK0=; b=YmpR/OLrc5RsnD7mBz+PyFSTZ+GKJbHivtEhervj17euiwMzTkE+LnuN7jQb3YBh NwLZk0SpUt1R3J89z2+xgnVVIrzFapZUGd2uMjoiWF1LvjB1zgfGAu8GW9WfiJVc1S2 29W0QhNlf6V7dxRU4//A0A5su3eZ0nYhOX3pGDcY= Received: from [192.168.1.172] (38.87.11.6 [38.87.11.6]) by mx.zohomail.com with SMTPS id 1701987963301214.3867024757584; Thu, 7 Dec 2023 14:26:03 -0800 (PST) Message-ID: <295f32d194b7b26bd02ce540f8df75a86fc20982.camel@zoho.com> Subject: [PATCH] libgccjit: Fix get_size of size_t From: Antoni Boucher To: jit@gcc.gnu.org, gcc-patches@gcc.gnu.org Cc: David Malcolm Date: Thu, 07 Dec 2023 17:26:01 -0500 Autocrypt: addr=bouanto@zoho.com; prefer-encrypt=mutual; keydata=mQENBFOSMLQBCADO5aw6Ys8thMQUNzrwAnfJX2wbgWiz0pQ01DjYj22eeIpChkoZn6LWdt4dieq30u2rFi/yQzJ02foHwI2+aL9rU6xz/x4TwqyRJQGMOqklNc3R+pdXmH4WDQkQDWmLxvc07vu+zb8Tx5A6pMDh4J2ncCEhLEUcH39Yq/yg4eBnFwUX6N7kakvHrnScGNqhnSFCacoJeMJUAR+1G7VBSBd++jmnHLnx3mj7QkRZVECJUw2zqiv1yReCC6GU4SvqLjdqm5ZGeoWOqD/NHjBRoEeOVjzp6M/qOjjWRbkJVqmvgfcD8UytSSqqboR35YFT4L+rZt2ri3T12MJb3i5syCAXABEBAAG0IUFudG9uaSBCb3VjaGVyIDxib3VhbnRvQHpvaG8uY29tPokBVgQTAQgAQAIbIwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAFiEEOELC4Uw1Jeb66YE6RVeGAwR4zcEFAlz4QM4FCRLMEZoACgkQRVeGAwR4zcFBQQf/afttJrA/puADQZhrDfkgr0MFvq6iB+GCy1b8BkXimk1TOXTPt87YLehSeijNu3JkYhl5eRc87BNfU9J87KfI/KIy6hZxqlDXk16FhW9bw/7wYEA0hpb3MUn7xLElXDT0ZHaD+KTe8Oun7qfzgx5RlL6r/WODf3CkSpO085R/rfeBqDEx9mVlhDWgq6Az3CZoD+3CqiCKVqmDuHTWz4kwrd9AM5eVcLvvLKnZIdoIp+G5Ao6BvaGlZyfenN1iOSjLy2NXNt4MnUt0lUYEP5KSIIRhHQ8xkUbj7eWUmaahkxhNb3fH3sAPwGnRZrPpb4rgYzNmSk63wWMh9M2xk+rLb7kBDQRTkjC0AQgAumZzsAV/UFWI+dpzebQfma36kKYZZFuseant5sq/HWP553XQ/U6ttJiKyN5MpCqtxvCAoRplf42YhlHuFqgf73WJxoJ6Y+sdyqoBSwlR+ gzAneAmsa8gmmY0wawH0Z2leazjKuS7mJjVEQZg0ZGsiCVRGeRnDqFGzDEzDc9ngWKSoTq0fKzlGy1X85OrtmUrvEbhSo6HP+FoeunHkIqrxu3w3vDoFEXxVQlKI6V3I4nCz5n6DB8WR3L7nsiiTnOiGirPw1ngvWFLW86kkA4FJpayc8Xl3va3SLY+2y4yuROboX2DVI4AC/Qeug/mDiBicPxkP6YfUartQRMe6obkEQARAQABiQE8BBgBCAAmAhsMFiEEOELC4Uw1Jeb66YE6RVeGAwR4zcEFAlz4QRsFCRLMEecACgkQRVeGAwR4zcE56ggAgTgrJInBKC+7552Dpccuo6Clh3wZfjlNLv9/6r5lKEbaNzaTrfhPiAP4WgnluIUmj8amOFLFJpj+BAVNOXpZ4D2R3o9ch8z7fot+fW4Yw+PKIxH4I2xEys8ndoEB3aiQwHjKcGIhkIU7uyMJFQr2aWjdTY0gmXw0YZueHOSLgo7uX4XKxB8fEO/yto/Tff2YBAAq+AtNwt+Gh5YS9rZw7rwUTWMi84yVOlc+zRE79E9NJkvdTwX7IJYo64VzIRNfgHsn7QNdVzuM1XIFHl+Glk6cIlI8s6BO7nEoCn3hTF104fQTAO3fEs+XXZOKXo2lk8faowEoPq5r58StrV0nyg== Content-Type: multipart/mixed; boundary="=-n4d+r6MXXAQaedHASNps" User-Agent: Evolution 3.50.2 MIME-Version: 1.0 X-Zoho-Virus-Status: 1 X-Zoho-AV-Stamp: zmail-av-1.1.0/201.873.56 Feedback-ID: rr0801122868e0ed64522ea1b4735658ed000012d682654f97e7c22cecd5ff1a6d633dc93e30b891563c536ed9:zu08011226da1dc56c524983d52d0baae20000bd85e905c983efb7aba3ad2990acf3bc9287c6bebb6e1c3e:rf08011232789e2d6f39ad8e0845ac7fcd0000f7ff2b82f13ba821fe3c9ea0e473e9588314d4b6ddde57397ff5e04334a128894b1934d6:ZohoMail X-ZohoMailClient: External X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --=-n4d+r6MXXAQaedHASNps Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi. This patch fixes getting the size of size_t (bug 112910). There's one issue with this patch: like every other feature that checks for target-specific stuff, it requires a compilation before actually fetching the size of the type. Which means that getting the size before a compilation might be wrong (and I actually believe is wrong on x86-64). I was wondering if we should always implicitely do the first compilation to gather the correct info: this would fix this issue and all the others that we have due to that. I'm not sure what would be the performance implication. Another solution that I have been thinking about for a while now would be to have another frontend libgccaot (I don't like that name), which is like libgccjit but removes the JIT part so that we get access to the target stuff directly and would remove the need for having a seperation between recording and playback as far as I understand. That's a long-term solution, but I wanted to share the idea now and gather your thoughts on that. Thanks for the review. --=-n4d+r6MXXAQaedHASNps Content-Disposition: attachment; filename="0001-libgccjit-Fix-get_size-of-size_t.patch" Content-Type: text/x-patch; name="0001-libgccjit-Fix-get_size-of-size_t.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSAzN2QyNWU1NWEwYzc5ODkzYzdlYTdmNGNiOWYwODQyYjhhOWI0OTA2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmkgQm91Y2hlciA8Ym91YW50b0B6b2hvLmNvbT4KRGF0 ZTogRnJpLCAzIE5vdiAyMDIzIDE3OjQ5OjE4IC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gbGliZ2Nj aml0OiBGaXggZ2V0X3NpemUgb2Ygc2l6ZV90CgpnY2Mvaml0L0NoYW5nZUxvZzoKCVBSIGppdC8x MTI5MTAKCSogaml0LXJlY29yZGluZy5jYyAocmVjb3JkaW5nOjptZW1lbnRvX29mX2dldF90eXBl OjpnZXRfc2l6ZSk6CglDb3JyZWN0bHkgY29tcHV0ZSB0aGUgc2l6ZSBvZiBzaXplX3QuCi0tLQog Z2NjL2ppdC9qaXQtcmVjb3JkaW5nLmNjIHwgMjkgKysrKysrKysrKysrKysrKysrKysrKysrKysr Ky0KIDEgZmlsZSBjaGFuZ2VkLCAyOCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZm IC0tZ2l0IGEvZ2NjL2ppdC9qaXQtcmVjb3JkaW5nLmNjIGIvZ2NjL2ppdC9qaXQtcmVjb3JkaW5n LmNjCmluZGV4IDliNWI4MDA1ZWJlLi5lYTFmNzZkNDQxNSAxMDA2NDQKLS0tIGEvZ2NjL2ppdC9q aXQtcmVjb3JkaW5nLmNjCisrKyBiL2djYy9qaXQvaml0LXJlY29yZGluZy5jYwpAQCAtMjM5Miw3 ICsyMzkyLDM0IEBAIHJlY29yZGluZzo6bWVtZW50b19vZl9nZXRfdHlwZTo6Z2V0X3NpemUgKCkK ICAgICAgIHNpemUgPSBMT05HX0RPVUJMRV9UWVBFX1NJWkU7CiAgICAgICBicmVhazsKICAgICBj YXNlIEdDQ19KSVRfVFlQRV9TSVpFX1Q6Ci0gICAgICBzaXplID0gTUFYX0JJVFNfUEVSX1dPUkQ7 CisgICAgICAvKiBDb21wYXJlIHdpdGggdHJlZS5jYydzIGJ1aWxkX2NvbW1vbl90cmVlX25vZGVz LiAgKi8KKyAgICAgIGlmIChzdHJjbXAgKFNJWkVfVFlQRSwgInVuc2lnbmVkIGludCIpID09IDAp CisgICAgICAgIHNpemUgPSBJTlRfVFlQRV9TSVpFOworICAgICAgZWxzZSBpZiAoc3RyY21wIChT SVpFX1RZUEUsICJsb25nIHVuc2lnbmVkIGludCIpID09IDApCisgICAgICAgIHNpemUgPSBMT05H X1RZUEVfU0laRTsKKyAgICAgIGVsc2UgaWYgKHN0cmNtcCAoU0laRV9UWVBFLCAibG9uZyBsb25n IHVuc2lnbmVkIGludCIpID09IDApCisgICAgICAgIHNpemUgPSBMT05HX0xPTkdfVFlQRV9TSVpF OworICAgICAgZWxzZSBpZiAoc3RyY21wIChTSVpFX1RZUEUsICJzaG9ydCB1bnNpZ25lZCBpbnQi KSA9PSAwKQorICAgICAgICBzaXplID0gU0hPUlRfVFlQRV9TSVpFOworICAgICAgZWxzZQorICAg ICAgeworICAgICAgICBpbnQgaTsKKworICAgICAgICBmb3IgKGkgPSAwOyBpIDwgTlVNX0lOVF9O X0VOVFM7IGkrKykKKyAgICAgICAgICBpZiAoaW50X25fZW5hYmxlZF9wW2ldKQorICAgICAgICAg IHsKKyAgICAgICAgICAgIGZwcmludGYgKHN0ZGVyciwgIiVkXG4iLCBpKTsKKyAgICAgICAgICAg IGNoYXIgbmFtZVs1MF0sIGFsdG5hbWVbNTBdOworICAgICAgICAgICAgc3ByaW50ZiAobmFtZSwg Il9faW50JWQgdW5zaWduZWQiLCBpbnRfbl9kYXRhW2ldLmJpdHNpemUpOworICAgICAgICAgICAg c3ByaW50ZiAoYWx0bmFtZSwgIl9faW50JWRfXyB1bnNpZ25lZCIsIGludF9uX2RhdGFbaV0uYml0 c2l6ZSk7CisKKyAgICAgICAgICAgIGlmIChzdHJjbXAgKG5hbWUsIFNJWkVfVFlQRSkgPT0gMCB8 fCBzdHJjbXAgKGFsdG5hbWUsIFNJWkVfVFlQRSkgPT0gMCkKKyAgICAgICAgICAgIHsKKyAgICAg ICAgICAgICAgcmV0dXJuIGludF9uX2RhdGFbaV0uYml0c2l6ZSAvIEJJVFNfUEVSX1VOSVQ7Cisg ICAgICAgICAgICB9CisgICAgICAgICAgfQorICAgICAgICBnY2NfdW5yZWFjaGFibGUgKCk7Cisg ICAgICB9CiAgICAgICBicmVhazsKICAgICBkZWZhdWx0OgogICAgICAgLyogQXMgdGhpcyBmdW5j dGlvbiBpcyBjYWxsZWQgYnkKLS0gCjIuNDMuMAoK --=-n4d+r6MXXAQaedHASNps--