From: Jeff Law <law@redhat.com>
To: Andrea Corallo <Andrea.Corallo@arm.com>, Martin Jambor <mjambor@suse.cz>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"jit@gcc.gnu.org" <jit@gcc.gnu.org>, nd <nd@arm.com>,
Jan Hubicka <hubicka@ucw.cz>, Jan Hubicka <jh@suse.cz>
Subject: Re: [PATCH] IPA-CP release transformation summary (PR jit/91928)
Date: Tue, 01 Jan 2019 00:00:00 -0000 [thread overview]
Message-ID: <29ab6082-a8d7-7471-ff99-3472a28eb84e@redhat.com> (raw)
In-Reply-To: <gkrr23wsrlm.fsf@arm.com>
On 10/1/19 4:11 AM, Andrea Corallo wrote:
> Martin Jambor writes:
>
>> Hi,
>>
>> On Mon, Sep 30 2019, Andrea Corallo wrote:
>>> Hi all,
>>> I'd like to submit this patch.
>>> It release the ipa cp transformation summary after functions being expanded.
>>> This is to fix the compiler when used with libgccjit on subsequent
>>> compilations (every new compilation should have a clean transformation
>>> summary).
>> if this is a general problem then I think we should instead add another
>> hook to class ipa_opt_pass_d to free transformation summary, call it for
>> all IPA passes at the appropriate time and implement it for IPA-CP. That
>> way it will work for all IPA passes which might have a transformation
>> summary.
>>
>> Martin
>>
>>
>>> Bootstrap on arm64 and X86-64.
>>>
>>> Bests
>>> Andrea
>>>
>>> gcc/ChangeLog
>>> 2019-??-?? Andrea Corallo <andrea.corallo@arm.com>
>>>
>>> * cgraphunit.c (expand_all_functions): Release ipcp_transformation_sum
>>> when finished.
>>> * ipa-prop.c (ipcp_free_transformation_sum): New function.
>>> * ipa-prop.h (ipcp_free_transformation_sum): Add declaration.
> Hi,
> actually looking around in order to implement the suggestions I realized
> that already some code was put in place in toplev::finalize calling
> then ipa_cp_c_finalize exactly for this purpose.
>
> I've updated the patch accordingly.
>
> Bootstraped on aarch64.
>
> Is it okay for trunk?
>
> Bests
> Andrea
>
> gcc/ChangeLog
> 2019-??-?? Andrea Corallo <andrea.corallo@arm.com>
>
> * ipa-cp.c (ipa_cp_c_finalize): Release ipcp_transformation_sum.
> * ipa-prop.c (ipcp_free_transformation_sum): New function.
> * ipa-prop.h (ipcp_free_transformation_sum): Add declaration.
OK for the trunk.
jeff
next prev parent reply other threads:[~2019-10-01 20:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-01 0:00 Andrea Corallo
2019-01-01 0:00 ` Martin Jambor
2019-01-01 0:00 ` Andrea Corallo
2019-01-01 0:00 ` Jeff Law [this message]
2019-01-01 0:00 ` Andrea Corallo
2019-01-01 0:00 ` Jeff Law
2019-01-01 0:00 ` Andrea Corallo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29ab6082-a8d7-7471-ff99-3472a28eb84e@redhat.com \
--to=law@redhat.com \
--cc=Andrea.Corallo@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=jh@suse.cz \
--cc=jit@gcc.gnu.org \
--cc=mjambor@suse.cz \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).