From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id AD3C73854160 for ; Wed, 29 Jun 2022 13:51:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AD3C73854160 Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-495-W-yGhRDAON27rqPOmfezew-1; Wed, 29 Jun 2022 09:51:55 -0400 X-MC-Unique: W-yGhRDAON27rqPOmfezew-1 Received: by mail-qk1-f198.google.com with SMTP id 186-20020a3708c3000000b006af306eb272so8450407qki.18 for ; Wed, 29 Jun 2022 06:51:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=5XSL8nuXhkPrynEkVOCzWXhKPDCdbgw1pp6WiUsUS5w=; b=VfD+F5u6PKdQOdW12ZEUmcMCmNyMNdqFelCCTE0ypXOJF87lwZkxdLEMVQFZEVLk5q 6jRos4jOxxz8ooo1Zsu1ZdcSxzHxP2co3UTP4wOo/XrtMt1iqQR2PUGRMKuH9CR+e7pz ztk9B2Vl+WG4lCqQQtC2wbe+KK82foHGAOIxJzF28niVZbI7Aq4QQGezQYLr6K6WcceQ t8faQZ302V7bgsgzi+GBvFvUk+yQvZg7goq7IlZVE5dvHt8aOdRjvU1mUHzOV+U1Hwnm ++lKgQ0hkp/XNep2/dcOXGX8FbUcHLs1kAEbljD1hsKWFXIZtJyyCUh3E68mirN22Rlh e5WQ== X-Gm-Message-State: AJIora8uYZbNnrPMUlik7XSNz50fSMr+Hku0Bku0dUgmX86sKN4eXe+U N3Ls0+L16CimcQhtuxLVVF8YXH3X4y+6zle0pI/np7ZDM4FXAZ2zGcNBpkaM0I+8uCNZ6Fqmi7X O8e3vIaQ= X-Received: by 2002:a05:620a:4111:b0:6a7:4b2c:a1c8 with SMTP id j17-20020a05620a411100b006a74b2ca1c8mr2075812qko.166.1656510714484; Wed, 29 Jun 2022 06:51:54 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uZDgbz5hvAH7htXIwipWYgSqxfmcs7txiz7Tr/n3iEV71zPrTkUOZCzBspDw9kXdvXBQyljw== X-Received: by 2002:a05:620a:4111:b0:6a7:4b2c:a1c8 with SMTP id j17-20020a05620a411100b006a74b2ca1c8mr2075789qko.166.1656510714158; Wed, 29 Jun 2022 06:51:54 -0700 (PDT) Received: from t14s.localdomain (c-73-69-212-193.hsd1.ma.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id bp32-20020a05620a45a000b006a67d257499sm9351550qkb.56.2022.06.29.06.51.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jun 2022 06:51:53 -0700 (PDT) Message-ID: <2ac9670e555197fcb82876738e44031290c5bc16.camel@redhat.com> Subject: Re: [PATCH] libgccjit: Fix bug where unary_op will return an integer type instead of the correct type From: David Malcolm To: Antoni Boucher , gcc-patches@gcc.gnu.org, jit@gcc.gnu.org Date: Wed, 29 Jun 2022 09:51:52 -0400 In-Reply-To: References: <7f2ff95927e7dc1b6e48aaf5b1753180eaecfa64.camel@redhat.com> User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: jit@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Jit mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jun 2022 13:51:58 -0000 On Wed, 2022-06-29 at 09:44 -0400, Antoni Boucher wrote: > It fails with the following error: > > gcc/gcc/testsuite/jit.dg/test-asm.cc: In function 'void > verify_code_2(gcc_jit_context*, gcc_jit_result*)': > gcc/gcc/testsuite/jit.dg/test-asm.cc:160:11: error: ISO C++ forbids > declaration of 'uint32_t' with no type [-fpermissive] > gcc/gcc/testsuite/jit.dg/test-asm.cc:160:11: error: typedef > 'uint32_t' > is initialized (use 'decltype' instead) Aha - I didn't notice the use of uint32_t there. > > Are you OK with me adding the stdint.h header? Yes, thanks. Dave > > On Tue, 2022-06-28 at 18:40 -0400, David Malcolm wrote: > > On Wed, 2022-06-01 at 22:45 -0400, Antoni Boucher via Gcc-patches > > wrote: > > > Also, the test gcc/testsuite/jit.dg/test-asm.cc fails and would > > > need > > > this line: > > > > > > #include > > > > I'm curious; how is it failing? > > > > > > > > Is this okay if I add it in this patch? > > > > > > On Wed, 2022-06-01 at 22:13 -0400, Antoni Boucher wrote: > > > > Hi. > > > > The attached patch fix bug 105812: > > > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105812 > > > > > > > > I'm having an issue where contrib/check_GNU_style.sh doesn't > > > > seem > > > > to > > > > work, i.e. it doesn't seem to do any checking. > > > > Is there a new way to do that or am I missing something? > > > > > > > > Thanks for the review. > > > > > > > >