From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-relay-2.sys.kth.se (smtp-relay-2.sys.kth.se [130.237.32.40]) by sourceware.org (Postfix) with ESMTPS id 081563858D39; Tue, 14 Dec 2021 00:30:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 081563858D39 Received: from exdb6.ug.kth.se (exdb6.ug.kth.se [192.168.32.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp-relay-2.sys.kth.se (Postfix) with ESMTPS id 4JCfR52PP0zPMdh; Tue, 14 Dec 2021 01:30:09 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp-relay-2.sys.kth.se 4JCfR52PP0zPMdh Received: from exdb6.ug.kth.se (192.168.32.61) by exdb6.ug.kth.se (192.168.32.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.14; Tue, 14 Dec 2021 01:30:09 +0100 Received: from exdb6.ug.kth.se ([192.168.32.61]) by exdb6.ug.kth.se ([192.168.32.61]) with mapi id 15.02.0986.014; Tue, 14 Dec 2021 01:30:08 +0100 From: Petter Tomner To: David Malcolm , Antoni Boucher , "gcc-patches@gcc.gnu.org" , "jit@gcc.gnu.org" Subject: SV: SV: [PATCH v2] jit: Add support for global rvalue initialization and ctors Thread-Topic: SV: [PATCH v2] jit: Add support for global rvalue initialization and ctors Thread-Index: AQHX6kRSdlggilZaSkOUVbKhDXhGHawqg7iAgALqaimAAjEaAIABKOUAgABS/e0= Date: Tue, 14 Dec 2021 00:30:08 +0000 Message-ID: <2ff48f6a7b00476ab0b4d461ea079636@kth.se> References: <47b54ae597a44706aba180a05f1e5fe7@kth.se> , <9e378de2a5b6e3dc7cc6268cb5a46121cae0516b.camel@zoho.com>, In-Reply-To: Accept-Language: sv-SE, en-US Content-Language: sv-SE X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [192.168.32.250] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: jit@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Jit mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Dec 2021 00:30:14 -0000 Hi! Thanks for the review. Having proper grammar in user facing text is importa= nt so=20 I in no way feel it is overzealous. I'll push the patch once I fixed the po= ints mentioned=20 in the review. Regards, Petter Fr=E5n: David Malcolm Skickat: den 13 december 2021 20:22 Till: Antoni Boucher; Petter Tomner; gcc-patches@gcc.gnu.org; jit@gcc.gnu.o= rg =C4mne: Re: SV: [PATCH v2] jit: Add support for global rvalue initializatio= n and ctors =A0 =20 On Sun, 2021-12-12 at 20:39 -0500, Antoni Boucher wrote: > Yes, this patch works for rustc_codegen_gcc perfectly. > It even fixes one issue that was in my patch, so that's nice! Excellent - thanks Antoni. >=20 > Le samedi 11 d=E9cembre 2021 =E0 15:35 +0000, Petter Tomner a =E9crit=A0: > > Hi! > >=20 > > > s/an union/a union/ > > > s/a rvalue/an rvalue/ > >=20 > > Heh no way ... and I though I knew English grammar :) I apologize for the non-regularity of English :)=A0 [and it's somewhat unfair for me to nit-pick, given that it's my first language - sorry; we may as well get this stuff correct] > >=20 > > Had to look that up to see what the deal was but it makes sense.=20 > >=20 > > yunion, arevalue. Exactly.=A0 English spelling is a mess. > >=20 > > > s/wrong-field-name/wrong-field-obj/ > > >=20 > > > to match the struct example (given that the issue being tested > > > for > > > is > > > that it's the wrong object, rather than the wrong name). > >=20 > > Initially, before submitting to the list, I made the code such that > > the field=20 > > objects did not have to be the ones that were used when creating > > the=20 > > struct or union, and forgot changing the test names.=20 > >=20 > > I figured it required too much string compares for the field names > > and=20 > > pointer compares for the field object were more appropriate. To > > create > > dummy field objects were also kinda heavy. > >=20 > > I'll address the points. Petter, you can go ahead and commit this, once you address the various points from my earlier review, and from Antoni's observation that "flags" should be "m_flags" when it's a member.=A0 Antoni has committed at least one ABI version bump since you posted this, so you'll need to rebase your work on top of his and adjust accordingly.=A0 Please re-test the patch before pushing it. Thanks for all your great work on this. Dave =