From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id D05B6385C65E for ; Tue, 13 Dec 2022 21:45:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D05B6385C65E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670967928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cLjxqp08Y2f5R/xaLZzf2KE+6TfWdRa+8ptfOHd2PtM=; b=M+JvV9A8CISFPD7gF53bfBF8cwIs16lBF1n5vXx/bNzF2XlKa/fz+ETaQNlSRyjffNrGoa mX0t5qVBaHq4oSq7y2JOu7RsDc3ROhMzWXykzmIvwj3PX1kJ9MGZ0xKztcYYLQ4XipicpO aBK4JYOOmYaYdf2Mw1wMFxo5bpWzvPw= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-498-maA3bsUBP2CsFghcTP-pyQ-1; Tue, 13 Dec 2022 16:45:27 -0500 X-MC-Unique: maA3bsUBP2CsFghcTP-pyQ-1 Received: by mail-qt1-f197.google.com with SMTP id z2-20020ac86b82000000b003a804255e47so893355qts.7 for ; Tue, 13 Dec 2022 13:45:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=cLjxqp08Y2f5R/xaLZzf2KE+6TfWdRa+8ptfOHd2PtM=; b=MPmKXI1KLnqueBXvSIVOOwrmL8YUcT2OAU3sKMRfW1Wf0o9OIMqcReKhfqjydnCrCc UyFfO1t7ES5VuX57N9J1V3W4wAl07fk1CUxxL4mtF2NrvNrDMaaqgef4aE8AyJjtC37B xA5808ENP+Bx/ApVAWNPhDZbztIMr10wW99VIbFYVFcpZV6CVyNHYNxTeqbZgE1k9QdQ FVy1a0TPmlBfQ+5FuhmG2kX50wsblPvgDDK90ev2jlHdYaPtUeBujBs0OK148TX0PMVr 47Kr0q2NnvmcSIb615G0pPf144hz1VjNiMeUC/5PD2dW0Ccj9szRloP9xW2Q60pwkTvs Ll7w== X-Gm-Message-State: ANoB5pkxljXyNaHP86yUfPuMA5xJGMZqI0yDXj15TX2K+Awq29Cg+AFo 94IPqnKy8/Jw7rmqM3NykE9O1buuTdsII/8fhXZVmJNyxwiwZln+Y269fUvDNovjmdbLyO6heYa tb2GF9Vs= X-Received: by 2002:ac8:74d9:0:b0:3a7:eb36:5cb1 with SMTP id j25-20020ac874d9000000b003a7eb365cb1mr29396190qtr.36.1670967926733; Tue, 13 Dec 2022 13:45:26 -0800 (PST) X-Google-Smtp-Source: AA0mqf6OTWL/AM5mAmqvx830ybbCr4HCMXAOlhU5kb698bZjRW4ggjRHbXPHq7mk03WDvlfBpSyAHw== X-Received: by 2002:ac8:74d9:0:b0:3a7:eb36:5cb1 with SMTP id j25-20020ac874d9000000b003a7eb365cb1mr29396166qtr.36.1670967926448; Tue, 13 Dec 2022 13:45:26 -0800 (PST) Received: from t14s.localdomain (c-73-69-212-193.hsd1.nh.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id x10-20020a05620a258a00b006fefa5f7fc9sm8612848qko.134.2022.12.13.13.45.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Dec 2022 13:45:26 -0800 (PST) Message-ID: <3011e8cc8076a3ce6ccf03222970ce8dc5cdf85f.camel@redhat.com> Subject: Re: [PATCH] libgccjit: Allow comparing vector types From: David Malcolm To: Antoni Boucher , gcc-patches@gcc.gnu.org, jit@gcc.gnu.org Cc: Guillaume Gomez Date: Tue, 13 Dec 2022 16:45:25 -0500 In-Reply-To: <641a5a1ab74c5f92962035d32acb64828b17d1cc.camel@zoho.com> References: <1aec893b44d81c5558db3c3b2ac8b63e8c456469.camel@zoho.com> <03070a2e198b1e4a9f85c99bf52ecea567796b32.camel@redhat.com> <641a5a1ab74c5f92962035d32acb64828b17d1cc.camel@zoho.com> User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,BODY_8BITS,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 2022-12-13 at 16:27 -0500, Antoni Boucher wrote: > Thanks! >=20 > David: you mentioned gcc 10. For now, I only intend to make changes > to > the next release (13). Is this OK or should I backport all my fixes > to > all active releases? (I'm not sure what are GCC policies here.) I think it varies by subproject within GCC. Given that this could arguably be an RFE rather than a bugfix, and that rustc_codegen_gcc is likely the primary user of this stuff, I leave the decision of which branches to you. If you only want it in trunk for gcc 13 onwards, then that's fine by me. Thanks again for the patch Dave=20 >=20 > On Tue, 2022-12-13 at 16:24 -0500, David Malcolm wrote: > > On Mon, 2022-12-12 at 21:31 -0500, Antoni Boucher via Jit wrote: > > > Hi. > > > This fixes bug 108078. > > > Thanks for the review. > >=20 > > [...snip...] > >=20 > > > diff --git a/gcc/jit/jit-recording.h b/gcc/jit/jit-recording.h > > > index 5d7c7177cc3..4ec0fff4843 100644 > > > --- a/gcc/jit/jit-recording.h > > > +++ b/gcc/jit/jit-recording.h > > > @@ -806,6 +806,15 @@ public: > > > =C2=A0 > > > =C2=A0=C2=A0 void replay_into (replayer *) final override; > > > =C2=A0 > > > +=C2=A0 virtual bool is_same_type_as (type *other) > >=20 > > This would be better with a "final override" (and without the > > "virtual"). > >=20 > > > +=C2=A0 { > > > +=C2=A0=C2=A0=C2=A0 vector_type *other_vec_type =3D other->dyn_cast_v= ector_type > > > (); > > > +=C2=A0=C2=A0=C2=A0 if (other_vec_type =3D=3D NULL) > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return false; > > > +=C2=A0=C2=A0=C2=A0 return get_num_units () =3D=3D other_vec_type->ge= t_num_units () > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 && get_element_type () =3D=3D other_v= ec_type->get_element_type > > > (); > > > +=C2=A0 } > > > + > >=20 > > OK for active branches with that nit fixed (though for gcc 10 you'd > > have to spell final and override as "FINAL" and "OVERRIDE" due to > > needing to be buildable with a C++98 compiler; not sure if gcc 10's > > libgccjit even has vector types though). > >=20 > > [...snip...] > >=20 > > Thanks for the patch > >=20 > > Dave > >=20 >=20