From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sender4-pp-o91.zoho.com (sender4-pp-o91.zoho.com [136.143.188.91]) by sourceware.org (Postfix) with ESMTPS id C0D5F3846077; Fri, 19 Apr 2024 12:35:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C0D5F3846077 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=zoho.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=zoho.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C0D5F3846077 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=136.143.188.91 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713530124; cv=pass; b=YmNwDNXR+c/kcr+ZTzamzKpQZr4TSd+AM2Zxrf38092Pn38/LI/sac21kp3fhg6NewN8s3II/FXFhQd+Z2cv1xJIiizIiKF4scrLYvNWWnTyyvz9ChqwLKyJ1EfYjOHdlKq3V5hjVZLL2i/dHBPtyNU81YK1Ih6bR6ougRbPcXM= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713530124; c=relaxed/simple; bh=3b4y7P7aTHu3qRwvzsiMxuETA78AZ+MiSS7HfvWs9LI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=bbURV9hbV5YFX3S0Y1fCGp/4wn24LCCtiQZ04I672sPqqSpSu6iGRybJ8tuxBmuhtfyLd2O4QF7zLEw7Zrk74TRWPYv2zjp6X3xDd2N7Tk4xuJ9aPKX77/u85NuG0909Gtvdto+Y1VRw/JsQoorBf8UbtLh6pCx5UKluqnmF0Oc= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; t=1713530109; cv=none; d=zohomail.com; s=zohoarc; b=Q+GG/KXQFSNlz9FpOKb+4XlOajTlpMgxfKStgiRPa1ZFf2D8+gNyt/V7J58e0IYhuOdD2GaYjuiGM3yuKKkJ9uzGEq5R/xBhOt8xLdLenZT0xs8ox6SEfewri3HvTfe3b0abi3Q4PvJABoqCI+nP+dmRVmpKh16UeDJH2X4M5xY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1713530109; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=dmFyF02cMYt/uDHxCyKkxYRLZmK6B56fbFGmgpFndyU=; b=QuNlWtQWCngq7p9SqkMNj2igM64V5W8B2Qdm0sCJXJJUWy6Cc6qffc5m0btZVWD9675Lgb1hhRWwHI5xMl2MZSzws6EE3pJ4GcER5x1q8f57aG9yUkKEsebfCDlodawJMatDHhlpf4zASHC41L9nwsEOav3L8jCedqP/n7VccH0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=zoho.com; spf=pass smtp.mailfrom=bouanto@zoho.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1713530109; s=zm2022; d=zoho.com; i=bouanto@zoho.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:From:From:To:To:Cc:Cc:References:In-Reply-To:Content-Type:Content-Transfer-Encoding:Feedback-ID:Message-Id:Reply-To; bh=dmFyF02cMYt/uDHxCyKkxYRLZmK6B56fbFGmgpFndyU=; b=RU3pqk3Cz1+Dj/912auCvSsSDT/jqjrGgS51lH9KTkrek2iB4nDwClpgQWAtHPjU aC626d5aGAG0qQHsS8Nzr7lRUVHjB4vF5c058Ho9uPY0e7WAMsOpfDG9XrJyIxPlgSf vpBr6UqN2+8aLAnf9jXYIDMj6IVSixjB/IBJ2rBk= Received: by mx.zohomail.com with SMTPS id 171353010800315.797382298084244; Fri, 19 Apr 2024 05:35:08 -0700 (PDT) Message-ID: <34140584-d7f3-4b80-aa73-817427df955c@zoho.com> Date: Fri, 19 Apr 2024 08:35:06 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] libgccjit: Add support for machine-dependent builtins From: Antoni Boucher To: David Malcolm , Andrew Pinski Cc: jit@gcc.gnu.org, gcc-patches@gcc.gnu.org References: <184790403bd8227db4054b9e672afbfdf879dc0c.camel@zoho.com> <68c5b0693c8f7a6c6ce59259fdf088106861e4e4.camel@zoho.com> <0f44d7bb2d4baa961112e164cefa1bd0a8ec0b1c.camel@zoho.com> <1528e00046d70c6804736192cd0733c4e90908cf.camel@zoho.com> Content-Language: en-US, fr In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Feedback-ID: rr08011228344f0262e1aebf485c0f5ae30000d9a9e313ed02fcfcd139b1accb05ef3f6d0247ea599a04aaa41d:zu0801122691d89a8e47b5e35790ee1a7300001ddb91fda911dea70cb2347e0505282416f2f5683396c5b5:rf080112266247700833cb072e2492d56d0000ec8c271ecba0ce19ae1c8a643e6a713aac5dd70878fbfb11:ZohoMail X-ZohoMailClient: External X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: David: Ping. Le 2024-02-29 à 10 h 34, Antoni Boucher a écrit : > David: Ping. > > On Thu, 2024-02-15 at 09:32 -0500, Antoni Boucher wrote: >> David: Ping >> >> On Thu, 2024-02-08 at 08:59 -0500, Antoni Boucher wrote: >>> David: Ping. >>> >>> On Wed, 2024-01-10 at 18:58 -0500, Antoni Boucher wrote: >>>> Here it is: https://gcc.gnu.org/pipermail/jit/2023q4/001725.html >>>> >>>> On Wed, 2024-01-10 at 18:44 -0500, David Malcolm wrote: >>>>> On Wed, 2024-01-10 at 18:29 -0500, Antoni Boucher wrote: >>>>>> David: Ping in case you missed this patch. >>>>> >>>>> For some reason it's not showing up in patchwork (or, at least, >>>>> I >>>>> can't >>>>> find it there).  Do you have a URL for it there? >>>>> >>>>> Sorry about this >>>>> Dave >>>>> >>>>>> >>>>>> On Sat, 2023-02-11 at 17:37 -0800, Andrew Pinski wrote: >>>>>>> On Sat, Feb 11, 2023 at 4:31 PM Antoni Boucher via Gcc- >>>>>>> patches >>>>>>> wrote: >>>>>>>> >>>>>>>> Hi. >>>>>>>> This patch adds support for machine-dependent builtins in >>>>>>>> libgccjit >>>>>>>> (bug 108762). >>>>>>>> >>>>>>>> There are two things I don't like in this patch: >>>>>>>> >>>>>>>>  1. There are a few functions copied from the C frontend >>>>>>>> (common_mark_addressable_vec and a few others). >>>>>>>> >>>>>>>>  2. Getting a target builtin only works from the second >>>>>>>> compilation >>>>>>>> since the type information is recorded at the first >>>>>>>> compilation. >>>>>>>> I >>>>>>>> couldn't find a way to get the builtin data without using >>>>>>>> the >>>>>>>> langhook. >>>>>>>> It is necessary to get the type information for type >>>>>>>> checking >>>>>>>> and >>>>>>>> instrospection. >>>>>>>> >>>>>>>> Any idea how to fix these issues? >>>>>>> >>>>>>> Seems like you should do this patch in a few steps; that is >>>>>>> split >>>>>>> it >>>>>>> up. >>>>>>> Definitely split out GCC_JIT_TYPE_BFLOAT16 support. >>>>>>> I also think the vector support should be in a different >>>>>>> patch >>>>>>> too. >>>>>>> >>>>>>> Splitting out these parts would definitely make it easier >>>>>>> for >>>>>>> review >>>>>>> and make incremental improvements. >>>>>>> >>>>>>> Thanks, >>>>>>> Andrew Pinski >>>>>>> >>>>>>> >>>>>>> >>>>>>>> >>>>>>>> Thanks for the review. >>>>>> >>>>> >>>> >>> >> >