From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sender4-pp-o90.zoho.com (sender4-pp-o90.zoho.com [136.143.188.90]) by sourceware.org (Postfix) with ESMTPS id C6FAD3858D38; Wed, 10 Jan 2024 23:18:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C6FAD3858D38 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=zoho.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=zoho.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C6FAD3858D38 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=136.143.188.90 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1704928741; cv=pass; b=TaEBLs56rWO5Yl7Vw5sDiMPFW8SCVc0lL9+dsRi9KViUYqQDGtYTyPNEN4yrtqvWcyN9G3cFXow3GsmFpuvdyvji6i0jCwyshnfPmeJFZzzg12C9wwZ3CdyB2osJO8VcwTzesKF2FAAR6LM8K6JObvulrgwgwf5MLp9hTiivXfc= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1704928741; c=relaxed/simple; bh=trRPxXQFfJiSJv1JN3oXAXRZeZY3lbe3IP1ZxfNwv+8=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=IiF3z3392v8yx7d0z1GRZ7Q82rmMrZtBIjf+ssJZWG/9iTVqliP2HiFbBcC5FoQs8DLlKAZAfpfd9X3G+z+aCLxg+aU1xIHIvUO1XyZhBL/LIGYkHTABMXp8Ds9l4yMsIA4+0xM44DyTtALLCTXfUBvZNUoauFKiMpAxRJDvXcY= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; t=1704928735; cv=none; d=zohomail.com; s=zohoarc; b=XPyKs7nv0DeX14UWRdfTAXZxP7+LUIr8t73K0txABMTFVZt5QrpqLsdg4SbHFFhqYYX7Mf6kxaFsxWmuQi/x6R2XTBEAldWN1K+qAMvMWp/ZFEGObSxvkn6+RaQ4GFQNkdMBVpesH2xHrTWM66ey3su+hF87UKjHAArT4JnSiv0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1704928735; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=y5j4FqtKN3VVrvQ4rrzlHlNAQBY7qCo9oVT/YxuDf7g=; b=XGcy6TiC7dHVIyxqagDYH1ODj3bOHnjMJs3HJhFR7zE7b0gk6jI7Rxv7pmA7exF499TadiknJ/5lR7srDTdIbVMWG1UqBhuhI3K39/xl/D3PimF1xSER5QBbbAMBMxx6oWT1YR6UE6JoFCE7DvRV0s9wTzaCefVkucRlIiBpiNU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=zoho.com; spf=pass smtp.mailfrom=bouanto@zoho.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1704928735; s=zm2022; d=zoho.com; i=bouanto@zoho.com; h=Message-ID:Subject:Subject:From:From:To:To:Date:Date:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:MIME-Version:Feedback-ID:Message-Id:Reply-To:Cc; bh=y5j4FqtKN3VVrvQ4rrzlHlNAQBY7qCo9oVT/YxuDf7g=; b=I8plz0kfv1obeYWuZoUJNkFxcdT5wEVbdqQE5eyB+Had6rYJN1PRYlxFpQnlU+9c 6q0sbQ59JYUbGTRlU8ev96kjFMkNvGRBCZ1UQ8HZCSt+s7fAcmdYE/E463IrbesZqsD Ql/BGyVjiSKTfrWlAYi11VJ/p6r88V0wLpW1eeTI= Received: from [192.168.1.172] (38.87.11.6 [38.87.11.6]) by mx.zohomail.com with SMTPS id 1704928733524380.02202084741396; Wed, 10 Jan 2024 15:18:53 -0800 (PST) Message-ID: <3bc4a8ead5cbc459e9e0cbb7fc30b264c0088788.camel@zoho.com> Subject: Re: [PATCH] libgccjit: Add ability to get CPU features From: Antoni Boucher To: David Malcolm , jit@gcc.gnu.org, gcc-patches@gcc.gnu.org Date: Wed, 10 Jan 2024 18:18:51 -0500 In-Reply-To: <2b7e3baa288273725432f1bb5d8b894e83ec8b25.camel@zoho.com> References: <8b0199d9835f568b7bcde41bf9432c21f604e489.camel@zoho.com> <755705e37731c4fbc3ab7eb1a96d8df0147bb002.camel@redhat.com> <2b7e3baa288273725432f1bb5d8b894e83ec8b25.camel@zoho.com> Autocrypt: addr=bouanto@zoho.com; prefer-encrypt=mutual; keydata=mQENBFOSMLQBCADO5aw6Ys8thMQUNzrwAnfJX2wbgWiz0pQ01DjYj22eeIpChkoZn6LWdt4dieq30u2rFi/yQzJ02foHwI2+aL9rU6xz/x4TwqyRJQGMOqklNc3R+pdXmH4WDQkQDWmLxvc07vu+zb8Tx5A6pMDh4J2ncCEhLEUcH39Yq/yg4eBnFwUX6N7kakvHrnScGNqhnSFCacoJeMJUAR+1G7VBSBd++jmnHLnx3mj7QkRZVECJUw2zqiv1yReCC6GU4SvqLjdqm5ZGeoWOqD/NHjBRoEeOVjzp6M/qOjjWRbkJVqmvgfcD8UytSSqqboR35YFT4L+rZt2ri3T12MJb3i5syCAXABEBAAG0IUFudG9uaSBCb3VjaGVyIDxib3VhbnRvQHpvaG8uY29tPokBVgQTAQgAQAIbIwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAFiEEOELC4Uw1Jeb66YE6RVeGAwR4zcEFAlz4QM4FCRLMEZoACgkQRVeGAwR4zcFBQQf/afttJrA/puADQZhrDfkgr0MFvq6iB+GCy1b8BkXimk1TOXTPt87YLehSeijNu3JkYhl5eRc87BNfU9J87KfI/KIy6hZxqlDXk16FhW9bw/7wYEA0hpb3MUn7xLElXDT0ZHaD+KTe8Oun7qfzgx5RlL6r/WODf3CkSpO085R/rfeBqDEx9mVlhDWgq6Az3CZoD+3CqiCKVqmDuHTWz4kwrd9AM5eVcLvvLKnZIdoIp+G5Ao6BvaGlZyfenN1iOSjLy2NXNt4MnUt0lUYEP5KSIIRhHQ8xkUbj7eWUmaahkxhNb3fH3sAPwGnRZrPpb4rgYzNmSk63wWMh9M2xk+rLb7kBDQRTkjC0AQgAumZzsAV/UFWI+dpzebQfma36kKYZZFuseant5sq/HWP553XQ/U6ttJiKyN5MpCqtxvCAoRplf42YhlHuFqgf73WJxoJ6Y+sdyqoBSwlR+ gzAneAmsa8gmmY0wawH0Z2leazjKuS7mJjVEQZg0ZGsiCVRGeRnDqFGzDEzDc9ngWKSoTq0fKzlGy1X85OrtmUrvEbhSo6HP+FoeunHkIqrxu3w3vDoFEXxVQlKI6V3I4nCz5n6DB8WR3L7nsiiTnOiGirPw1ngvWFLW86kkA4FJpayc8Xl3va3SLY+2y4yuROboX2DVI4AC/Qeug/mDiBicPxkP6YfUartQRMe6obkEQARAQABiQE8BBgBCAAmAhsMFiEEOELC4Uw1Jeb66YE6RVeGAwR4zcEFAlz4QRsFCRLMEecACgkQRVeGAwR4zcE56ggAgTgrJInBKC+7552Dpccuo6Clh3wZfjlNLv9/6r5lKEbaNzaTrfhPiAP4WgnluIUmj8amOFLFJpj+BAVNOXpZ4D2R3o9ch8z7fot+fW4Yw+PKIxH4I2xEys8ndoEB3aiQwHjKcGIhkIU7uyMJFQr2aWjdTY0gmXw0YZueHOSLgo7uX4XKxB8fEO/yto/Tff2YBAAq+AtNwt+Gh5YS9rZw7rwUTWMi84yVOlc+zRE79E9NJkvdTwX7IJYo64VzIRNfgHsn7QNdVzuM1XIFHl+Glk6cIlI8s6BO7nEoCn3hTF104fQTAO3fEs+XXZOKXo2lk8faowEoPq5r58StrV0nyg== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.2 MIME-Version: 1.0 Feedback-ID: rr0801122897e37d11e31dd3636327493c0000ee244cf27e6fee53e8995eeb7d8e1fde3f4826b93043cf0313f7:zu0801122693b848c490b61b1396b9bf3900007b5f8f860522cfe73c8fa0ef32ab247951e58c86c2879a11:rf0801123223bd86b03acc2b339a6a035000005a0af256dd33ebd9007b53547ea520d8070e18e72cefb4264ff9b885d6fd6c5361028332:ZohoMail X-ZohoMailClient: External X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: David: Ping in case you missed it. On Wed, 2023-12-13 at 14:56 -0500, Antoni Boucher wrote: > David: Ping. > I guess if we want to have this merged for this release, it should be > sooner rather than later (if it's still an option). >=20 > On Thu, 2023-11-09 at 18:04 -0500, David Malcolm wrote: > > On Thu, 2023-11-09 at 17:27 -0500, Antoni Boucher wrote: > > > Hi. > > > This patch adds support for getting the CPU features in libgccjit > > > (bug > > > 112466) > > >=20 > > > There's a TODO in the test: > > > I'm not sure how to test that gcc_jit_target_info_arch returns > > > the > > > correct value since it is dependant on the CPU. > > > Any idea on how to improve this? > > >=20 > > > Also, I created a CStringHash to be able to have a > > > std::unordered_set. Is there any built-in way of > > > doing > > > this? > >=20 > > Thanks for the patch. > >=20 > > Some high-level questions: > >=20 > > Is this specifically about detecting capabilities of the host that > > libgccjit is currently running on? or how the target was configured > > when libgccjit was built? > >=20 > > One of the benefits of libgccjit is that, in theory, we support all > > of > > the targets that GCC already supports.=C2=A0 Does this patch change > > that, > > or > > is this more about giving client code the ability to determine > > capabilities of the specific host being compiled for? > >=20 > > I'm nervous about having per-target jit code.=C2=A0 Presumably there's = a > > reason that we can't reuse existing target logic here - can you > > please > > describe what the problem is.=C2=A0 I see that the ChangeLog has: > >=20 > > > * config/i386/i386-jit.cc: New file. > >=20 > > where i386-jit.cc has almost 200 lines of nontrivial code.=C2=A0 Where > > did > > this come from?=C2=A0 Did you base it on existing code in our source > > tree, > > making modifications to fit the new internal API, or did you write > > it > > from scratch?=C2=A0 In either case, how onerous would this be for other > > targets? > >=20 > > I'm not at expert at target hooks (or at the i386 backend), so if > > we > > do > > go with this approach I'd want someone else to review those parts > > of > > the patch. > >=20 > > Have you verified that GCC builds with this patch with jit *not* > > enabled in the enabled languages? > >=20 > > [...snip...] > >=20 > > A nitpick: > >=20 > > > +.. function:: const char * \ > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 gcc_jit_target_info_arch (gcc_jit_target_info > > > *info) > > > + > > > +=C2=A0=C2=A0 Get the architecture of the currently running CPU. > >=20 > > What does this string look like? > > How long does the pointer remain valid? > >=20 > > Thanks again; hope the above makes sense > > Dave > >=20 >=20