From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sender4-pp-o91.zoho.com (sender4-pp-o91.zoho.com [136.143.188.91]) by sourceware.org (Postfix) with ESMTPS id 511893AAA0FF; Fri, 18 Jun 2021 15:55:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 511893AAA0FF ARC-Seal: i=1; a=rsa-sha256; t=1624031716; cv=none; d=zohomail.com; s=zohoarc; b=Fe6m7aAa4umVNCvdxk8bouX4+nP1Qlg7T+b+GL/AvST/BTcEctcmCO+QRQ9OCHWxeAAquPiUKjCPfGKpLhNRu45CL9/HU4/4yJcBNhzGceoPkHZOh3dBVAB4fcvnd/kF1biEaIZExeWRoBGzw+MqxGn6BuHYgrneyJlMZJZl/2Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1624031716; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=CyBDgqcCPEV3AjytRnxiKq73MjpWRTXNd484egVAKww=; b=F6HF8ZEfAC+ROSctkfsBgFateLfvQQ4fKf0Yr/O/knDQqIbvRT2mk88mKL5isG2YrIzVGro8sFmO4WJmS8uYP3JqpcPNmYc5nxZ+5X0nrrkkGSaJRpQ6nYjDJ3dOjDt3O6IjhwqB2vNTT1DCnY1pkODAef5DK0TrYi1nHhM5PmU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=zoho.com; spf=pass smtp.mailfrom=bouanto@zoho.com; dmarc=pass header.from= Received: from [192.168.1.174] (38.87.11.6 [38.87.11.6]) by mx.zohomail.com with SMTPS id 1624031712612159.16666807856643; Fri, 18 Jun 2021 08:55:12 -0700 (PDT) Message-ID: <3c328b40570b10b22a8925fd64b2781dc9264358.camel@zoho.com> Subject: Re: [PATCH] libgccjit: add some reflection functions in the jit C api From: Antoni Boucher To: David Malcolm Cc: Antoni Boucher via Jit , gcc-patches@gcc.gnu.org Date: Fri, 18 Jun 2021 11:55:10 -0400 In-Reply-To: References: <20200902010120.crnx55ev635ceiey@bouanto-desktop.localdomain> <6fe2ea355403eb177c9632e076c11c792f23c791.camel@redhat.com> <9cd00fe5cb5c03184e3a5bd939447b30450a8ca7.camel@redhat.com> <20201015160226.cka4iq3w22jztopm@bouanto-desktop.localdomain> <20201015173952.ft7mu5ajbaxb3gke@bouanto-desktop.localdomain> <54ba5c58dbd2b8c7b1f3276c2b87cddf55e258bd.camel@redhat.com> <20201103221324.xw3jbvrw2uwdc4rz@bouanto-desktop.localdomain> <3388bb8c84e68cd7b0698dc154e7a5666c0d2cde.camel@redhat.com> <0e8b6450bcb23182b85342d8010c3bea0c297ba2.camel@zoho.com> <534254132a841b75d555a52ce952f84418f168c2.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: jit@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Jit mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jun 2021 15:55:23 -0000 Le vendredi 11 juin 2021 =C3=A0 14:00 -0400, David Malcolm a =C3=A9crit=C2= =A0: > On Fri, 2021-06-11 at 08:15 -0400, Antoni Boucher wrote: > > Thank you for your answer. > > I attached the updated patch. >=20 > BTW you (or possibly me) dropped the mailing lists; was that > deliberate? Oh, my bad. > >=20 > > See my answers below. > >=20 > > Le jeudi 10 juin 2021 =C3=A0 18:41 -0400, David Malcolm a =C3=A9crit=C2= =A0: > > > On Thu, 2021-05-27 at 21:51 -0400, Antoni Boucher wrote: > > > > I chose option A, so everything is a size_t, now. > > > > I also renamed the dyncast functions. > > > > Here's the new patch. > > >=20 > > > Thanks, sorry again about the delays in reviewing your work. > > >=20 > > > You didn't specify how you tested the patch; are you running the > > > full > > > jit regression test suite? > >=20 > > Yes, I run the full jit test suite. >=20 > Great. >=20 > [...snip...] >=20 > > >=20 > > > I can't remember, sorry, do you have push rights to the gcc git > > > repository? > >=20 > > I don't have push rights; it's actually my first contribution to > > gcc. >=20 > Congratulations!=C2=A0 I'm excited about having Rust support for GCC (two > different ways, in fact!) Yup. Exciting times! >=20 > > I have signed the FSF copyright attribution. >=20 > I can push changes on your behalf, but I'd prefer it if you did it, > especially given that you have various other patches you want to get > in. >=20 > Instructions on how to get push rights to the git repo are here: > =C2=A0 https://gcc.gnu.org/gitwrite.html >=20 > I can sponsor you. Thanks. I did sign up to get push rights. Have you accepted my request to get those? >=20 > Note that your patches would still need review/approval ("Write After > Approval"). >=20 > > > Do you have a preference as to which patch you want me to look at > > > next? > > > Otherwise I'll go through them in the order in > > > https://github.com/antoyo/rustc_codegen_gcc/tree/master/gcc-patches > >=20 > > You can indeed look in this directory in the order they were added. > > There was one patch before the reflection one (0001-This-patch- > > handles- > > truncation-and-extension-for-cast.patch), but since it's only a > > bugfix, > > it doesn't matter if it's merged after. >=20 > That one looks good to me now too (I've replied on that patch). >=20 > >=20 > > This one is ready for review, but I believe the other one needs > > correction on my end since the last review you made. I'll make sure > > to > > fix them soon. >=20 > Now I'm confused as to which patches you're referring to, sorry.=C2=A0 > I'll > hold off for now on further reviews; let me know when you want me to > look at them, and which ones. >=20 > Thanks > Dave >=20