From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 93F4A3858D37 for ; Fri, 10 Nov 2023 23:14:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 93F4A3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 93F4A3858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699658062; cv=none; b=EWjLfuTdS0z0W8tKKwVBefCFE3B0cETlRhjWY6kISIqt/Wx7HEax46+BftPXPbSL01fXeo5H+t45GEkrT/9l35GGMt3Kwo5HDpRnZoUMN3Ylj7TfnRQhRDY+oqZrC+LHvHitm9k9ObotEh9iUdCv0jPICgjJqpc1emqKSuuzgIo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699658062; c=relaxed/simple; bh=EwxQX8Qi5HSgCav+fCpM6G6rnksmGMcANvehQymeXgc=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=wcUbHM8QBKPGg7lmwcGloKEzbtIKZchKSxbIWJMx0s27Wb4XtobRPBlGq9gDkuWizUL35eXq74kC8xwwa0ZqJx6cpvXCtzrz/gbpvzngp7QYRENBNsm8HO0pTDlyQeRKzxzF0wCRe/1jNV5az9vm8JjNeNvE0rFS7175z/+c/Mw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699658061; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EwxQX8Qi5HSgCav+fCpM6G6rnksmGMcANvehQymeXgc=; b=b07Y1RLQi1diqD7mKUEeHrWW8qFSAV5hVifa0kRnQfWJm0nx5hf5Ak4presed3qwQxFHZB t0rTY3dbNGFR695JA7CXpyt2jIXP41jQOtXOytLE1Ma3nWAdMPVW5Bwa3+Q2qeIFAG+YXs Q5LVuPF+V0mP+D4PcUPTOcGE5daMmRM= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-657-cXjixF4nNgemCz9tOkCmPg-1; Fri, 10 Nov 2023 18:14:20 -0500 X-MC-Unique: cXjixF4nNgemCz9tOkCmPg-1 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-779e001ffa5so274166385a.3 for ; Fri, 10 Nov 2023 15:14:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699658059; x=1700262859; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=EwxQX8Qi5HSgCav+fCpM6G6rnksmGMcANvehQymeXgc=; b=aTOkFaUp2fauhh01/rQH6YqxKb/zj8YN8JoAI9qa60GcYsFDdTRrjW6J68b9CV95TR wWBLIMtL+V3fG5JsCatpXl+blv4Dw0N3mpTg/jEjjVavmTmsudpttYo+QVSBJwg7Tugk sBcreB33L7+XUDADVL1uApTBZoZ0yg18HGVFbHS0yPb+tYzmJIokjgiDABvUQjpWZtor OIRtdIbDPWEcP8qCVV9spuTBRI8m5OvRo5BBITwRpMqwvhs27aOkmMyBdHaiSX2QrdpD 5Sq+r0AOaij26ZbDG6zkoFVofljSvo52bEdkmTjCM0hl5JP/psOyzmDBKPA0axVjSjBJ kwEw== X-Gm-Message-State: AOJu0YzT10hYBTo+9BuzaRANFVPNQBx07szz/X1+dqNoXpUAUZUNUGda ayc7+svJTria+0CUk9nQOQc6rTCnnA8hZhKeLFar6hF9IN8CTRdQni2UaPo8A/B4tWeXm6OaL1Q scy3pyNY= X-Received: by 2002:a05:620a:8016:b0:774:3497:a7a3 with SMTP id ee22-20020a05620a801600b007743497a7a3mr670050qkb.17.1699658059612; Fri, 10 Nov 2023 15:14:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IFdpvq9ghZNrG61ISsPHDttcxszDVqT+81zv8dej/l2m24Q7oF2sAa59UwRGu6O0ih4O1SUmA== X-Received: by 2002:a05:620a:8016:b0:774:3497:a7a3 with SMTP id ee22-20020a05620a801600b007743497a7a3mr670039qkb.17.1699658059344; Fri, 10 Nov 2023 15:14:19 -0800 (PST) Received: from t14s.localdomain (c-76-28-97-5.hsd1.ma.comcast.net. [76.28.97.5]) by smtp.gmail.com with ESMTPSA id w2-20020a05620a0e8200b0077412ca0ae1sm146798qkm.65.2023.11.10.15.14.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Nov 2023 15:14:18 -0800 (PST) Message-ID: <459954b377768b7a0d79dd9d99328b45c66e4fa0.camel@redhat.com> Subject: Re: [PATCH] libgccjit: Fix GGC segfault when using -flto From: David Malcolm To: Antoni Boucher , jit@gcc.gnu.org, gcc-patches@gcc.gnu.org Date: Fri, 10 Nov 2023 18:14:17 -0500 In-Reply-To: References: User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 2023-11-10 at 11:02 -0500, Antoni Boucher wrote: > Hi. > This patch fixes the segfault when using -flto with libgccjit (bug > 111396). >=20 > You mentioned in bugzilla that this didn't fix the reproducer for > you, Rereading https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D111396 it looks like all I tested back in August was your reproducer; I didn't yet test your patch. > but it does for me. > At first, the test case would not pass, but running "make install" > made > it pass. > Not sure if this is normal. >=20 > Could you please check if this fixes the issue on your side as well? > Since this patch changes files outside of gcc/jit, what tests should > I > run to make sure it didn't break anything? I'm trying your patch in my tester now. BTW, we shouldn't add test-ggc-bugfix to since it adds options to the context: this would affect all the other tests. Dave