From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id DFBF83858414 for ; Wed, 8 Sep 2021 12:48:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DFBF83858414 Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-263-LEviR0hWNzuoXNH4uhlj5w-1; Wed, 08 Sep 2021 08:48:41 -0400 X-MC-Unique: LEviR0hWNzuoXNH4uhlj5w-1 Received: by mail-qt1-f198.google.com with SMTP id o22-20020ac872d60000b029029817302575so1985962qtp.10 for ; Wed, 08 Sep 2021 05:48:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=0RK7cY+tkOweqZMcJZIaR/97eAhtBLD+9G9scSDOpYw=; b=QxpefR3OLgep4g5XGuQ2B1cNVAJH5+a3tfHlN3LyDhp9yhZ+DpKkqGpVOjnvs2Ai+f H8yGMuw1t7apKeYfABYhwhhJq8sNS7RmwLcsXcXkpL3nQxs/qF0VQ1DZHfUZ4AZPt04b ltoHHxieM8Uf2CXBTwSLwsVoYwsUsU0cPVrHGI7apXSYdp0jctUbpuj8AYFKf17vY2rN UcN5W2Ej7gDmi5g19CjWdUkpIDW6e3o2POIjHHUeJGZpnHXaphx/LPqMR7vdGwUDF//I CMK5SKXU2umLiccU0FomqcUEl5V0u86TPf1rZW1lNofKLYdYCI/79H79n7OD67RXgx0e gb9g== X-Gm-Message-State: AOAM532KhnWqLMH98l0VqFQM2dqIjHMm17gFiwYX9fSjb4VSwbT3F6h6 OR4iRT5c6tU5/zvI1CvUFpEcZtA3uYaO8M3FyGacu51vysmr+bQwnNVVyznefYxZup3QwUxKuMm KIe3sI58= X-Received: by 2002:ae9:e012:: with SMTP id m18mr3241458qkk.396.1631105321177; Wed, 08 Sep 2021 05:48:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxfldoQAW8fAeU6UalGBgm0t+LNjmtOXmYJNlsQ6ygdOUrxRzwGaJskiATGj868gtmudYLp4g== X-Received: by 2002:ae9:e012:: with SMTP id m18mr3241445qkk.396.1631105320942; Wed, 08 Sep 2021 05:48:40 -0700 (PDT) Received: from t14s.localdomain (c-73-69-212-193.hsd1.ma.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id y19sm1425981qtv.21.2021.09.08.05.48.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Sep 2021 05:48:40 -0700 (PDT) Message-ID: <4752e7eeda98e1b15e2adf0abdfc04313663ca32.camel@redhat.com> Subject: Re: Sv: [PATCH 1/2 v2] jit : Generate debug info for variables From: David Malcolm To: Petter Tomner , "gcc-patches@gcc.gnu.org" , "jit@gcc.gnu.org" Date: Wed, 08 Sep 2021 08:48:39 -0400 In-Reply-To: <75de9fbd1bcf460a8aeb48fde2072d96@kth.se> References: <7886e65c8e4c4df4b49ae69ccee01973@kth.se> <75de9fbd1bcf460a8aeb48fde2072d96@kth.se> User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: jit@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Jit mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Sep 2021 12:48:44 -0000 On Tue, 2021-09-07 at 16:18 +0000, Petter Tomner via Gcc-patches wrote: > I realized I still managed to mess up some WS. I have attached a > patch that is the same, except fixes the WS issue > underneath. > > Regards, Petter > > +      FOR_EACH_VEC_ELT (m_globals, i, global) > +    rest_of_decl_compilation (global, true, true); Thanks for the updated patch. Looks good to me, assuming it's been tested successfully. It should be combined with the testcase into a single commit when pushed. Do you have push rights to the GCC git repo? Dave