public inbox for jit@gcc.gnu.org
 help / color / mirror / Atom feed
From: David Malcolm <dmalcolm@redhat.com>
To: Antoni Boucher <bouanto@zoho.com>
Cc: gcc-patches@gcc.gnu.org, jit@gcc.gnu.org
Subject: Re: [PATCH] ggc, jit: forcibly clear GTY roots in jit
Date: Thu, 14 Sep 2023 16:33:20 -0400	[thread overview]
Message-ID: <4c0293d1f94cb290ab682587209fff41f09e7c26.camel@redhat.com> (raw)
In-Reply-To: <346bb0c85a6ddb6f9074f5ac6cd6d70075cb14ee.camel@zoho.com>

On Tue, 2023-09-12 at 15:20 -0400, Antoni Boucher wrote:

FWIW I've pushed the "ggc, jit: forcibly clear GTY roots in jit" to
trunk after retesting it, as r14-4003-geaa8e8541349df.

> I added it to bugzilla here:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111396

I don't yet have a fix for this issue.

Dave


> 
> Since this only reproduces part of the issue, please let me test
> again
> with rustc_codegen_gcc after adding the missing fix.
> 
> I confirmed that the fix is in
> https://github.com/antoyo/gcc/commit/9d5b6b20efa20825926196759d50706a604c64a8
> so you might as well include all of this (except the linetable
> condition in toplev.cc).
> 
> On Tue, 2023-09-12 at 14:38 -0400, David Malcolm wrote:
> > On Tue, 2023-09-12 at 13:36 -0400, Antoni Boucher wrote:
> > > In the mean time, here's a (Rust) reproducer for the issue:
> > > 
> > > fn main() {
> > >     for _ in 0..5 {
> > >         let context = Context::default();
> > >         context.add_command_line_option("-flto");
> > >        
> > > context.set_optimization_level(OptimizationLevel::Aggressive);
> > >         context.add_driver_option("-nostdlib");
> > > 
> > >         let int_type = context.new_type::<i32>();
> > > 
> > >         let function = context.new_function(None,
> > > FunctionType::Exported, int_type, &[], "main", false);
> > >         let block = function.new_block("start");
> > >         let value = context.new_rvalue_from_int(int_type, 42);
> > >         block.end_with_return(None, value);
> > > 
> > >         context.compile_to_file(OutputKind::Executable,
> > > "my_exe");
> > >     }
> > > }
> > 
> > Can we get this in bugzilla please?  If you generate a .c version
> > of
> > the context (via gcc_jit_context_dump_reproducer_to_file) I can try
> > to
> > debug it.
> > 
> > Thanks
> > Dave
> > 
> 


      reply	other threads:[~2023-09-14 20:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-06 13:40 David Malcolm
2023-09-06 13:57 ` Antoni Boucher
2023-09-12  9:35 ` Richard Biener
2023-09-12 16:00   ` Antoni Boucher
2023-09-12 17:36     ` Antoni Boucher
2023-09-12 18:38       ` David Malcolm
2023-09-12 19:20         ` Antoni Boucher
2023-09-14 20:33           ` David Malcolm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4c0293d1f94cb290ab682587209fff41f09e7c26.camel@redhat.com \
    --to=dmalcolm@redhat.com \
    --cc=bouanto@zoho.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jit@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).