From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8053 invoked by alias); 31 Oct 2014 21:29:57 -0000 Mailing-List: contact jit-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: Sender: jit-owner@gcc.gnu.org Received: (qmail 8022 invoked by uid 89); 31 Oct 2014 21:29:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.98.4 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_40,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-Spam-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_40,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Message-ID: <5453FF50.9030806@redhat.com> Date: Wed, 01 Jan 2014 00:00:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: David Malcolm , gcc-patches@gcc.gnu.org, jit@gcc.gnu.org Subject: Re: [PATCH 23/27] Documentation: the "intro" subdirectory References: <1414774977-25605-1-git-send-email-dmalcolm@redhat.com> <1414774977-25605-23-git-send-email-dmalcolm@redhat.com> In-Reply-To: <1414774977-25605-23-git-send-email-dmalcolm@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-SW-Source: 2014-q4/txt/msg00099.txt.bz2 On 10/31/14 11:02, David Malcolm wrote: > The "intro" subdirectory of gcc/jit/docs consists of a 4-part tutorial > aimed at experienced developers who are new users of the library, taking > them from beginning use all the way up to adding JIT-compilation to an > interpreter. > > gcc/jit/ > * docs/intro/factorial.png: New. > * docs/intro/index.rst: New. > * docs/intro/sum-of-squares.png: New. > * docs/intro/tutorial01.rst: New. > * docs/intro/tutorial02.rst: New. > * docs/intro/tutorial03.rst: New. > * docs/intro/tutorial04.rst: New. I'm not actually reviewing the .rst bits, but instead looking at the generate docs -- and I'm mostly just looking at them from a higher level (ie, what belongs, what doesn't and such). Given you've addressed the issues raised earlier I don't expect further changes in this area. Patches 23, 24, 25 are all OK. I don't see #26 or #27 in the series? Were they particularly large? jeff