From: Jeff Law <law@redhat.com>
To: David Malcolm <dmalcolm@redhat.com>,
gcc-patches@gcc.gnu.org, jit@gcc.gnu.org
Subject: Re: [PATCH 17/21] PR jit/63854: Fix leaking vec in jit
Date: Wed, 01 Jan 2014 00:00:00 -0000 [thread overview]
Message-ID: <546CCE1B.6000203@redhat.com> (raw)
In-Reply-To: <1416393981-39626-18-git-send-email-dmalcolm@redhat.com>
On 11/19/14 03:46, David Malcolm wrote:
> This fixes various leaks of vec buffers seen via valgrind within jit
> (both recording and playback).
>
> Various vec<> within jit::recording are converted to auto_vec<>.
>
> Various playback::wrapper subclasses containing vec<> gain a finalizer
> so they can release the vec when they are collected.
>
> gcc/jit/ChangeLog:
> PR jit/63854
> * jit-playback.c (gcc::jit::playback::compound_type::set_fields):
> Convert param from const vec<playback::field *> & to
> const auto_vec<playback::field *> *.
> (gcc::jit::playback::context::new_function_type): Convert param
> "param_types" from vec<type *> * to const auto_vec<type *> *.
> (gcc::jit::playback::context::new_function): Convert param
> "params" from vec<param *> * to const auto_vec<param *> *.
> (gcc::jit::playback::context::build_call): Convert param "args"
> from vec<rvalue *> to const auto_vec<rvalue *> *.
> (gcc::jit::playback::context::new_call): Likewise.
> (gcc::jit::playback::context::new_call_through_ptr): Likewise.
> (wrapper_finalizer): New function.
> (gcc::jit::playback::wrapper::operator new): Call the finalizer
> variant of ggc_internal_cleared_alloc, supplying
> wrapper_finalizer.
> (gcc::jit::playback::function::finalizer): New.
> (gcc::jit::playback::block::finalizer): New.
> (gcc::jit::playback::source_file::finalizer): New.
> (gcc::jit::playback::source_line::finalizer): New.
>
> * jit-playback.h
> (gcc::jit::playback::context::new_function_type): Convert param
> "param_types" from vec<type *> * to const auto_vec<type *> *.
> (gcc::jit::playback::context::new_function): Convert param
> "params" from vec<param *> * to const auto_vec<param *> *.
> (gcc::jit::playback::context::new_call): Convert param
> "args" from vec<rvalue *> to const auto_vec<rvalue *> *.
> (gcc::jit::playback::context::new_call_through_ptr): Likewise.
> (gcc::jit::playback::context::build_call): Likewise.
> (gcc::jit::playback::context): Convert fields "m_functions",
> "m_source_files", "m_cached_locations" from vec to auto_vec.
> (gcc::jit::playback::wrapper::finalizer): New virtual function.
> (gcc::jit::playback::compound_type::set_fields): Convert param fro
> const vec<playback::field *> & to
> const auto_vec<playback::field *> *.
> (gcc::jit::playback::function::finalizer): New.
> (gcc::jit::playback::block::finalizer): New.
> (gcc::jit::playback::source_file::finalizer): New.
> (gcc::jit::playback::source_line::finalizer): New.
>
> * jit-recording.c
> (gcc::jit::recording::function_type::replay_into): Convert local
> from a vec into an auto_vec.
> (gcc::jit::recording::fields::replay_into): Likewise.
> (gcc::jit::recording::function::replay_into): Likewise.
> (gcc::jit::recording::call::replay_into): Likewise.
> (gcc::jit::recording::call_through_ptr::replay_into): Likewise.
>
> * jit-recording.h (gcc::jit::recording::context): Convert fields
> "m_mementos", "m_compound_types", "m_functions" from vec<> to
> auto_vec <>.
> (gcc::jit::recording::function_type::get_param_types): Convert
> return type from vec<type *> to const vec<type *> &.
> (gcc::jit::recording::function_type): Convert field
> "m_param_types" from a vec<> to an auto_vec<>.
> (gcc::jit::recording::fields): Likewise for field "m_fields".
> (gcc::jit::recording::function::get_params): Convert return type
> from vec <param *> to const vec<param *> &.
> (gcc::jit::recording::function): Convert fields "m_params",
> "m_locals", "m_blocks" from vec<> to auto_vec<>.
> (gcc::jit::recording::block): Likewise for field "m_statements".
> vec<> to auto_vec<>.
> (gcc::jit::recording::call): Likewise for field "m_args".
> (gcc::jit::recording::call_through_ptr): Likewise.
OK.
Jeff
next prev parent reply other threads:[~2014-11-19 17:06 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-01 0:00 [PATCH 00/21] PR 63854: Fix various memory leaks David Malcolm
2014-01-01 0:00 ` [PATCH 12/21] PR jit/63854: Add a valgrind suppresion file David Malcolm
2014-01-01 0:00 ` Richard Biener
2014-01-01 0:00 ` Jeff Law
2014-01-01 0:00 ` David Malcolm
2015-01-01 0:00 ` Hans-Peter Nilsson
2014-01-01 0:00 ` [PATCH 20/21] PR jit/63854: Fix leak in ipa-icf.c David Malcolm
2014-01-01 0:00 ` Richard Biener
2014-01-01 0:00 ` [PATCH 13/21] PR jit/63854: Add support for running "make check-jit" under valgrind David Malcolm
2014-01-01 0:00 ` Jeff Law
2014-01-01 0:00 ` David Malcolm
2014-01-01 0:00 ` Jeff Law
2014-01-01 0:00 ` [PATCH 00/05] Fixes to jit.exp David Malcolm
2014-01-01 0:00 ` Running cc1 etc under valgrind (was Re: [PATCH 13/21] PR jit/63854: Add support for running "make check-jit" under valgrind) David Malcolm
2014-01-01 0:00 ` David Malcolm
2014-01-01 0:00 ` [PATCH 00/05] Fixes to jit.exp David Malcolm
2014-01-01 0:00 ` [PATCH 01/05] jit.exp: Avoid embedding full paths into test results David Malcolm
2014-01-01 0:00 ` Mike Stump
2014-01-01 0:00 ` [PATCH 03/05] jit.exp: fix timeout bug inherited from dejagnu.exp David Malcolm
2014-01-01 0:00 ` [PATCH 04/05] jit.exp: Verify the exit status of the spawnee David Malcolm
2014-01-01 0:00 ` [PATCH 05/05] Add command-line option-parsing to jit testcases David Malcolm
2014-01-01 0:00 ` PING: " David Malcolm
2014-01-01 0:00 ` Mike Stump
2014-01-01 0:00 ` David Malcolm
2014-01-01 0:00 ` Mike Stump
2014-01-01 0:00 ` [PATCH 02/05] PR jit/63854: Add support for running "make check-jit" under valgrind David Malcolm
2014-01-01 0:00 ` [PATCH 21/21] PR jit/63854: Fix leaks in test-fuzzer.c David Malcolm
2014-01-01 0:00 ` Jeff Law
2014-01-01 0:00 ` [PATCH 01/21] PR jit/63854: Fix memory leak within gcc_options David Malcolm
2014-01-01 0:00 ` Richard Biener
2014-01-01 0:00 ` [PATCH 18/21] PR jit/63854: Add "long-term" allocator to gcc::context David Malcolm
2014-01-01 0:00 ` Joseph Myers
2015-01-01 0:00 ` PING: " David Malcolm
2015-01-01 0:00 ` Joseph Myers
2014-01-01 0:00 ` [PATCH 10/21] PR jit/63854: Fix leak of worklist within jit-recording.c David Malcolm
2014-01-01 0:00 ` Jeff Law
2014-01-01 0:00 ` David Malcolm
2014-01-01 0:00 ` Richard Biener
2014-01-01 0:00 ` Jeff Law
2014-01-01 0:00 ` [PATCH 16/21] PR jit/63854: Add all_late_ipa_passes to GCC_PASS_LISTS David Malcolm
2014-01-01 0:00 ` Richard Biener
2014-01-01 0:00 ` [PATCH 17/21] PR jit/63854: Fix leaking vec in jit David Malcolm
2014-01-01 0:00 ` Jeff Law [this message]
2014-01-01 0:00 ` [PATCH 03/21] PR jit/63854: Fix memory leaks within context/pass_manager/dump_manager David Malcolm
2014-01-01 0:00 ` Jeff Law
2014-01-01 0:00 ` [PATCH 15/21] PR jit/63854: lra.c: Fix leak of point_freq_vec's buffer when calling lra_inheritance David Malcolm
2014-01-01 0:00 ` Jeff Law
2014-01-01 0:00 ` [PATCH 11/21] PR jit/63854: Fix leak of "avail" within tree-ssa-pre.c David Malcolm
2014-01-01 0:00 ` Richard Biener
2014-01-01 0:00 ` [PATCH 06/21] PR jit/63854: Fix leak of opts_obstack David Malcolm
2014-01-01 0:00 ` Richard Biener
2014-01-01 0:00 ` [PATCH 05/21] PR jit/63854: Fix memory leak of save_decoded_options David Malcolm
2014-01-01 0:00 ` Richard Biener
2014-01-01 0:00 ` [PATCH 19/21] PR jit/63854: Fix leak of ipa hooks David Malcolm
2014-01-01 0:00 ` Jeff Law
2014-01-01 0:00 ` PING " David Malcolm
2014-01-01 0:00 ` Jan Hubicka
2014-01-01 0:00 ` [PATCH 07/21] PR jit/63854: Fix leak of optimization_summary_obstack David Malcolm
2014-01-01 0:00 ` Richard Biener
2014-01-01 0:00 ` [PATCH 08/21] PR jit/63854: Add ira_costs_c_finalize David Malcolm
2014-01-01 0:00 ` Richard Biener
2014-01-01 0:00 ` [PATCH 02/21] PR jit/63854: Fix memory leak of reginfo.c: valid_mode_changes_obstack David Malcolm
2014-01-01 0:00 ` Richard Biener
2014-01-01 0:00 ` [PATCH 04/21] PR jit/63854: Fix memory leak within bb-reorder.c David Malcolm
2014-01-01 0:00 ` Richard Biener
2014-01-01 0:00 ` [PATCH 09/21] PR jit/63854: Don't leak producer_string in dwarf2out.c David Malcolm
2014-01-01 0:00 ` Richard Biener
2014-01-01 0:00 ` [PATCH 14/21] PR jit/63854: Fix leak of paths within jump threading David Malcolm
2014-01-01 0:00 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546CCE1B.6000203@redhat.com \
--to=law@redhat.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jit@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).