From: Jeff Law <law@redhat.com>
To: David Malcolm <dmalcolm@redhat.com>,
gcc-patches@gcc.gnu.org, jit@gcc.gnu.org
Subject: Re: [PATCH 06/08] Avoid overuse of name "buffer" in tree-pretty-print.c
Date: Wed, 01 Jan 2014 00:00:00 -0000 [thread overview]
Message-ID: <547CDDA9.6020009@redhat.com> (raw)
In-Reply-To: <1416965978-15582-7-git-send-email-dmalcolm@redhat.com>
On 11/25/14 18:39, David Malcolm wrote:
> Various functions in tree-pretty-print.c take a param
> pretty_printer *buffer
> and there's also a static pretty_printer *buffer;
>
> Additionally, pretty_printer instances are not buffers; they
> *contain* buffers (inasmuch as they have a field "buffer").
>
> This patch renames such params from "buffer" to "pp", and the static
> "buffer" to "tree_pp" to make it easier to tell what we're dealing
> with (a param, a file-static, or a buffer).
>
> gcc/ChangeLog:
> * tree-pretty-print.c (INDENT): Rename "buffer" to "pp".
> (NIY): Likewise.
> (buffer): Rename this variable to...
> (tree_pp): ...this.
>
> (do_niy): Rename param from "buffer" to "pp".
> (dump_decl_name): Likewise.
> (dump_function_name): Likewise.
> (dump_function_declaration): Likewise.
> (dump_array_domain): Likewise.
> (dump_omp_clause): Likewise.
> (dump_omp_clauses): Likewise.
> (dump_location): Likewise.
> (dump_block_node): Likewise.
> (dump_generic_node): Likewise.
> (print_declaration): Likewise.
> (print_struct_decl): Likewise.
> (print_call_name): Likewise.
> (pretty_print_string): Likewise.
> (newline_and_indent): Likewise.
>
> (print_generic_decl): Update for renaming of "buffer" to
> "tree_pp".
> (print_generic_stmt): Likewise.
> (print_generic_stmt_indented): Likewise.
> (print_generic_expr): Likewise.
> (maybe_init_pretty_print): Likewise.
OK.
jeff
next prev parent reply other threads:[~2014-12-01 21:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-01 0:00 [PATCH 00/08] More memory leak fixes David Malcolm
2014-01-01 0:00 ` [PATCH 05/08] PR jit/63854: Fix double-initialization within tree-pretty-print.c David Malcolm
2014-01-01 0:00 ` Jeff Law
2014-01-01 0:00 ` [PATCH 06/08] Avoid overuse of name "buffer" in tree-pretty-print.c David Malcolm
2014-01-01 0:00 ` Jeff Law [this message]
2014-01-01 0:00 ` [PATCH 03/08] PR jit/63854: Fix leak in real.c for i386:init_ext_80387_constants David Malcolm
2014-01-01 0:00 ` Richard Biener
2014-01-01 0:00 ` [PATCH 02/08] PR jit/63854: Fix leak within jit-builtins.c David Malcolm
2014-01-01 0:00 ` [PATCH 07/08] PR jit/63854: Fix leaks in toyvm.c David Malcolm
2014-01-01 0:00 ` [PATCH 08/08] PR/64003 workaround (uninit memory in i386.md) David Malcolm
2014-01-01 0:00 ` Jeff Law
2014-01-01 0:00 ` David Malcolm
2014-01-01 0:00 ` Jeff Law
2014-01-01 0:00 ` Jeff Law
2014-01-01 0:00 ` [PATCH 01/08] PR jit/63854: Fix leak in tree-ssa-math-opts.c David Malcolm
2014-01-01 0:00 ` Richard Biener
2014-01-01 0:00 ` [PATCH 04/08] PR jit/63854: Remove xstrdup from ipa/cgraph fprintf calls David Malcolm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547CDDA9.6020009@redhat.com \
--to=law@redhat.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jit@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).