From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sender4-pp-o91.zoho.com (sender4-pp-o91.zoho.com [136.143.188.91]) by sourceware.org (Postfix) with ESMTPS id 91F3C3858D28; Fri, 17 Nov 2023 21:08:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 91F3C3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=zoho.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=zoho.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 91F3C3858D28 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=136.143.188.91 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700255306; cv=pass; b=av/y3IvzXkcovUimMXT0ryfb4pJgWqV/Ij8YwJFqe23Ue0lpMHqZeBg03blEQtIk++noql1LKGtU7nkeAdgPa/Qq8vVViKj4tBiXDWTAbH0oWjueOis5hYanA7XkHtqTzsRb9MNQlOXTTnMMS6fHdhMlGIUEN4CHz/37ZZE1uSU= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700255306; c=relaxed/simple; bh=ZO2lXY4afhWrvMt5qozgpYYDQcAsikMw0FLmrzQHB6U=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=VFfra3Nk2gCE6tZ/2IYS15JJfEIVL7rt94wlPK6d7v8nlg3+65R4QcSYvW2PIimSV59AKiik0JI1NGR1dpod9visW6TAksZfOLbiBMaqtDVkjMoOMT78GfV8Mn0gw3Vpf3abdNyyKXZsHIwbUXoFRcsWZOk5U6Nn+wWoNJzM8MY= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; t=1700255298; cv=none; d=zohomail.com; s=zohoarc; b=hV5ib4anaxQiZnLc0CQqp9VTfYgWDIzwrx6Wsl+04CtxXJIpexQn1orc+A8TYW6jgigaS/or0H6Hy7oP1JxztyVlHxOzXvrHxlTNvq8LCPrlWlRiMl2aFrIE4J1fWCHNuETMD/lQGXbYikUcafM/TkePswFYvnv6ch6snkbPrys= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1700255298; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=ZO2lXY4afhWrvMt5qozgpYYDQcAsikMw0FLmrzQHB6U=; b=TwYRx1K3Avr+qujaGuQNSmJ2jRmdFjq/qftUo7QtNrlTt7qonzNwx7LpHhmwbl7MQXVh5TERI4+HxiBdh5HSK7ETz6GyIJ7HUoHmAT87ARUBNtDfFbzdK5UqPvAaTel/iqcvKJdG6jWLT0QN3EWUGFeyNxQXAt106U9IkLqOVC0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=zoho.com; spf=pass smtp.mailfrom=bouanto@zoho.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1700255298; s=zm2022; d=zoho.com; i=bouanto@zoho.com; h=Message-ID:Subject:Subject:From:From:To:To:Cc:Cc:Date:Date:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:MIME-Version:Feedback-ID:Message-Id:Reply-To; bh=ZO2lXY4afhWrvMt5qozgpYYDQcAsikMw0FLmrzQHB6U=; b=ajB8nDYk3qpSVhPlQADncFzsqRco4qrGyFOdsjU7IBrAqymhmAMSDO5cS2YIN9ZI T3oNfBJ14Kn6HyJIFJNufhfpO44QxO3LBh+WStpiDj8Ow4ezNuoGr3tyWKld8DrGEga RvAWgrT+ifcfn7O7e0DY3V7Yz04//g4Vc6Ti9ei0= Received: from [192.168.1.172] (38.87.11.6 [38.87.11.6]) by mx.zohomail.com with SMTPS id 17002552963991022.8388507625605; Fri, 17 Nov 2023 13:08:16 -0800 (PST) Message-ID: <5552026bb6829cc0df67b11576ed1d02efd8eaee.camel@zoho.com> Subject: Re: [PATCH] libgccjit Fix a RTL bug for libgccjit From: Antoni Boucher To: Jeff Law , jit@gcc.gnu.org, gcc-patches@gcc.gnu.org Cc: David Malcolm Date: Fri, 17 Nov 2023 16:08:14 -0500 In-Reply-To: <7c598b42-f866-4661-8682-818e7e7bbccf@gmail.com> References: <7c598b42-f866-4661-8682-818e7e7bbccf@gmail.com> Autocrypt: addr=bouanto@zoho.com; prefer-encrypt=mutual; keydata=mQENBFOSMLQBCADO5aw6Ys8thMQUNzrwAnfJX2wbgWiz0pQ01DjYj22eeIpChkoZn6LWdt4dieq30u2rFi/yQzJ02foHwI2+aL9rU6xz/x4TwqyRJQGMOqklNc3R+pdXmH4WDQkQDWmLxvc07vu+zb8Tx5A6pMDh4J2ncCEhLEUcH39Yq/yg4eBnFwUX6N7kakvHrnScGNqhnSFCacoJeMJUAR+1G7VBSBd++jmnHLnx3mj7QkRZVECJUw2zqiv1yReCC6GU4SvqLjdqm5ZGeoWOqD/NHjBRoEeOVjzp6M/qOjjWRbkJVqmvgfcD8UytSSqqboR35YFT4L+rZt2ri3T12MJb3i5syCAXABEBAAG0IUFudG9uaSBCb3VjaGVyIDxib3VhbnRvQHpvaG8uY29tPokBVgQTAQgAQAIbIwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAFiEEOELC4Uw1Jeb66YE6RVeGAwR4zcEFAlz4QM4FCRLMEZoACgkQRVeGAwR4zcFBQQf/afttJrA/puADQZhrDfkgr0MFvq6iB+GCy1b8BkXimk1TOXTPt87YLehSeijNu3JkYhl5eRc87BNfU9J87KfI/KIy6hZxqlDXk16FhW9bw/7wYEA0hpb3MUn7xLElXDT0ZHaD+KTe8Oun7qfzgx5RlL6r/WODf3CkSpO085R/rfeBqDEx9mVlhDWgq6Az3CZoD+3CqiCKVqmDuHTWz4kwrd9AM5eVcLvvLKnZIdoIp+G5Ao6BvaGlZyfenN1iOSjLy2NXNt4MnUt0lUYEP5KSIIRhHQ8xkUbj7eWUmaahkxhNb3fH3sAPwGnRZrPpb4rgYzNmSk63wWMh9M2xk+rLb7kBDQRTkjC0AQgAumZzsAV/UFWI+dpzebQfma36kKYZZFuseant5sq/HWP553XQ/U6ttJiKyN5MpCqtxvCAoRplf42YhlHuFqgf73WJxoJ6Y+sdyqoBSwlR+ gzAneAmsa8gmmY0wawH0Z2leazjKuS7mJjVEQZg0ZGsiCVRGeRnDqFGzDEzDc9ngWKSoTq0fKzlGy1X85OrtmUrvEbhSo6HP+FoeunHkIqrxu3w3vDoFEXxVQlKI6V3I4nCz5n6DB8WR3L7nsiiTnOiGirPw1ngvWFLW86kkA4FJpayc8Xl3va3SLY+2y4yuROboX2DVI4AC/Qeug/mDiBicPxkP6YfUartQRMe6obkEQARAQABiQE8BBgBCAAmAhsMFiEEOELC4Uw1Jeb66YE6RVeGAwR4zcEFAlz4QRsFCRLMEecACgkQRVeGAwR4zcE56ggAgTgrJInBKC+7552Dpccuo6Clh3wZfjlNLv9/6r5lKEbaNzaTrfhPiAP4WgnluIUmj8amOFLFJpj+BAVNOXpZ4D2R3o9ch8z7fot+fW4Yw+PKIxH4I2xEys8ndoEB3aiQwHjKcGIhkIU7uyMJFQr2aWjdTY0gmXw0YZueHOSLgo7uX4XKxB8fEO/yto/Tff2YBAAq+AtNwt+Gh5YS9rZw7rwUTWMi84yVOlc+zRE79E9NJkvdTwX7IJYo64VzIRNfgHsn7QNdVzuM1XIFHl+Glk6cIlI8s6BO7nEoCn3hTF104fQTAO3fEs+XXZOKXo2lk8faowEoPq5r58StrV0nyg== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.1 MIME-Version: 1.0 Feedback-ID: rr080112287d121730c766d8dd19f6860e0000bacd20cb8cb33c44c67ea603c3ba74c3384ae804624420bfd6d5:zu08011226a471733bc86fba733fa9ca9e0000a541978be88f6e16dea36ec9049a6bca2b6207cff986f4d5:rf0801123296b0854c27a9d4eafc006a630000c4f351033ebd4b671fe05bf28306e452264889b5df56986d60121248da5e90579ffe67b4:ZohoMail X-ZohoMailClient: External X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: In contrast with the other frontends, libgccjit can be executed multiple times in a row in the same process. This is the source of multiple bugs due to global variables as can be seen by several patches I sent these past years. On Fri, 2023-11-17 at 14:06 -0700, Jeff Law wrote: >=20 >=20 > On 11/16/23 15:36, Antoni Boucher wrote: > > Hi. > > This patch fixes a RTL bug when using some target-specific builtins > > in > > libgccjit (bug 112576). > >=20 > > The test use a function from an unmerged patch: > > https://gcc.gnu.org/pipermail/jit/2023q1/001605.html > >=20 > > Thanks for the review! > The natural question here is why does libgccjit call init_emit_once > more=20 > than one time?=C2=A0 The whole point of that routine is doing one time= =20 > initializations.=C2=A0 It's not supposed to be called more than once. >=20 > David?=C2=A0 Thoughts here? >=20 > jeff