From: Jeff Law <law@redhat.com>
To: David Malcolm <dmalcolm@redhat.com>
Cc: gcc-patches@gcc.gnu.org, jit@gcc.gnu.org
Subject: Re: [PATCH 1/2] Add gcc/typed-splay-tree.h
Date: Thu, 01 Jan 2015 00:00:00 -0000 [thread overview]
Message-ID: <559424FF.3030008@redhat.com> (raw)
In-Reply-To: <1435599418.13727.144.camel@surprise>
On 06/29/2015 11:36 AM, David Malcolm wrote:
> On Thu, 2015-06-25 at 13:18 -0600, Jeff Law wrote:
>> On 06/25/2015 01:13 PM, David Malcolm wrote:
>>> I found when implementing switch statements for the jit that it
>>> was much easier to work with libiberty's splay-tree.h by first
>>> wrapping it in a C++ wrapper to add typesafety.
>>>
>>> This patch adds such a wrapper, implementing the methods I needed.
>>>
>>> It's unused in this patch, but is used in the followup patch (which only
>>> touches the jit).
>>>
>>> OK for trunk?
>>>
>>> gcc/ChangeLog:
>>> * typed-splay-tree.h: New file.
>> OK.
>
> Well, this is embarrassing, it seems the patch I posted to the list
> doesn't actually compile.
It happens. It's one of the reasons why we have the rules around
bootstrap testing :-) I can't count how many of these kinds of goofs
I've made through the years.
>
> The underlying splay_tree_insert returns a splay_tree_node, I had the
> typed_splay_tree::insert returning a value_type. I dropped this bogus
> return type from the "insert" method in the implementation, in favor of
> "void", but I forgot to update the declaration, leading to errors when
> attempting to actually compile this (via jit/jit-recording.c in the
> followup patch).
>
> The attached one-liner patch drops it from the declaration, and applies
> to [PATCH 1/2]. I don't know if I can count this as "obvious"... It
> does compile now, and "make check-jit" looks good.
I'd think this qualifies :-)
jeff
next prev parent reply other threads:[~2015-07-01 17:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-01 0:00 switches in GCC JIT? Basile Starynkevitch
2015-01-01 0:00 ` David Malcolm
2015-01-01 0:00 ` Basile Starynkevitch
2015-01-01 0:00 ` David Malcolm
2015-01-01 0:00 ` Basile Starynkevitch
2015-01-01 0:00 ` Dibyendu Majumdar
2015-01-01 0:00 ` David Malcolm
2015-01-01 0:00 ` Dibyendu Majumdar
2015-01-01 0:00 ` Basile Starynkevitch
2015-01-01 0:00 ` [PATCH 1/2] Add gcc/typed-splay-tree.h David Malcolm
2015-01-01 0:00 ` Jeff Law
2015-01-01 0:00 ` David Malcolm
2015-01-01 0:00 ` Jeff Law [this message]
2015-01-01 0:00 ` [PATCH 2/2] jit: add switch statements David Malcolm
2015-01-01 0:00 ` [PATCH, committed] " David Malcolm
2015-01-01 0:00 ` [PATCH 2/2] " Basile Starynkevitch
2015-01-01 0:00 ` David Malcolm
2015-01-01 0:00 ` Jeff Law
2015-01-01 0:00 ` Managing ABI compatibility (was Re: [PATCH 2/2] jit: add switch statements) David Malcolm
2015-01-01 0:00 ` David Malcolm
2015-01-01 0:00 ` [PATCH 2/2] jit: add switch statements Basile Starynkevitch
2015-01-01 0:00 ` David Malcolm
2015-01-01 0:00 ` switches in GCC JIT? David Malcolm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559424FF.3030008@redhat.com \
--to=law@redhat.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jit@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).