From: Basile Starynkevitch <basile@starynkevitch.net>
To: David Malcolm <dmalcolm@redhat.com>
Cc: gcc-patches@gcc.gnu.org, jit@gcc.gnu.org
Subject: Re: PATCH trunk GCCJIT: adding gcc_jit_context_new_rvalue_from_long_long, etc...
Date: Thu, 01 Jan 2015 00:00:00 -0000 [thread overview]
Message-ID: <55A6B669.10104@starynkevitch.net> (raw)
In-Reply-To: <1436986339.830.59.camel@surprise>
On 07/15/2015 20:52, David Malcolm wrote:
> On Wed, 2015-07-15 at 20:19 +0200, Basile Starynkevitch wrote:
>> Hello All and David Malcolm
>>
>> The attached patch (relative to trunk r224842) is adding
>> gcc_jit_context_new_rvalue_from_long_long and similar functions to
>> GCCJIT.
> * dump_to_reproducer support (most testcases attempt to dump their
> contexts to a .c file and then sanity-check the generated c by
> compiling them, though not running them; see jit.exp). A new API
> entrypoint needs to "know" how to write itself back out to C (by
> implementing gcc::jit::recording::memento::write_reproducer for the
> appropriate memento subclass).
I'm sorry, but I can't understand the above comment. Where is the
"Implementation of recording::memento::write_reproducer for longs." I
can't find such comment in jit-recording.c!
BTW, it is really a pity that even a brand new subtree like gcc/jit/,
coded mostly in C++, uses *.c
as the file extension for newly introduced C++ files. There is no legacy
reason to use *.c extensions for new C++ files (as we had for source
files of twenty years of age). I really find that confusing. And no
comment mention that it is C++ not C!
It makes me almost cry :-)
Cheers.
--
Basile STARYNKEVITCH http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mine, sont seulement les miennes} ***
next prev parent reply other threads:[~2015-07-15 19:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <55A6A421.8060707@starynkevitch.net>
2015-01-01 0:00 ` David Malcolm
2015-01-01 0:00 ` [PATCH, committed] jit: Add guide for submitting patches to jit docs David Malcolm
2015-01-01 0:00 ` PATCH trunk GCCJIT: adding gcc_jit_context_new_rvalue_from_long_long, etc Basile Starynkevitch
2015-01-01 0:00 ` David Malcolm
2015-01-01 0:00 ` PATCH (v2) " Basile Starynkevitch
2015-01-01 0:00 ` David Malcolm
2015-01-01 0:00 ` Basile Starynkevitch
2015-01-01 0:00 ` David Malcolm
2015-01-01 0:00 ` PATCH " Basile Starynkevitch
2015-01-01 0:00 ` Basile Starynkevitch [this message]
2015-01-01 0:00 ` David Malcolm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A6B669.10104@starynkevitch.net \
--to=basile@starynkevitch.net \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jit@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).