From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 2800A3858CDA for ; Mon, 25 Jul 2022 23:18:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2800A3858CDA Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-460-DhEeKxLtNG6wJ81uCgvNdA-1; Mon, 25 Jul 2022 19:18:55 -0400 X-MC-Unique: DhEeKxLtNG6wJ81uCgvNdA-1 Received: by mail-qv1-f70.google.com with SMTP id l2-20020ad44522000000b00474444d12a9so3110885qvu.13 for ; Mon, 25 Jul 2022 16:18:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=JWzWoYlwCOHPRBarxRGesBZLUL/XXKVAQdaeRwK8dP8=; b=DlZjq4wSLSGeZtbxA2r4bYXwUGZ3DSSXmj3EjyG3m6t8WMHycbyiwuoEbck7Qg7zYU 2j2rMSeJ+uLQLvj5lT8raj8c1uomOPoGWXGx3Exa0gHMlTsR7B2S+1lPAV2X0DMIFvia Pvhw4iSD7CN5wVW9MUTEmJACHhi21rJATSufWQMC0qpNuViPHHRJynpN6EOAw+CcKSzb qdbBkvXWTLTqtMLisVw1/0YBul58hYTyk5RBaUpGy3Z0ElgQyLgx9m4jfUvLyfvkT1sV PTis6kfpdo03FqXnxeRwkTlKyCemBQXYUtA+cCiQTvEyYresthYqz+S07zIGNHPuTV/l N+9g== X-Gm-Message-State: AJIora9r3oI1SsF7V/vlqeDDOD8wBbY3AnGpLaYfPc6le8Q9wHTrz38Z A8oW23ZjlQy+EkIZfJv9X7LDPub5KjGJqpFMarxIEMKvHQukKlKI9jzyxBGWrwhPPQHW87sVd/O DpMRV9CY= X-Received: by 2002:a05:622a:988:b0:31f:31c1:700c with SMTP id bw8-20020a05622a098800b0031f31c1700cmr9180634qtb.104.1658791135491; Mon, 25 Jul 2022 16:18:55 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tkw2ehdYPJu3fgCVYJohYGcrRI/FCWibIGr3dZZ7liO6RD6F19q5YXh6gt+lKhDuZqWFyJEw== X-Received: by 2002:a05:622a:988:b0:31f:31c1:700c with SMTP id bw8-20020a05622a098800b0031f31c1700cmr9180621qtb.104.1658791135259; Mon, 25 Jul 2022 16:18:55 -0700 (PDT) Received: from t14s.localdomain (c-73-69-212-193.hsd1.nh.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id l4-20020a37f904000000b006b64ba324desm5139060qkj.58.2022.07.25.16.18.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jul 2022 16:18:54 -0700 (PDT) Message-ID: <56d23606ae0212b3077bd617797ab14c465c6cc1.camel@redhat.com> Subject: Re: [PATCH] libgccjit.h: Make the macro definition for testing gcc_jit_context_new_bitcast correctly available. From: David Malcolm To: vibhavp@gmail.com, jit@gcc.gnu.org Cc: gcc-patches@gcc.gnu.org Date: Mon, 25 Jul 2022 19:18:53 -0400 In-Reply-To: <8ce556135d6366aeb434794e7247e8ca806ea736.camel@gmail.com> References: <8ce556135d6366aeb434794e7247e8ca806ea736.camel@gmail.com> User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: jit@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Jit mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jul 2022 23:18:58 -0000 On Sat, 2022-07-23 at 13:31 +0530, Vibhav Pant via Jit wrote: > The macro definition for LIBGCCJIT_HAVE_gcc-jit_context_new_bitcast > was earlier located in the documentation comment for > gcc_jit_context_new_bitcast, making it unavailable to code that > consumed libgccjit.h. This patch moves the definition out of the > comment, making it effective. Good catch! Do you have push rights to the git repo, or should I push this? Thanks Dave