From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sender4-pp-o90.zoho.com (sender4-pp-o90.zoho.com [136.143.188.90]) by sourceware.org (Postfix) with ESMTPS id 344813858D32; Thu, 1 Dec 2022 15:33:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 344813858D32 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=zoho.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=zoho.com ARC-Seal: i=1; a=rsa-sha256; t=1669908797; cv=none; d=zohomail.com; s=zohoarc; b=b2PUxGB5272AIHRYoS/ZkxMFADBByDwp3lobUuYv7jhk8PueOiE7DJWnOY535Z0D0D6+xZCgY30wWzj5YxmXAOXcV/ALtikbzuE+b6td+czmqSJZzdvYDokcIK2+Cs+MAhto+nx6uKP+F+YKAfA7Kh3POVMnKSarmCxdDA02bMg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1669908797; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=heYZC+YCaA+LP0eJnaaZDc2Yg7trquZSMRHayu3wadE=; b=YHbiPf9Jy1TedCku+hc0Jhelgjdkqg+TFBRA4Xq/zsnTcPEB7jRMlSPfxuuQt6DILv230t8imwRhGkGRuR746AYCBjCvn+V3jrLHfa2igiS9jpcl+dis+Cdi5XA88xMXsG9IDCu9mysn3RIvgoA3iN6uoFaTQRJ9zekI/wdlSlM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=zoho.com; spf=pass smtp.mailfrom=bouanto@zoho.com; dmarc=pass header.from= DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=zapps768; d=zoho.com; h=message-id:subject:from:to:cc:date:in-reply-to:references:content-type:user-agent:mime-version; b=sHP/0bcyie38YmQYK4IUSLMKFjMDQ4xYOo3iKY559zMLjlgLripbzoOGgoLbIWhrmS89oylVZr/g g4CPplpgLNhLmQ6TCwJtbyT0JoWJpeDX4LI1d2ZF/jiOuiyY3BnJ DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1669908797; s=zm2022; d=zoho.com; i=bouanto@zoho.com; h=Message-ID:Subject:Subject:From:From:To:To:Cc:Cc:Date:Date:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:MIME-Version:Message-Id:Reply-To; bh=heYZC+YCaA+LP0eJnaaZDc2Yg7trquZSMRHayu3wadE=; b=S+9bUULxBvhvrIZg5+S4S9B5hUBsROrIDpRr3BfqsLxuBIPXuwT5isfe0iolzveR IGqxhOU5aku2EkEH49FPUDXAajNy4gtgJdl9II/UYrdwWKjulvAegpVSPzvKmK9FI5n WFay2aDcU/5ZBH/nsEiuhDUkuRalCldhKzqfO9S8= Received: from [192.168.1.174] (38.87.11.6 [38.87.11.6]) by mx.zohomail.com with SMTPS id 166990879583827.58125542907817; Thu, 1 Dec 2022 07:33:15 -0800 (PST) Message-ID: <5827fc95314506387b9b0e5c5da865eb28cf28e8.camel@zoho.com> Subject: Re: [PATCH] libgccjit: Fix float vector comparison From: Antoni Boucher To: David Malcolm , gcc-patches@gcc.gnu.org, jit@gcc.gnu.org Cc: Guillaume Gomez Date: Thu, 01 Dec 2022 10:33:14 -0500 In-Reply-To: <74150b934836583a532d310c68d29384daf2fbd0.camel@redhat.com> References: <30eb27a08792e1e2b92e663753f22e31f65c7791.camel@redhat.com> <15fbee19972751bfa05c24ec95bc441c621c98ad.camel@zoho.com> <74150b934836583a532d310c68d29384daf2fbd0.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.1 MIME-Version: 1.0 X-ZohoMailClient: External X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 2022-12-01 at 10:25 -0500, David Malcolm wrote: > On Thu, 2022-12-01 at 10:01 -0500, Antoni Boucher wrote: > > Thanks, David. > > Since we're not in phase 1 anymore, do we need an approval before I > > merge like last year or can I merge immediately? >=20 > I think it counts as a bug fix and thus you can go ahead and merge > (assuming you've done the usual testing). >=20 > > I also have many other patches (all in jit) that I need to prepare > > and > > post to this mailing list. > > What do you think? >=20 > Given that you're one of the main users of libgccjit I think there's > a > case for stretching the deadlines a bit here. >=20 > Do you have a repo I can look at? Yes! The commits are in my fork: https://github.com/antoyo/gcc The only big one is the one adding support for target-dependent builtins: https://github.com/antoyo/gcc/commit/6d4313d4c02dd878f43917c978f299f5119330= f0 Regarding this one, there's the issue that since we record the builtins on the first context run, we only have access to the builtins from the second run. Do you have any idea how to fix this? Or do you consider this is acceptable? I also have a WIP branch which adds support for try/catch: https://github.com/antoyo/gcc/commit/6219339fcacb079431596a0bc6cf8d430a1bd5= a1 I'm not sure if this one is going to be ready soon or not. Thanks. >=20 > Dave >=20 >=20 > >=20 > > On Thu, 2022-12-01 at 09:28 -0500, David Malcolm wrote: > > > On Sun, 2022-11-20 at 14:03 -0500, Antoni Boucher via Jit wrote: > > > > Hi. > > > > This fixes bug 107770. > > > > Thanks for the review. > > >=20 > > > Thanks, the patch looks good to me. > > >=20 > > > Dave > > >=20 > >=20 >=20