public inbox for jit@gcc.gnu.org
 help / color / mirror / Atom feed
From: David Malcolm <dmalcolm@redhat.com>
To: Vibhav Pant <vibhavp@gmail.com>
Cc: jit@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] libgccjit.h: Make the macro definition for testing gcc_jit_context_new_bitcast correctly available.
Date: Tue, 09 Aug 2022 11:39:54 -0400	[thread overview]
Message-ID: <612d9f11391a47b84bdb967eb0bf7f30a20d1f22.camel@redhat.com> (raw)
In-Reply-To: <CA+T2Sh3+Fr0visv9nxzB_VwfDAUF5VVCYj7Go94tLqwJ=5tS+w@mail.gmail.com>

On Sat, 2022-07-30 at 19:18 +0530, Vibhav Pant wrote:
> I don't have push rights to the repo, so this would need to be
> applied manually.

I've gone ahead and pushed your fix to trunk (for GCC 13) as r13-2004-
g9385cd9c74cf66.

I plan to also push it to the gcc 12 branch shortly (for gcc 12.2)


Thanks again for the patch.
Dave


> 
> 
> Thanks,
> Vibhav
> 
> On Tue, Jul 26, 2022 at 4:48 AM David Malcolm <dmalcolm@redhat.com>
> wrote:
> > 
> > On Sat, 2022-07-23 at 13:31 +0530, Vibhav Pant via Jit wrote:
> > > The macro definition for LIBGCCJIT_HAVE_gcc-
> > > jit_context_new_bitcast
> > > was earlier located in the documentation comment for
> > > gcc_jit_context_new_bitcast, making it unavailable to code that
> > > consumed libgccjit.h. This patch moves the definition out of the
> > > comment, making it effective.
> > 
> > Good catch!
> > 
> > Do you have push rights to the git repo, or should I push this?
> > 
> > Thanks
> > Dave
> > 
> 
> 



  reply	other threads:[~2022-08-09 15:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-23  8:01 Vibhav Pant
2022-07-25 23:18 ` David Malcolm
2022-07-30 13:48   ` Vibhav Pant
2022-08-09 15:39     ` David Malcolm [this message]
2022-08-09 23:09       ` David Malcolm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=612d9f11391a47b84bdb967eb0bf7f30a20d1f22.camel@redhat.com \
    --to=dmalcolm@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jit@gcc.gnu.org \
    --cc=vibhavp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).