From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 82F0C385AE4F for ; Tue, 9 Aug 2022 15:39:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 82F0C385AE4F Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-298-QLtVwmuxN5-0uQzNUgMbuQ-1; Tue, 09 Aug 2022 11:39:57 -0400 X-MC-Unique: QLtVwmuxN5-0uQzNUgMbuQ-1 Received: by mail-qk1-f198.google.com with SMTP id bm34-20020a05620a19a200b006b5f1d95ceeso10399352qkb.5 for ; Tue, 09 Aug 2022 08:39:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc; bh=fC6bzgaDdBp0CHDV0jHB9MooCOZlpEGgnYPSJSE7/Cc=; b=tuflhPUykU8PxVS3lpY5yMp0Fn5scebWosNuEoJa6AlkdcNu5QG4Zq2JwbnOA/GY11 lFsq4tVo3U93WTaeqej4PKinVhYtAGaGzXVB7H7+tp4BqLLqeV8YEgV/d6hfaWFx2BmT ODpBOGFJ6cq59JRA5IG9eM4jUIWu+7U+KtbKVLPFbiD+Df3gcARlhubY7sYKYkoqUsZI clC+r/Aphu0PALh6Typ+cZ33gVGO/Lq74G6W9rTEThhS1Qi1kJqsZ1zTWoqpNU+Tt9Ra hSI6oud9ozZ8Ks86LZPWpDMkvB5trYdxajP08a9JFSTRHGuqfZ+ITBw3VG53Yo/D37IK 7+1A== X-Gm-Message-State: ACgBeo1Ad76eNANrBPBY/61h1TvbyC/1+BkWopYU1wKMt0oSxAy2AZJ0 NxoVywu+10Z5iCrp4mOHuNO72/8VLcmxiPAUeNgDNAQYtEadVMTtO6P88+yIUgNQDWUoEYtPvsN 79qbR8ew= X-Received: by 2002:a05:622a:1a0b:b0:33e:d364:13d8 with SMTP id f11-20020a05622a1a0b00b0033ed36413d8mr20944431qtb.341.1660059596681; Tue, 09 Aug 2022 08:39:56 -0700 (PDT) X-Google-Smtp-Source: AA6agR6XS37YaMb6CQ2ONwFkbeH45eXjulrZpAK/eIe8BkCxo036BMM+PLm/rL++jJQ3rBsLbAW4rg== X-Received: by 2002:a05:622a:1a0b:b0:33e:d364:13d8 with SMTP id f11-20020a05622a1a0b00b0033ed36413d8mr20944418qtb.341.1660059596484; Tue, 09 Aug 2022 08:39:56 -0700 (PDT) Received: from t14s.localdomain (c-73-69-212-193.hsd1.nh.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id l10-20020a05620a28ca00b006b259b5dd12sm11849962qkp.53.2022.08.09.08.39.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Aug 2022 08:39:55 -0700 (PDT) Message-ID: <612d9f11391a47b84bdb967eb0bf7f30a20d1f22.camel@redhat.com> Subject: Re: [PATCH] libgccjit.h: Make the macro definition for testing gcc_jit_context_new_bitcast correctly available. From: David Malcolm To: Vibhav Pant Cc: jit@gcc.gnu.org, gcc-patches@gcc.gnu.org Date: Tue, 09 Aug 2022 11:39:54 -0400 In-Reply-To: References: <8ce556135d6366aeb434794e7247e8ca806ea736.camel@gmail.com> <56d23606ae0212b3077bd617797ab14c465c6cc1.camel@redhat.com> User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: jit@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Jit mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Aug 2022 15:39:59 -0000 On Sat, 2022-07-30 at 19:18 +0530, Vibhav Pant wrote: > I don't have push rights to the repo, so this would need to be > applied manually. I've gone ahead and pushed your fix to trunk (for GCC 13) as r13-2004- g9385cd9c74cf66. I plan to also push it to the gcc 12 branch shortly (for gcc 12.2) Thanks again for the patch. Dave > > > Thanks, > Vibhav > > On Tue, Jul 26, 2022 at 4:48 AM David Malcolm > wrote: > > > > On Sat, 2022-07-23 at 13:31 +0530, Vibhav Pant via Jit wrote: > > > The macro definition for LIBGCCJIT_HAVE_gcc- > > > jit_context_new_bitcast > > > was earlier located in the documentation comment for > > > gcc_jit_context_new_bitcast, making it unavailable to code that > > > consumed libgccjit.h. This patch moves the definition out of the > > > comment, making it effective. > > > > Good catch! > > > > Do you have push rights to the git repo, or should I push this? > > > > Thanks > > Dave > > > >