From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 98A293857420 for ; Thu, 20 May 2021 19:59:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 98A293857420 Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-477-1Zuhl3arPD-bUL4q3iTe0w-1; Thu, 20 May 2021 15:59:25 -0400 X-MC-Unique: 1Zuhl3arPD-bUL4q3iTe0w-1 Received: by mail-qv1-f70.google.com with SMTP id b5-20020a0cc9850000b02901eece87073bso12693475qvk.21 for ; Thu, 20 May 2021 12:59:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=X7FWdglFoURz3S/QJHl0U79BqbpSowQqzWM7BX32Hr0=; b=mVgEx0pxjVQrk2eBNoonTkTPnFeXRuWDnWWUbGcakqJNuxcNuW/R+t1ZhG286ElRSo YxyzGsbPwoeV5m3lox7NUMIk8uOiN03Tul1ak0GUF4Ifkt3kMDbLkKIrV/vAEREYbsII Fj0q+ihmG+G3uXyytl+0rLXDQII9toYXRWxmubGWacG3n9wsyaFZETSxfxcvIhZqrI44 pioSHs5vs5eowsTRnIXOYLSX56k1cInWV/KsYmLHSUde53w2m3mnhemCFvhupOPcHK8S 3xBKLbceXHddYnq4awC7N5mqPoPntZXZ79hvz12ABV9EiFY1IZDOcl8zUtLm2KAG0AwC YyLw== X-Gm-Message-State: AOAM532jpUVJPBA2jSLfOQb8HYwQbflZRA5LdPx6eiDmPCoypJFiK4Lh C0HbdqUwBw5wDFmvCIXliRWylNFhgHhVGLMKXbzF12Wr9j+hLADGHQ6YN4kfs3Y9MZEChwcE8LT w54QtYMk= X-Received: by 2002:a05:622a:1356:: with SMTP id w22mr6968660qtk.253.1621540765283; Thu, 20 May 2021 12:59:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw40rBvuaXVpV4n5LPIGs74jv47ug/JVA1s3jSaIPE2Vg13ghJy5Fp3TPIdL7xdb1OamsHVQQ== X-Received: by 2002:a05:622a:1356:: with SMTP id w22mr6968648qtk.253.1621540765131; Thu, 20 May 2021 12:59:25 -0700 (PDT) Received: from t14s.localdomain (c-73-69-212-193.hsd1.nh.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id m128sm3048632qkf.134.2021.05.20.12.59.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 May 2021 12:59:24 -0700 (PDT) Message-ID: <61e15cd34cd847f8c423ab041b02caf54d26479a.camel@redhat.com> Subject: Re: [PATCH] libgccjit: Add support for setting the link section of global variables [PR100688] From: David Malcolm To: Antoni Boucher , jit@gcc.gnu.org, gcc-patches@gcc.gnu.org Date: Thu, 20 May 2021 15:59:23 -0400 In-Reply-To: References: <7fde146d8c3aecb47f66f34c836e2733eb4d8a6d.camel@zoho.com> User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: jit@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Jit mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 May 2021 19:59:28 -0000 On Thu, 2021-05-20 at 15:29 -0400, David Malcolm wrote: > On Wed, 2021-05-19 at 20:32 -0400, Antoni Boucher via Jit wrote: > > Hello. > > This patch adds support to set the link section of global > > variables. > > I used the ABI 18 because I submitted other patches up to 17. > > Thanks for the review. > > I didn't see this email until now, and put the review in bugzilla > instead; sorry. > > Here's a copy-and-paste of what I put in bugzilla: > [..snip...] > > > diff --git a/gcc/testsuite/jit.dg/all-non-failing-tests.h > b/gcc/testsuite/jit.dg/all-non-failing-tests.h > > index 4202eb7798b..7e3b59dee0d 100644 > > --- a/gcc/testsuite/jit.dg/all-non-failing-tests.h > > +++ b/gcc/testsuite/jit.dg/all-non-failing-tests.h > > @@ -181,6 +181,13 @@ > >  #undef create_code > >  #undef verify_code > >   > > +/* test-link-section.c */ > > +#define create_code create_code_link_section > > +#define verify_code verify_code_link_section > > +#include "test-link-section.c" > > +#undef create_code > > +#undef verify_code > > + > >  /* test-hello-world.c */ > >  #define create_code create_code_hello_world > >  #define verify_code verify_code_hello_world Something else I just noticed when looking at another of your patches: you also need to add a new entry to the "testcases" array to use the new {create|verify}_code_link_section functions. > [...snip...] Dave