From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sender4-pp-o91.zoho.com (sender4-pp-o91.zoho.com [136.143.188.91]) by sourceware.org (Postfix) with ESMTPS id 6FCEF3861843; Fri, 11 Jun 2021 20:44:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6FCEF3861843 ARC-Seal: i=1; a=rsa-sha256; t=1623444286; cv=none; d=zohomail.com; s=zohoarc; b=d3Vj38+qvDrMiZigwHWYtU5DShExQAYfZenQBfZD5ukcuID6NnZUgMB8Okp7uqh++iYF0zNGoHLgsjAFypvhv3vszRKKy+E597TIUqLDbMZkpanH5j2sq3AEcrTBQ9k3XHZbUW5QXIOE3Vk7888h6UWiC7Oi4DfUv7ZgcMU/QEE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1623444286; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=ZZu08kMVI0qhb/dXB2oejxqOf9qZblKyyPVdIk5Ov3M=; b=WKt/0TCE/3u4UdfeJTMMX+OfVKcjBvKUcwShJ5BpWdQI4WbT5FGsEnBusdmp+LbUAQc/nJ716FgRgfSs9ZEmVoUxtT9dTx8KEi7tcZyGrgRiUS3uKiBgeCGIdPLPgCXiCZtp5mvtnNWrzmInCQYlJ3/YVjUUhmTdtFCLZVecRNI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=zoho.com; spf=pass smtp.mailfrom=bouanto@zoho.com; dmarc=pass header.from= Received: from [192.168.1.174] (38.87.11.6 [38.87.11.6]) by mx.zohomail.com with SMTPS id 1623444280694883.1321282689787; Fri, 11 Jun 2021 13:44:40 -0700 (PDT) Message-ID: <62c178b5bb0ab004def3c7869da2b03846e5134c.camel@zoho.com> Subject: Re: [PATCH] libgccjit: Add function to set the initial value of a global variable [PR96089] From: Antoni Boucher To: David Malcolm Cc: jit@gcc.gnu.org, gcc-patches@gcc.gnu.org Date: Fri, 11 Jun 2021 16:44:38 -0400 In-Reply-To: <7d6762623f658712a4b802cc3d6524c106affa2b.camel@zoho.com> References: <7d6762623f658712a4b802cc3d6524c106affa2b.camel@zoho.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: jit@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Jit mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2021 20:44:52 -0000 David: this one wasn't reviewed yet by you, so you can review it. Le jeudi 20 mai 2021 =C3=A0 21:27 -0400, Antoni Boucher a =C3=A9crit=C2=A0: > Hi. >=20 > I made this patch to set an arbitrary value to a global variable. >=20 > This patch suffers from the same issue as inline assembly > (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D100380), i.e. it > segfaults if the `rvalue` is created after the global variable. > It seems to be a design issue so I'm not sure what would be the fix > for > it and having it fixed would allow me to test this new function much > more and see if things are missing (i.e. it might require a way to > create a constant struct). > See the link above for an explanation of this issue. >=20 > Thanks for the review.