From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 75EAA38A909A for ; Tue, 15 Nov 2022 18:50:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 75EAA38A909A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668538255; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7IteuwqMwt55REHsS9IhBT1NbA+lZB5qm9pvlxF5Igk=; b=g0Xw0p+97TEusW2aiQvmDkkGGSojxEAQcmYF6QGjvCKswjtq26uqC2BLMEdNm4ghyYC6qP 1hJd2jP3jjOK+sCkCCHGSs9lvDeoboUCTjYZoa0RDj1Rf83arhHN6mZACPwvY75iP7V8On oEg8XB9mJcoGpBOJBmaFMQeTeDlTIPw= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-45-BsKS4xbTPFmfBXuQYqRkGw-1; Tue, 15 Nov 2022 13:50:53 -0500 X-MC-Unique: BsKS4xbTPFmfBXuQYqRkGw-1 Received: by mail-qt1-f197.google.com with SMTP id ff5-20020a05622a4d8500b003a526107477so10835896qtb.9 for ; Tue, 15 Nov 2022 10:50:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=7IteuwqMwt55REHsS9IhBT1NbA+lZB5qm9pvlxF5Igk=; b=Ky+/pPHTIBoe40iwAdtMSUG15AvRmaX21w7VJK+NK3FWO+fxjAxxsg+eIzwjaxTsNT FBM8mUK3PMYelgX6HYs3hWNkEvO6/KV6PwhfWABx8/sHcVu8aqXPpSD7Qi8Wo2QfyV6k r69k195cKWmfYb8iE/kVUZRHzVBgpfeJIlf7APJU1qGm2m/UySqYBV57TrdRW8utXxD6 V4B57flqNoVkCF613Pd3WsIn1kVIWHD8ndhiZht147MffFrOW7Cbp2fM3cDVRzc/sWdq Vf65Ug2cKkt3LzjOuiChzZtxFPyR3CYavNfsymbsrIqxFIlNToPGgjEOnQikHSRHEuKX NvVA== X-Gm-Message-State: ANoB5plUXATmHPaA/nkByHGNudvHcx+osH3sReH7AkufyaBsWt5bXtVE BdRLyBsMKLImo8ZQNTFmztcwTYjwJuKO2RhbhEAo/2YcIYLswxB0fjAe65WUakmxmz7WmUKCJQp bgsWVF/M= X-Received: by 2002:a05:622a:3d0:b0:3a5:1940:a027 with SMTP id k16-20020a05622a03d000b003a51940a027mr17664138qtx.195.1668538253438; Tue, 15 Nov 2022 10:50:53 -0800 (PST) X-Google-Smtp-Source: AA0mqf58+nVmkvBDrMNg7P5kndQiDVuo0I31IMXZJuG9w0vbyQFP9C3UOUwkO/413vwiDBIUM3DTGQ== X-Received: by 2002:a05:622a:3d0:b0:3a5:1940:a027 with SMTP id k16-20020a05622a03d000b003a51940a027mr17664118qtx.195.1668538253224; Tue, 15 Nov 2022 10:50:53 -0800 (PST) Received: from t14s.localdomain (c-73-69-212-193.hsd1.nh.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id w8-20020a05620a444800b006fb7f94a65bsm3925858qkp.44.2022.11.15.10.50.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 10:50:52 -0800 (PST) Message-ID: <63a9058d0bb20e40a8d3c24ecbc0c5da1b54faf5.camel@redhat.com> Subject: Re: why does gcc jit require pthread? From: David Malcolm To: Jonathan Wakely , LIU Hao Cc: Andrew Pinski , gcc@gcc.gnu.org, gcc-patches@gcc.gnu.org, jit@gcc.gnu.org Date: Tue, 15 Nov 2022 13:50:52 -0500 In-Reply-To: References: <8f15b063-9ec8-59e0-590b-20e416f68cb4@126.com> <98c69fc7-713f-a09a-8ca7-c3e64bdfd309@126.com> <0c6b1411-fa35-1c2f-16f2-f26b6e6cedaa@126.com> User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: [Fixing typo in the Subject ("git" -> "jit" ); CCing jit mailing list] On Fri, 2022-11-11 at 17:16 +0000, Jonathan Wakely wrote: > On Mon, 7 Nov 2022 at 13:51, Jonathan Wakely wrote: > >=20 > > On Mon, 7 Nov 2022 at 13:33, LIU Hao wrote: > > >=20 > > > =E5=9C=A8 2022-11-07 20:57, Jonathan Wakely =E5=86=99=E9=81=93: > > > > It would be a lot nicer if playback::context met the C++ > > > > Lockable > > > > requirements, and playback::context::compile () could just take > > > > a > > > > scoped lock on *this: > > > >=20 > > > >=20 > > >=20 > > > Yeah yeah that makes a lot of sense. Would you please just commit > > > that? I don't have write access to > > > GCC repo, and it takes a couple of hours for me to bootstrap GCC > > > just for this tiny change. > >=20 > > Somebody else needs to approve it first. I'll combine our patches > > and > > test and submit it properly for approval. >=20 > Here's a complete patch that actually builds now, although I'm seeing > a stage 2 vs stage 3 comparison error which I don't have time to look > into right now. I confess that I'm not familiar with C++11's mutex and locking types, but having read through the relevant entries on cppreference.com, the patch looks correct to me. Are these classes well-supported on the minimum compiler version we support? (Jonathan, I defer to your judgement here) Jonathan: you said in your followup email that it "bootstraps and passes testing on x86_64-pc-linux-gnu (CentOS 8 Stream)". This is possibly a silly question, but did this testing include the jit testsuite? A gotcha here is that --enable-languages=3Dall does *not* enable jit. The patch is OK for trunk if you have favorable answers for the above two questions. Thanks! Dave