From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sender4-pp-o90.zoho.com (sender4-pp-o90.zoho.com [136.143.188.90]) by sourceware.org (Postfix) with ESMTPS id 7766E3861831; Wed, 10 Jan 2024 23:29:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7766E3861831 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=zoho.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=zoho.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7766E3861831 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=136.143.188.90 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1704929367; cv=pass; b=HKKTewhonvUz82vzIM9UWG1eog/2gghNm3wUxUFvBUSCucqqlwtL8FSBJJtxdD1swd5St6xdVFJFtBgiMkMI7q+g41xsz2/9rikukrerjIPcwsCOLC5wB1/Yke/fNwkbhCqK52dyU4YfQkfD5U26/qSHzw7eKQzycdQUBx2Jvkc= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1704929367; c=relaxed/simple; bh=C3FmWtmJBjMjbhQM4iH+mkEo/Y4yS59kuaOrUBl6MAU=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=nB7ob8KWimEWm2IPcpjOZaAVLPcvbSK82xwmtI80Y6q1GvIPkJCjXx5oHpwGt5r7GZzsG1rQ6FW/4ZWeeaB6FHvkSW4K+DkxoinKUPQYlsASOHKBVQIdk+IeJsufdsjnUSukrB/J39qOuJ6QPMHyWBQhgZ3A1eBhprTu02LYFQ0= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; t=1704929359; cv=none; d=zohomail.com; s=zohoarc; b=jUTeMJfili4OWgZWbmQS9B5I8F1fvYG30/xUM02E39QWgJ6sIsIBUUOhWUp1KSB0q/oyiI/wbN9Vx0ZfkD27mUmgJiT2TgQbTSyxVxAIPNlm7LWFsFzKeSz0yMuYQD9oKsVzxzHlvEWz5j7tEBopYS+ocY/CEcWAyNdNwgmbFi8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1704929359; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=C3FmWtmJBjMjbhQM4iH+mkEo/Y4yS59kuaOrUBl6MAU=; b=PbR8tQ8m4179JI6CM8KOMc/9f9B/x1DEGoM5Fm1YHUWkQiu2FnFEQ4GElQ6CGwU00HGlNRnX8TuX135B3NRWBqy/B+QzsT10cnXwqqVfwzKSbvk9Q7c62q9YQOJBrhIwdF79nbVMHXncLbC7nNmhW+FOErktLTlx1OGF0d+QhQ0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=zoho.com; spf=pass smtp.mailfrom=bouanto@zoho.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1704929359; s=zm2022; d=zoho.com; i=bouanto@zoho.com; h=Message-ID:Subject:Subject:From:From:To:To:Cc:Cc:Date:Date:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:MIME-Version:Feedback-ID:Message-Id:Reply-To; bh=C3FmWtmJBjMjbhQM4iH+mkEo/Y4yS59kuaOrUBl6MAU=; b=OWjT+pqWH1HpXYycUr6PYm+FcN03AEI5uN6uaaHninA9lAxS2/2NYAzY5oO88LO0 1vAC/kYElZHzitibl8IhKLlho7VITJf14Q3Qi3SP5zfPsXeXoQBRqV1M02jtrC/oQIA tqHMtUvwsGI4n6TWk7ZpQX6pqWDx6EpXwVuqFXNQ= Received: from [192.168.1.172] (38.87.11.6 [38.87.11.6]) by mx.zohomail.com with SMTPS id 1704929358630373.93007501969225; Wed, 10 Jan 2024 15:29:18 -0800 (PST) Message-ID: <68c5b0693c8f7a6c6ce59259fdf088106861e4e4.camel@zoho.com> Subject: Re: [PATCH] libgccjit: Add support for machine-dependent builtins From: Antoni Boucher To: Andrew Pinski Cc: jit@gcc.gnu.org, gcc-patches@gcc.gnu.org, David Malcolm Date: Wed, 10 Jan 2024 18:29:16 -0500 In-Reply-To: References: <184790403bd8227db4054b9e672afbfdf879dc0c.camel@zoho.com> Autocrypt: addr=bouanto@zoho.com; prefer-encrypt=mutual; keydata=mQENBFOSMLQBCADO5aw6Ys8thMQUNzrwAnfJX2wbgWiz0pQ01DjYj22eeIpChkoZn6LWdt4dieq30u2rFi/yQzJ02foHwI2+aL9rU6xz/x4TwqyRJQGMOqklNc3R+pdXmH4WDQkQDWmLxvc07vu+zb8Tx5A6pMDh4J2ncCEhLEUcH39Yq/yg4eBnFwUX6N7kakvHrnScGNqhnSFCacoJeMJUAR+1G7VBSBd++jmnHLnx3mj7QkRZVECJUw2zqiv1yReCC6GU4SvqLjdqm5ZGeoWOqD/NHjBRoEeOVjzp6M/qOjjWRbkJVqmvgfcD8UytSSqqboR35YFT4L+rZt2ri3T12MJb3i5syCAXABEBAAG0IUFudG9uaSBCb3VjaGVyIDxib3VhbnRvQHpvaG8uY29tPokBVgQTAQgAQAIbIwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAFiEEOELC4Uw1Jeb66YE6RVeGAwR4zcEFAlz4QM4FCRLMEZoACgkQRVeGAwR4zcFBQQf/afttJrA/puADQZhrDfkgr0MFvq6iB+GCy1b8BkXimk1TOXTPt87YLehSeijNu3JkYhl5eRc87BNfU9J87KfI/KIy6hZxqlDXk16FhW9bw/7wYEA0hpb3MUn7xLElXDT0ZHaD+KTe8Oun7qfzgx5RlL6r/WODf3CkSpO085R/rfeBqDEx9mVlhDWgq6Az3CZoD+3CqiCKVqmDuHTWz4kwrd9AM5eVcLvvLKnZIdoIp+G5Ao6BvaGlZyfenN1iOSjLy2NXNt4MnUt0lUYEP5KSIIRhHQ8xkUbj7eWUmaahkxhNb3fH3sAPwGnRZrPpb4rgYzNmSk63wWMh9M2xk+rLb7kBDQRTkjC0AQgAumZzsAV/UFWI+dpzebQfma36kKYZZFuseant5sq/HWP553XQ/U6ttJiKyN5MpCqtxvCAoRplf42YhlHuFqgf73WJxoJ6Y+sdyqoBSwlR+ gzAneAmsa8gmmY0wawH0Z2leazjKuS7mJjVEQZg0ZGsiCVRGeRnDqFGzDEzDc9ngWKSoTq0fKzlGy1X85OrtmUrvEbhSo6HP+FoeunHkIqrxu3w3vDoFEXxVQlKI6V3I4nCz5n6DB8WR3L7nsiiTnOiGirPw1ngvWFLW86kkA4FJpayc8Xl3va3SLY+2y4yuROboX2DVI4AC/Qeug/mDiBicPxkP6YfUartQRMe6obkEQARAQABiQE8BBgBCAAmAhsMFiEEOELC4Uw1Jeb66YE6RVeGAwR4zcEFAlz4QRsFCRLMEecACgkQRVeGAwR4zcE56ggAgTgrJInBKC+7552Dpccuo6Clh3wZfjlNLv9/6r5lKEbaNzaTrfhPiAP4WgnluIUmj8amOFLFJpj+BAVNOXpZ4D2R3o9ch8z7fot+fW4Yw+PKIxH4I2xEys8ndoEB3aiQwHjKcGIhkIU7uyMJFQr2aWjdTY0gmXw0YZueHOSLgo7uX4XKxB8fEO/yto/Tff2YBAAq+AtNwt+Gh5YS9rZw7rwUTWMi84yVOlc+zRE79E9NJkvdTwX7IJYo64VzIRNfgHsn7QNdVzuM1XIFHl+Glk6cIlI8s6BO7nEoCn3hTF104fQTAO3fEs+XXZOKXo2lk8faowEoPq5r58StrV0nyg== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.2 MIME-Version: 1.0 Feedback-ID: rr080112282cc37b3e39ec820503abfe220000b5c507a35b4c78a45e5ed9d4c6cfb39b766435158706f9bb63ba:zu080112263fb0f785b708532a0549b0d20000de626540a222c73898cdd8c2eaa365dc0efe5dbec274a144:rf08011232331ba20a6fa6b3116dac349c00007d309ad37653cb3f63f4d0b75b38e7d75a830241687c03f0878c2edebb0390d045abf31d:ZohoMail X-ZohoMailClient: External X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: David: Ping in case you missed this patch. On Sat, 2023-02-11 at 17:37 -0800, Andrew Pinski wrote: > On Sat, Feb 11, 2023 at 4:31 PM Antoni Boucher via Gcc-patches > wrote: > >=20 > > Hi. > > This patch adds support for machine-dependent builtins in libgccjit > > (bug 108762). > >=20 > > There are two things I don't like in this patch: > >=20 > > =C2=A01. There are a few functions copied from the C frontend > > (common_mark_addressable_vec and a few others). > >=20 > > =C2=A02. Getting a target builtin only works from the second compilatio= n > > since the type information is recorded at the first compilation. I > > couldn't find a way to get the builtin data without using the > > langhook. > > It is necessary to get the type information for type checking and > > instrospection. > >=20 > > Any idea how to fix these issues? >=20 > Seems like you should do this patch in a few steps; that is split it > up. > Definitely split out GCC_JIT_TYPE_BFLOAT16 support. > I also think the vector support should be in a different patch too. >=20 > Splitting out these parts would definitely make it easier for review > and make incremental improvements. >=20 > Thanks, > Andrew Pinski >=20 >=20 >=20 > >=20 > > Thanks for the review.