public inbox for jit@gcc.gnu.org
 help / color / mirror / Atom feed
From: David Malcolm <dmalcolm@redhat.com>
To: Antoni Boucher <bouanto@zoho.com>,
	jit@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] libgccjit: Make is_int return false on vector types
Date: Fri, 08 Dec 2023 07:14:00 -0500	[thread overview]
Message-ID: <6be9787f47b6ee75254aa7e5028dcdec1c679842.camel@redhat.com> (raw)
In-Reply-To: <c95b8c7d6e44670d2fd38f0f28383e852d1034c8.camel@zoho.com>

On Thu, 2023-12-07 at 20:09 -0500, Antoni Boucher wrote:
> Can I merge this on master even though we're not in phase 1 anymore?

Yes, assuming it passes the regression testsuite.

> 
> On Thu, 2023-12-07 at 20:07 -0500, David Malcolm wrote:
> > On Thu, 2023-12-07 at 17:32 -0500, Antoni Boucher wrote:
> > > Hi.
> > > This patch changes the function is_int to return false on vector
> > > types.
> > > Thanks for the review.
> > 
> > Thanks; looks good to me
> > 
> > Dave
> > 
> 


      reply	other threads:[~2023-12-08 12:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-07 22:32 Antoni Boucher
2023-12-08  1:07 ` David Malcolm
2023-12-08  1:09   ` Antoni Boucher
2023-12-08 12:14     ` David Malcolm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6be9787f47b6ee75254aa7e5028dcdec1c679842.camel@redhat.com \
    --to=dmalcolm@redhat.com \
    --cc=bouanto@zoho.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jit@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).