From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 2AB8F3861887 for ; Wed, 10 Jan 2024 23:36:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2AB8F3861887 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2AB8F3861887 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704929773; cv=none; b=mY/T3lHK74xYX+I7wMlVHKiSC21nveMz+84V0MoFPjBRWBVuYs+ooL3eerLM2VCWialAcEqMnM2YUKg/s7oz1i5qq+w5VpVJBGhD6yf7bMpu9kbeTczDdLEYNu/Yq2IQxHMXpLrMQaLu3nEYghpDMtWgp7bajNQY/in4YmmvePY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704929773; c=relaxed/simple; bh=2i/Y/YIxOu3SJKS0zaM+lW37Yz7jw4tGIObB5ObVdBs=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=t7ei1LreyWdZHDaZfbetI6j5mpv9j3yenDMNeO/pXQUj/x6lV9qTXdh5o/dplK0mONNygKDfx9xEduh2OUovP57hpmAlTAMcHTSZ6M7PnayzENSj8fu3ddTRXDHr90fpZ59JYGCf580AMwZb0oTZ1hYrkZ/9kvMbv9SQExl9/1E= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704929771; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hB5VKfk0VzPWO0k90s1wLOusxykfrWWaP4vqBi/+sbU=; b=O2VKOTEaLgsjUYQ9ZzwFX8YSvgxR1x5kfPrIP2M4RVVEZYMI65YwjdtDrqy7/QcJEMRu5A wTd1TUuV/5NWlkZ3b9WcYI9iLV7MTtGUbZ34zmdSEGFfPYuLmpE8LraysQ1yboTYQNTGeB /PoeSRe4aYpof5aLtCFFWYw5xnSRGkA= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-42-i3Fl8KS2N5WVhor9kOufEQ-1; Wed, 10 Jan 2024 18:36:10 -0500 X-MC-Unique: i3Fl8KS2N5WVhor9kOufEQ-1 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-78335ae3fa8so124095885a.3 for ; Wed, 10 Jan 2024 15:36:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704929770; x=1705534570; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hB5VKfk0VzPWO0k90s1wLOusxykfrWWaP4vqBi/+sbU=; b=dSGPuoHy5X1wstkyUv7wnRe17P7QjUB4jXPDXtSklL5+FuJRMS0s2nLtIe+kziMcTN 3WxcCHTTU9/pv4Gunzenmxgj9BbXOvFkPAFY5J8G6sVRLlsi+BO6RAK6NcddJuMI2A4F a+TAWCfI6fXzPMAu9gA5cIZo6bbW5wE0rESDFcZj6kXUw6C6Ea4TFkiaQ0La6XkE68qb UUslVmHUIXsohrbSyaOypYRfEAuqvXkwlme9tP0UQFHk321w6esf/ydZfUPy2deh8bEr X63gKkPsdigO2npGMV4zyocIS1NN7bWChLPiaCtkVgC1fzHzKS2YJVBrEOorgRiRhbHS 98WQ== X-Gm-Message-State: AOJu0YywttL4oktMKRMldrtQHFQMLeUyHxInphQ+ldAAcrV0txfKGMjm d/kr/UBQrmUkUg5G7scXMjaN53m46DXWGLBIaI9CUefgYHSb8kH+EVT75eCDhQ47b+rU1tIDxHd rkL5izzOaSJWb/pKsno9cT54= X-Received: by 2002:a05:620a:318c:b0:783:1a1c:2e32 with SMTP id bi12-20020a05620a318c00b007831a1c2e32mr494506qkb.137.1704929769834; Wed, 10 Jan 2024 15:36:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IFD1D4dmkTxhWBBDTNkMJIhL51nWQBT0U0+UB6ZjK9MzzVElXyMIDw94JuI6AMvsclCBmOw2g== X-Received: by 2002:a05:620a:318c:b0:783:1a1c:2e32 with SMTP id bi12-20020a05620a318c00b007831a1c2e32mr494498qkb.137.1704929769574; Wed, 10 Jan 2024 15:36:09 -0800 (PST) Received: from t14s.localdomain (c-76-28-97-5.hsd1.ma.comcast.net. [76.28.97.5]) by smtp.gmail.com with ESMTPSA id dt15-20020a05620a478f00b0077f435ed844sm1954607qkb.112.2024.01.10.15.36.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 15:36:09 -0800 (PST) Message-ID: <6c330fa1220dde767cacd055a644788cebe4ca83.camel@redhat.com> Subject: Re: [PATCH] libgccjit: Implement sizeof operator From: David Malcolm To: Antoni Boucher , "jit@gcc.gnu.org" , "gcc-patches@gcc.gnu.org" Date: Wed, 10 Jan 2024 18:36:08 -0500 In-Reply-To: References: <8d25e331b0c28ca9b632bf3fb3a239661592af78.camel@zoho.com> <182093b9cbbce78d6c77d70feeff80d1b076ffcd.camel@redhat.com> User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 2024-01-10 at 17:38 -0500, Antoni Boucher wrote: > On Tue, 2024-01-09 at 11:33 -0500, David Malcolm wrote: > > On Fri, 2023-12-22 at 10:25 -0500, Antoni Boucher wrote: > > > Hi. > > > This patch adds the support of the sizeof operator. > > > I was wondering if this new API entrypoint should take a location > > > as > > > a > > > parameter. What do you think? > >=20 > > I'd prefer it if it did (even if it's currently ignored > > internally), > > but it's not a big deal. >=20 > The reason it doesn't have a location is because it directly produces > a > constant, rather like gcc_jit_context_new_rvalue_from_int, which > doesn't have a location either. > So, I wanted to confirm that you think it's needed to have a > location. Fair enough; it's not needed. >=20 > Also, I realized I misnamed memento_of_new_sizeof and will rename it > to > memento_of_sizeof. Ah, ok. Fixing that is preapproved, though make sure it still builds and test it a little before pushing! Please also doublecheck the ABI version numbers, since they inevitably tend to get out of sync on branches. Dave >=20 > >=20 > > > Thanks for the review. > >=20 > > The patch is OK as-is. > >=20 > > Thanks > > Dave > >=20 >=20