From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 967073858C20 for ; Mon, 31 Jan 2022 14:57:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 967073858C20 Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-180-DaLwug7iOf2DebAL2GHu1A-1; Mon, 31 Jan 2022 09:57:50 -0500 X-MC-Unique: DaLwug7iOf2DebAL2GHu1A-1 Received: by mail-qk1-f197.google.com with SMTP id p20-20020a05620a22b400b0047ecab0db4fso9846472qkh.2 for ; Mon, 31 Jan 2022 06:57:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=uX1CKxM5m9IN1KNe4uD5RcuJVoYAmi5bfVnEUbRkrUI=; b=yQli5IBeSxw5XUsILs7gEGzc1zCUmmK+2qcwr3AMHt9z0ibMXSsnibwes/imyhvsbW svVEKpmAbWm9u0D8DzWwKOBl2QxL5anpSaVQ+wqNGeobCH4YiGNetl86mYAatQefkbQM yWvSedIkS0HtjGjhlazk+n3VWbuX2lnz+RvMLWq24NxyKttTPTdjQc+NNi5qvVRzaj/Y xPd+S5mHdddiEN1NXF781gaG7s+gb5on3qHIB8Tpj6mTZduiPiFHdGqw0SN4S0sETm/y qg4Pi+munUXelvny4gvi9s4a2meoiU+Nq7izYlyVZgEi2JJltM2kCyrJCFMvaIhWKw0R M3eA== X-Gm-Message-State: AOAM532M9e1cDZal1Cd8HRDJ/XB/Qk3JJoFnszB3Xmk/W0QpgKrzTFpC bww+HLNXt1JvYz1KyJCilGh/TQUEUTqhgCBpV2tX41XVG2QMiYTpOwsd8hPdkUk2SqSU/86F7J7 Cq/ROL58= X-Received: by 2002:a05:622a:50a:: with SMTP id l10mr6614136qtx.679.1643641069809; Mon, 31 Jan 2022 06:57:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJwf1GOKYrZH6XqRCHHgOUy1Drk+N6FHTnp61SwX1Uoeur5fRtQw9grPanf+5DdaaP7CnBH9lw== X-Received: by 2002:a05:622a:50a:: with SMTP id l10mr6614128qtx.679.1643641069630; Mon, 31 Jan 2022 06:57:49 -0800 (PST) Received: from t14s.localdomain (c-73-69-212-193.hsd1.ma.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id s7sm8965525qki.20.2022.01.31.06.57.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 06:57:49 -0800 (PST) Message-ID: <6c9e4de75b2ec8776e25ea5f01c0b5276ae09746.camel@redhat.com> Subject: Re: C++ API: Union types are missing From: David Malcolm To: Marc =?ISO-8859-1?Q?Nieper-Wi=DFkirchen?= , Marc =?ISO-8859-1?Q?Nieper-Wi=DFkirchen?= via Jit Date: Mon, 31 Jan 2022 09:57:48 -0500 In-Reply-To: References: User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: jit@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Jit mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jan 2022 14:57:56 -0000 On Sun, 2022-01-30 at 20:34 +0100, Marc Nieper-Wißkirchen wrote: > The C++ analog for gcc_jit_context_new_union_type is missing in > libgccjit++.h. > > I can send a patch adding it and anything else I may find missing as > well. Yes please; ideally with test coverage. > Dave, as only one header file is concerned, would a single patch be > okay? I > hope it could still make it into GCC 12 as no component outside of the > file > would be touched. It's technically something I ought to ask permission for from the release managers given that the rest of gcc 12 is in deep feature freeze, but I think there's a good case for this - especially if the patch has test coverage (if nothing else, I've found that it's impossible to gauge how good an API is without writing code to consume that API). Please send patches for libgccjit to both the jit mailing list and the gcc-patches mailing list (and ensure the title has "jit" in it), and indicate what testing you've done. [1] Thanks Dave [1] https://gcc.gnu.org/onlinedocs/jit/internals/index.html#submitting-patches has more notes on patches, fwiw (perhaps too much)