From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dmalcolm@redhat.com>
Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com
 [207.211.31.81])
 by sourceware.org (Postfix) with ESMTP id 43D10385DC16
 for <jit@gcc.gnu.org>; Tue, 31 Mar 2020 17:34:04 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 43D10385DC16
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-287-DLv-YY52Ob-Q1RF57c3Spw-1; Tue, 31 Mar 2020 13:34:00 -0400
X-MC-Unique: DLv-YY52Ob-Q1RF57c3Spw-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com
 [10.5.11.15])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 37DFA8017CE;
 Tue, 31 Mar 2020 17:33:59 +0000 (UTC)
Received: from ovpn-112-87.phx2.redhat.com (ovpn-112-87.phx2.redhat.com
 [10.3.112.87])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 41C17176C2;
 Tue, 31 Mar 2020 17:33:58 +0000 (UTC)
Message-ID: <6d444a8da8e5b7a83ef5a8f2c243e4a639d111dd.camel@redhat.com>
Subject: Re: [PATCH V4][gcc] libgccjit: introduce version entry points
From: David Malcolm <dmalcolm@redhat.com>
To: Andrea Corallo <andrea.corallo@arm.com>
Cc: "jit@gcc.gnu.org" <jit@gcc.gnu.org>, nd <nd@arm.com>, 
 gcc-patches@gcc.gnu.org
Date: Tue, 31 Mar 2020 13:33:56 -0400
In-Reply-To: <gkrlfngybj3.fsf_-_@arm.com>
References: <gkrd0bjlkpt.fsf@arm.com> <gkrmu8d8efb.fsf@arm.com>
 <330ed10fb3e66abdbc5d30fdf2ba2fd3c3b30cf6.camel@redhat.com>
 <878sjivr6m.fsf@arm.com> <gkrlfngybj3.fsf_-_@arm.com>
User-Agent: Evolution 3.32.5 (3.32.5-1.fc30)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-15.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=unavailable autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: jit@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Jit mailing list <jit.gcc.gnu.org>
List-Unsubscribe: <http://gcc.gnu.org/mailman/options/jit>,
 <mailto:jit-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <http://gcc.gnu.org/pipermail/jit/>
List-Help: <mailto:jit-request@gcc.gnu.org?subject=help>
List-Subscribe: <http://gcc.gnu.org/mailman/listinfo/jit>,
 <mailto:jit-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Mar 2020 17:34:05 -0000

On Tue, 2020-03-31 at 14:05 +0200, Andrea Corallo wrote:
> Hi all,
> 
> Updated version of the patch addressing last comments.

Thanks.

> Regression clean, okay to apply?

OK

> Bests
> 
>   Andrea
> 
> gcc/jit/ChangeLog
> 2020-??-??  Andrea Corallo  <andrea.corallo@arm.com>
> 	    David Malcolm  <dmalcolm@redhat.com>
> 
> 	* docs/topics/compatibility.rst (LIBGCCJIT_ABI_13): New ABI tag
> 	plus add version paragraph.
> 	* libgccjit++.h (namespace gccjit::version): Add new namespace.
> 	* libgccjit.c (gcc_jit_version_major, gcc_jit_version_minor)
> 	(gcc_jit_version_patchlevel): New functions.
> 	* libgccjit.h (LIBGCCJIT_HAVE_gcc_jit_version): New macro.
> 	(gcc_jit_version_major, gcc_jit_version_minor)
> 	(gcc_jit_version_patchlevel): New functions.
> 	* libgccjit.map (LIBGCCJIT_ABI_13) New ABI tag.
> 
> gcc/testsuite/ChangeLog
> 2020-??-??  Andrea Corallo  <andrea.corallo@arm.com>
> 
> 	* jit.dg/test-version.c: New testcase.
> 	* jit.dg/all-non-failing-tests.h: Add test-version.c.