From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id A9E4D385514E for ; Thu, 1 Dec 2022 15:25:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A9E4D385514E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669908314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=akJ3rKv29FmSC5mkpLjx2cx0yzVDwzC9NkFq3rKhkRc=; b=eoEuETdt6tPt9XERvL6Z1NPoAgYZ92KxuarDh+jzfiP5C05ep+GUXPDIOr5onq0KDbmYRh dYNmKN07wGyqgkKyLnMRUrzNT76YCG/Qgfvo1TmTnN7ofKXAOjHjLumzeyUcolnd1R1/mf 1I2KBuVdZB5RHLYwfthaChfiFL7eKpw= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-653-69PuEyfPMuqLSoaWoJHQRQ-1; Thu, 01 Dec 2022 10:25:13 -0500 X-MC-Unique: 69PuEyfPMuqLSoaWoJHQRQ-1 Received: by mail-qk1-f198.google.com with SMTP id q20-20020a05620a0d9400b006fcaa1eac9bso4255391qkl.23 for ; Thu, 01 Dec 2022 07:25:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=akJ3rKv29FmSC5mkpLjx2cx0yzVDwzC9NkFq3rKhkRc=; b=W1Pjl4Zd6Zlj+yRDggYONeXCKyQEDYqZt2j8qQBhtIQSoutUyayZI5SitZwFAjqwow 5wg1qwaVArCgcjGZJm+3NrH6Q93tR5hnA2mAEw/Tr1pu1bKaIP3pQDmQm56Fn7TUWJHn c9yJ8AkEWw/MhEWwhE8GtWCtqzezZdxawJBrZ3yyz8MG/7pzOYV/JOYOpF7PNbr3ncPX 0KhdlvhRJqrNFnwWwk8uoKVTS8Z/jwvzMn/uP+JsGWONtZBl6hdo001YCVEUbQh5XMPZ 2B1q8VdKm8MYOG8/ADKseQ3WCwRrs0NcaI5r0hrsDJlxsEs0oyh8R3PhuAl5rLKvLuG1 0PYg== X-Gm-Message-State: ANoB5pmoGFmcfPqaC0ScHS0+AnQJfE+MaDkCnHRXFPbaBPrpMR1C7AOP peU3LUFnKo4QshqoeR7+5rqex8OkViOm1gRVdQVSLVuv0vo/xIuVW1zP0M75IaujaZ9W2G8+Ccp P9F+Hsq4= X-Received: by 2002:ac8:5145:0:b0:3a5:4544:a46e with SMTP id h5-20020ac85145000000b003a54544a46emr50013733qtn.305.1669908312672; Thu, 01 Dec 2022 07:25:12 -0800 (PST) X-Google-Smtp-Source: AA0mqf5o9yPZ/ZaF0pn6INU/r3vWDfcqLMMsqw2rTVGyRCAGKg6up4YlBBD1zoAxMSCC/7Tgamt+Qw== X-Received: by 2002:ac8:5145:0:b0:3a5:4544:a46e with SMTP id h5-20020ac85145000000b003a54544a46emr50013720qtn.305.1669908312479; Thu, 01 Dec 2022 07:25:12 -0800 (PST) Received: from t14s.localdomain (c-73-69-212-193.hsd1.nh.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id n14-20020a05620a294e00b006fbae4a5f59sm3753573qkp.41.2022.12.01.07.25.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 07:25:12 -0800 (PST) Message-ID: <74150b934836583a532d310c68d29384daf2fbd0.camel@redhat.com> Subject: Re: [PATCH] libgccjit: Fix float vector comparison From: David Malcolm To: Antoni Boucher , gcc-patches@gcc.gnu.org, jit@gcc.gnu.org Cc: Guillaume Gomez Date: Thu, 01 Dec 2022 10:25:11 -0500 In-Reply-To: <15fbee19972751bfa05c24ec95bc441c621c98ad.camel@zoho.com> References: <30eb27a08792e1e2b92e663753f22e31f65c7791.camel@redhat.com> <15fbee19972751bfa05c24ec95bc441c621c98ad.camel@zoho.com> User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 2022-12-01 at 10:01 -0500, Antoni Boucher wrote: > Thanks, David. > Since we're not in phase 1 anymore, do we need an approval before I > merge like last year or can I merge immediately? I think it counts as a bug fix and thus you can go ahead and merge (assuming you've done the usual testing). > I also have many other patches (all in jit) that I need to prepare > and > post to this mailing list. > What do you think? Given that you're one of the main users of libgccjit I think there's a case for stretching the deadlines a bit here. Do you have a repo I can look at? Dave >=20 > On Thu, 2022-12-01 at 09:28 -0500, David Malcolm wrote: > > On Sun, 2022-11-20 at 14:03 -0500, Antoni Boucher via Jit wrote: > > > Hi. > > > This fixes bug 107770. > > > Thanks for the review. > >=20 > > Thanks, the patch looks good to me. > >=20 > > Dave > >=20 >=20