From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by sourceware.org (Postfix) with ESMTPS id 08AC13858D28; Fri, 17 Nov 2023 21:06:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 08AC13858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 08AC13858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::430 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700255211; cv=none; b=D2qNzEi4oINtOMhgo9WoziUlT96oHss8cqpqEYoE1i5SBRz6NhBQNZPL/vWuPz7tVMoE9vEJBU8/XwBM95mNSWCopAlwN3s61iE+mc4h0IEBbTE+YExhwg04j7l6vEL7Te/8Hu/J20DxndTfDyEIb28KjSM+zQisi8mX0m8m6tQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700255211; c=relaxed/simple; bh=GWg/CArwwZIT8qJKK+I71gzYUDZlSUixgf2xY7lTzmQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=XfBiadM8vFIHbMUFyjELvqgvJTyILVv9fP/WAvp5hmf7X5o5oiU/QPyx4CXCXp3baPuCmGvaD6MqQ3zblkgWaaHT9DcW1ekAM9sF6eQHEyyvkU2qgc61x7hRvskzLQls/YFWqd7ZnlhSo9j8gWoRlGZ9wdzIslnq/7cqXFjAnhM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-6c398717726so2249009b3a.2; Fri, 17 Nov 2023 13:06:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700255207; x=1700860007; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KPY9UnWV+wVSOkgc0mHkgHtPnDnAIYTDmoCNObFkxWc=; b=krW8cgKIPMMAsu9bvYkASTQeEukfFHU/gEwFU4juR5ABZwDpc/Xm+KpFeACipB150W XxRPIudhncMC9jU+4uzg9/hewTpJETHj1rhqbO7g6Pem53Q6LsXOqdamm06tmtdl0ScT i02p4hzvwOhOBJUUvtsI5jaEXOcZbLMFCLIad84OxWKxMYLv3c/AxwvqI0ncDO7bCuES GGvnxEO4pe+Y3wkFE9qan8b+NeDe3SJ7wuFCOqjNat0MCEZIW799/MCTweuAoa9Dx1P0 NJEkpV7kJF/JUY/jt8/DcwSTflALzdfQ6pKNO36eK7o5OiNPtmWWA6PcTeKpBZO9lDGi cT0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700255207; x=1700860007; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KPY9UnWV+wVSOkgc0mHkgHtPnDnAIYTDmoCNObFkxWc=; b=dqRTgKempnNA6z5Yvq3A2gY/3Ae7pJ6/uW+1u1CZU/7Rzuty0D3G3x/UHzXf3QuOPZ 22Vn7blAdurwjs/d+lTAIRWnddDqloJH3eosA1bckrpavqI1YtSZPZl1I1Io2gnA3SFd YNL5EON+DpIcMme19uV2E5PD/sTk9xaaUCoHZ1+xo9b8YZJ25FCRVLt2jI6cE6cT6/yx dV0UAhTWD8Eu3YcE0RrtHJ+AGoqw7bSvaM9S+GbPLREBH+qQvYDxC8ey4ssFudvsU7q9 Q6Y336Bi7MZFh8AAc+L9Imzab9wih1VMk0fG91Ab+nVKLRwazpZzHqa+r3eKcrFO5SmA HGKg== X-Gm-Message-State: AOJu0Ywdqqn/+NBheyojlgBYy5Aax0Pet9qVymSPTLFeBEtz9zTBtsby +xCikpjrKOBnOWMeJnPE6Dc= X-Google-Smtp-Source: AGHT+IG8ComlQtbvl3pRSKvIFBdFkoCPSARYFhoaKojoQ8ctO84QPPPdfU39IP5IVnXpg3gM8PQhjA== X-Received: by 2002:a05:6a20:c901:b0:187:ab4:19b9 with SMTP id gx1-20020a056a20c90100b001870ab419b9mr342108pzb.35.1700255206781; Fri, 17 Nov 2023 13:06:46 -0800 (PST) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id l62-20020a639141000000b00584aff3060dsm1836572pge.59.2023.11.17.13.06.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Nov 2023 13:06:45 -0800 (PST) Message-ID: <7c598b42-f866-4661-8682-818e7e7bbccf@gmail.com> Date: Fri, 17 Nov 2023 14:06:40 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] libgccjit Fix a RTL bug for libgccjit Content-Language: en-US To: Antoni Boucher , jit@gcc.gnu.org, gcc-patches@gcc.gnu.org Cc: David Malcolm References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/16/23 15:36, Antoni Boucher wrote: > Hi. > This patch fixes a RTL bug when using some target-specific builtins in > libgccjit (bug 112576). > > The test use a function from an unmerged patch: > https://gcc.gnu.org/pipermail/jit/2023q1/001605.html > > Thanks for the review! The natural question here is why does libgccjit call init_emit_once more than one time? The whole point of that routine is doing one time initializations. It's not supposed to be called more than once. David? Thoughts here? jeff