public inbox for jit@gcc.gnu.org
 help / color / mirror / Atom feed
From: David Malcolm <dmalcolm@redhat.com>
To: Antoni Boucher <bouanto@zoho.com>,
	gcc-patches@gcc.gnu.org, jit@gcc.gnu.org
Subject: Re: [PATCH] libgccjit: Fix bug where unary_op will return an integer type instead of the correct type
Date: Tue, 28 Jun 2022 18:40:22 -0400	[thread overview]
Message-ID: <7f2ff95927e7dc1b6e48aaf5b1753180eaecfa64.camel@redhat.com> (raw)
In-Reply-To: <c6f0859d4c7b6bdfc580dcea0e40955bdf7eecdf.camel@zoho.com>

On Wed, 2022-06-01 at 22:45 -0400, Antoni Boucher via Gcc-patches
wrote:
> Also, the test gcc/testsuite/jit.dg/test-asm.cc fails and would need
> this line:
> 
> #include <stdint.h>

I'm curious; how is it failing?

> 
> Is this okay if I add it in this patch?
> 
> On Wed, 2022-06-01 at 22:13 -0400, Antoni Boucher wrote:
> > Hi.
> > The attached patch fix bug 105812:
> > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105812
> > 
> > I'm having an issue where contrib/check_GNU_style.sh doesn't seem
> > to
> > work, i.e. it doesn't seem to do any checking.
> > Is there a new way to do that or am I missing something?
> > 
> > Thanks for the review.
> 



  parent reply	other threads:[~2022-06-28 22:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-02  2:13 Antoni Boucher
2022-06-02  2:45 ` Antoni Boucher
2022-06-25 15:01   ` Antoni Boucher
2022-06-28 22:40   ` David Malcolm [this message]
2022-06-29 13:44     ` Antoni Boucher
2022-06-29 13:51       ` David Malcolm
2022-06-28 22:39 ` David Malcolm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7f2ff95927e7dc1b6e48aaf5b1753180eaecfa64.camel@redhat.com \
    --to=dmalcolm@redhat.com \
    --cc=bouanto@zoho.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jit@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).