From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 4B57F3856253 for ; Tue, 28 Jun 2022 22:40:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4B57F3856253 Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-214-gZ3RiRJUPvSaO6tRyVf6DQ-1; Tue, 28 Jun 2022 18:40:24 -0400 X-MC-Unique: gZ3RiRJUPvSaO6tRyVf6DQ-1 Received: by mail-qv1-f69.google.com with SMTP id s14-20020ad4438e000000b0047084e1931dso13679279qvr.3 for ; Tue, 28 Jun 2022 15:40:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=WWWxkkRYUTk+H6FLbK2Roc5/unOJIFCbgS2hHhbDz80=; b=wJxT0vl5DDxsQYIUHxAddBrX5mjlvcfUtciadKpsZP6qlRNCGrwd4O5efYfxCQkWz1 /ekprD8/xR0WhY7x+DWAfgQb+qr3Dm0MpPJ63SNckz0H9Yb2EsuHb4vdOcEWTbXtf6Rv tSnb8fSnvKs5ehFn5v2vkePWgo5hEyND4Xvd1s4N4zHW3Le9uebzens7HCcelDw5/md7 +j2ybGUqkMvMf3xein+1aOdvd4tbGYix3hufa553ZepCvTInddJE5suqRWAgFQo0HQqP FVHdn/CZQHZjJ0Myh9CmxttbC6s10LYUF7LHCCp8sETpxGYKC1Wocx3YjWG5PakKQ3ZB Hs0g== X-Gm-Message-State: AJIora+R5qVkt7ubSpsRAXkc42zeyjDWgjFXi3AJbXisSe3dF1l3AFQM 0nI7Yg/gh6218t/GcZ+WsynpQvCeO7AlGlnA42wJ6FnpLxsLhKrfpCgP327UEZlWjw5NP0DmYeT 4zLS9gLo= X-Received: by 2002:a05:620a:4414:b0:6ae:f4b2:e25e with SMTP id v20-20020a05620a441400b006aef4b2e25emr168720qkp.12.1656456024172; Tue, 28 Jun 2022 15:40:24 -0700 (PDT) X-Google-Smtp-Source: AGRyM1t/6AOnh77cg2Dn+ZjNY8mLNrY6D8rNKg/5PA5rJidfycZMpxywhiN3xQk4xflLdAygWo/zYg== X-Received: by 2002:a05:620a:4414:b0:6ae:f4b2:e25e with SMTP id v20-20020a05620a441400b006aef4b2e25emr168711qkp.12.1656456023932; Tue, 28 Jun 2022 15:40:23 -0700 (PDT) Received: from t14s.localdomain (c-73-69-212-193.hsd1.nh.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id b12-20020a05620a0f8c00b006a34a22bc60sm11577783qkn.9.2022.06.28.15.40.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 15:40:23 -0700 (PDT) Message-ID: <7f2ff95927e7dc1b6e48aaf5b1753180eaecfa64.camel@redhat.com> Subject: Re: [PATCH] libgccjit: Fix bug where unary_op will return an integer type instead of the correct type From: David Malcolm To: Antoni Boucher , gcc-patches@gcc.gnu.org, jit@gcc.gnu.org Date: Tue, 28 Jun 2022 18:40:22 -0400 In-Reply-To: References: User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: jit@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Jit mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2022 22:40:27 -0000 On Wed, 2022-06-01 at 22:45 -0400, Antoni Boucher via Gcc-patches wrote: > Also, the test gcc/testsuite/jit.dg/test-asm.cc fails and would need > this line: > > #include I'm curious; how is it failing? > > Is this okay if I add it in this patch? > > On Wed, 2022-06-01 at 22:13 -0400, Antoni Boucher wrote: > > Hi. > > The attached patch fix bug 105812: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105812 > > > > I'm having an issue where contrib/check_GNU_style.sh doesn't seem > > to > > work, i.e. it doesn't seem to do any checking. > > Is there a new way to do that or am I missing something? > > > > Thanks for the review. >