From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id B2FF7385AE66 for ; Tue, 28 Jun 2022 22:39:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B2FF7385AE66 Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-39-Tm6hi2O1PhOSiErCxV3cRA-1; Tue, 28 Jun 2022 18:39:36 -0400 X-MC-Unique: Tm6hi2O1PhOSiErCxV3cRA-1 Received: by mail-qv1-f72.google.com with SMTP id x18-20020a0ce252000000b004703cbb92ebso13825124qvl.21 for ; Tue, 28 Jun 2022 15:39:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=aoIkGmJcjTL0j4E5SlrtekWcPdhbGTjDT/fexA2QGh8=; b=4rXyfd4hzhM3SbNWUyC5SJh14H6zZOvd1PPjOZgCEE9zPMpIC6quIwwhPz+6Y4F+le 9rN0sEAw3lbOWiwcWNMuysf+uLvK2kNI/gzey6+TorGlQzhdhsqGWOATMNRWnLlsROct lrTMWab3nHbt0GN/rzDFymWlB1LLU6VGdIHNchUGAJOnP83cp3d3A7fpsER8f10kpg5e LP/v9TYcxzb/BvIP1FTbJUGRuWXBzT6ps7ssxbJVcgnJqx1pjNXP2rkA5gHdhsJhHbyv g6Vy6OiAuoCo/aPTxePxdhRA/tkB47rJVe0wkn3lulKNllQZiFGKx3yIO+ULKIIXNotk L6AA== X-Gm-Message-State: AJIora/K7at7sDNrhBqjkCtGBJYM3NhBzdyjJ31tfovmKsxB/1V/gnop eW6rfeGZfJdVqhTM0XTjDnJJgmxTYLQgN8/1V7qafowr7IIsyMNRHBgDtLoUnUncQ4uHktHMmdS qOhp80tU= X-Received: by 2002:a05:622a:192:b0:316:b6fb:488e with SMTP id s18-20020a05622a019200b00316b6fb488emr273619qtw.176.1656455975868; Tue, 28 Jun 2022 15:39:35 -0700 (PDT) X-Google-Smtp-Source: AGRyM1s6Hve5mCFMSD1NSwr1eQinlx1AalwiUrDMEbKZazKT0pjPTOKVTiec4/BOog2hTyT763iGFw== X-Received: by 2002:a05:622a:192:b0:316:b6fb:488e with SMTP id s18-20020a05622a019200b00316b6fb488emr273611qtw.176.1656455975646; Tue, 28 Jun 2022 15:39:35 -0700 (PDT) Received: from t14s.localdomain (c-73-69-212-193.hsd1.nh.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id d71-20020a379b4a000000b006a6a1e4aec2sm11820306qke.49.2022.06.28.15.39.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 15:39:35 -0700 (PDT) Message-ID: <805967e3456c2d94386712b20cc6cc37236c9e0b.camel@redhat.com> Subject: Re: [PATCH] libgccjit: Fix bug where unary_op will return an integer type instead of the correct type From: David Malcolm To: Antoni Boucher , gcc-patches@gcc.gnu.org, jit@gcc.gnu.org Date: Tue, 28 Jun 2022 18:39:33 -0400 In-Reply-To: References: User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: jit@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Jit mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2022 22:39:39 -0000 On Wed, 2022-06-01 at 22:13 -0400, Antoni Boucher via Gcc-patches wrote: > Hi. > The attached patch fix bug 105812: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105812 Thanks; the patch looks good to me, assuming it's been tested in the usual way, with one nit: the "PR target/105812" in the ChangeLog should presuambly be "PR jit/105812". > > I'm having an issue where contrib/check_GNU_style.sh doesn't seem to > work, i.e. it doesn't seem to do any checking. > Is there a new way to do that or am I missing something? I confess I've never actually used that script. Dave