From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [IPv6:2001:470:683e::1]) by sourceware.org (Postfix) with ESMTPS id 7109239DD7C0; Fri, 9 Dec 2022 07:51:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7109239DD7C0 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1670572289; bh=BfLh1C/6uI56R6y9ElTW1hYGH1pfBYOxZRDclYfvVjg=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=i4P37o3mSItGgOpdz/UszIAp6P9LPh3uQfhXjZdm2jkLXmwco46+lvvU4H/vuvIPF jE01qGiDOYB/oPnWv+qGPezE9kSng3ig5ka4MFxJqUD82O557bTXs5H3rgqI9pVqbt P/YaVQOK69XcXxXYnpQqq5UvCuBTLxTm5C9uIsE0= Received: from localhost.localdomain (xry111.site [IPv6:2001:470:683e::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 051C96687B; Fri, 9 Dec 2022 02:51:27 -0500 (EST) Message-ID: <86d0c6e7fd272f598ee7a3c0f1aae7cae66ecd9c.camel@xry111.site> Subject: Re: [PATCH 0/2] LoongArch: respect --with-* and drop loongarch-driver From: Xi Ruoyao To: Icenowy Zheng , gcc-patches@gcc.gnu.org Cc: jit@gcc.gnu.org, Lulu Cheng Date: Fri, 09 Dec 2022 15:51:26 +0800 In-Reply-To: <20221209024349.845948-1-uwu@icenowy.me> References: <20221209024349.845948-1-uwu@icenowy.me> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.0 MIME-Version: 1.0 X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FROM_SUSPICIOUS_NTLD,KAM_SHORT,LIKELY_SPAM_FROM,SPF_HELO_PASS,SPF_PASS,TXREP,T_PDS_OTHER_BAD_TLD autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 2022-12-09 at 10:43 +0800, Icenowy Zheng wrote: > This patchset tries to fix the object duplication between the driver and > the real compiler, which makes libgccjit building fail because of > linking this two parts together. Hmm, I think the issue is already fixed by https://gcc.gnu.org/r13-1010 but maybe I'm wrong here... This looks like a good code clean-up anyway. But if libgccjit builds fine with GCC trunk I'd postpone the clean-up to GCC 14 stage 1. > First, the build-time --with-* values are now respected by being the > default -m* values in the driver, and then loongarch-driver, which is > mostly doing no-op now, is dropped. >=20 > This patchset is bootstrapped on a native LoongArch device (without > any > --with-* flags). In addition, on a x86 device, cross compilers are > built > with --with-{arch,abi} and without any --with-* flags; all these > configurations can correctly build all supported shipped libraries > with > GCC. >=20 > Icenowy Zheng (2): > =C2=A0 LoongArch: respect the with values in config.gcc > =C2=A0 LoongArch: drop loongarch-driver >=20 > =C2=A0gcc/config.gcc=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 1 - > =C2=A0gcc/config/loongarch/loongarch-driver.cc | 187 --------------------= -- > - > =C2=A0gcc/config/loongarch/loongarch-driver.h=C2=A0 |=C2=A0 68 --------- > =C2=A0gcc/config/loongarch/loongarch.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 |=C2=A0 21 ++- > =C2=A04 files changed, 19 insertions(+), 258 deletions(-) > =C2=A0delete mode 100644 gcc/config/loongarch/loongarch-driver.cc > =C2=A0delete mode 100644 gcc/config/loongarch/loongarch-driver.h >=20 --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University