From: Andrea Corallo <andrea.corallo@arm.com>
To: David Malcolm <dmalcolm@redhat.com>
Cc: gcc-patches@gcc.gnu.org, "jit@gcc.gnu.org" <jit@gcc.gnu.org>,
nd <nd@arm.com>
Subject: Re: [PATCH V3][gcc] libgccjit: introduce version entry points
Date: Sun, 29 Mar 2020 21:31:29 +0100 [thread overview]
Message-ID: <878sjivr6m.fsf@arm.com> (raw)
In-Reply-To: <330ed10fb3e66abdbc5d30fdf2ba2fd3c3b30cf6.camel@redhat.com> (David Malcolm's message of "Fri, 20 Mar 2020 21:32:05 -0400")
David Malcolm <dmalcolm@redhat.com> writes:
> On Wed, 2020-03-18 at 23:51 +0100, Andrea Corallo wrote:
> Please add the new test to the header in its alphabetical location,
> i.e. between:
>
> /* test-vector-types.cc: We don't use this, since it's C++. */
>
> and
>
> /* test-volatile.c */
>
> An entry also needs to be added to the "testcases" array at the end of
> the header (again, in the alphabetical-sorted location).
I tried adding the test into the "testcases" array but this makes the
threads test failing.
I think this has nothing to do with this patch and happen just because
this test does not define any code. Infact I see the same happening
just adding "test-empty.c" to the "testcases" array on the current
master.
The error is not very reproducible, I tried a run under valgrind but
have found nothing so far :/
Dave do you recall if there was a specific reason not to have
"test-empty.c" into the "testcases" array?
Andrea
next prev parent reply other threads:[~2020-03-29 20:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-01 0:00 [PATCH][gcc] " Andrea Corallo
2020-01-01 0:00 ` David Malcolm
2020-01-01 0:00 ` David Malcolm
2020-03-08 14:08 ` Andrea Corallo
2020-01-01 0:00 ` Florian Weimer
2020-01-01 0:00 ` Andrea Corallo
2020-03-18 22:51 ` [PATCH V3][gcc] " Andrea Corallo
2020-03-21 1:32 ` David Malcolm
2020-03-23 13:03 ` Richard Biener
2020-03-29 20:31 ` Andrea Corallo [this message]
2020-03-30 16:09 ` David Malcolm
2020-03-31 1:13 ` David Malcolm
2020-03-31 8:03 ` Andrea Corallo
2020-03-31 12:05 ` [PATCH V4][gcc] " Andrea Corallo
2020-03-31 17:33 ` David Malcolm
2020-03-31 19:00 ` Andrea Corallo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878sjivr6m.fsf@arm.com \
--to=andrea.corallo@arm.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jit@gcc.gnu.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).