From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79755 invoked by alias); 6 Mar 2020 08:08:10 -0000 Mailing-List: contact jit-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: Sender: jit-owner@gcc.gnu.org Received: (qmail 79739 invoked by uid 89); 6 Mar 2020 08:08:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-7.3 required=5.0 tests=AWL,BAYES_00,FORGED_SPF_HELO,MSGID_FROM_MTA_HEADER,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,UNPARSEABLE_RELAY autolearn=no version=3.3.1 spammy= X-Spam-Status: No, score=-7.3 required=5.0 tests=AWL,BAYES_00,FORGED_SPF_HELO,MSGID_FROM_MTA_HEADER,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,UNPARSEABLE_RELAY autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-Spam-User: qpsmtpd, 2 recipients X-HELO: EUR05-DB8-obe.outbound.protection.outlook.com Received: from mail-db8eur05on2067.outbound.protection.outlook.com (HELO EUR05-DB8-obe.outbound.protection.outlook.com) (40.107.20.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Mar 2020 08:08:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ThVNWM9DRdGsvwJd0RESH8peZY3os+tCGjPs/q3bBrA=; b=0G42w22d2tAZRcOdUflX2I+WOmta/BIPGNL1BTKbIWNAZhhgXYqNPsL0p33aqs3ExIOsUU44Twayprxb8RC5p8V1g5S49u289wjKUWTEyJutJDokrF9ro7XKMfKYVRdj2q41OZ55W4cPIBB/MNWzdi/eHBUQe3lqw+j42rIvzdk= Received: from AM3PR07CA0120.eurprd07.prod.outlook.com (2603:10a6:207:7::30) by DB6PR0802MB2135.eurprd08.prod.outlook.com (2603:10a6:4:82::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.15; Fri, 6 Mar 2020 08:08:06 +0000 Received: from AM5EUR03FT011.eop-EUR03.prod.protection.outlook.com (2603:10a6:207:7:cafe::ea) by AM3PR07CA0120.outlook.office365.com (2603:10a6:207:7::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.6 via Frontend Transport; Fri, 6 Mar 2020 08:08:06 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;gcc.gnu.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT011.mail.protection.outlook.com (10.152.16.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2793.11 via Frontend Transport; Fri, 6 Mar 2020 08:08:06 +0000 Received: ("Tessian outbound 62d9cfe08e54:v42"); Fri, 06 Mar 2020 08:08:06 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 1913a4943e835857 X-CR-MTA-TID: 64aa7808 Received: from f7b747cb9d39.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9E5E9BDE-94C6-4DF7-B3D9-C65B12B90DE7.1; Fri, 06 Mar 2020 08:08:00 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f7b747cb9d39.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 06 Mar 2020 08:08:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AyzksuN+a3hEZH7vIAxsQHfbpt+OHTtK9Prbf5RXHPIrcro6o5pi8e5iSwnjlpWHMyThxvm/10wuviC2BmSu9g5hcAcELRYFdP8SshaOxZ4Vu8dRjjr2thnYpzLl/I7j1Sh/LEZw0MWfY8kyEbbglNVYNkkigadrRAenkD7km+hLsTdgMtebkdWrhSk3MBI6UgL3yUWAhOMpq+bdpcMGyaOddaAET4tLZs7JKDCdAOVdxM8OZE7nnIzl2LDaJN1qDiIfGDqUxSyA9Y4T52RZXfHPjvR60sxkPrWhyrvoj1A1IY9Kmk42KBDspV/p1Om16eEcO6lZzfatRxU0Gj/ADQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ThVNWM9DRdGsvwJd0RESH8peZY3os+tCGjPs/q3bBrA=; b=Vl1lrzlGNkV4GoC4VpGs1kk62xH2DOt+Zz57qRTpV9QplTwVc02uTuK6eONFdo6fEqEb4fZ88Fi8K6ZiZUhhTKgoZ5D+09ETQ6UXOLekLbD64xzqeP35dhmqUjGxQREDFtHQMUR8WmGcGM1l6lzvZwpb2JHJUKqY4/nEPthBPdmvgAi95J/JljvO3X76GjIfp84izpo/M1noXi3F2hiuQ8PirGj2+iT3a7wK0ZGSzPW/uW2UW6ZWMC+UlRZnrvIuF1ek0Dhn/9yP6+6rvSe1fDDQKMMunNVfl79XiSEOAEo4IqHOQgiYieZ4sQ9IC7TU331sLxjdXwnKCmrko0Ddpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ThVNWM9DRdGsvwJd0RESH8peZY3os+tCGjPs/q3bBrA=; b=0G42w22d2tAZRcOdUflX2I+WOmta/BIPGNL1BTKbIWNAZhhgXYqNPsL0p33aqs3ExIOsUU44Twayprxb8RC5p8V1g5S49u289wjKUWTEyJutJDokrF9ro7XKMfKYVRdj2q41OZ55W4cPIBB/MNWzdi/eHBUQe3lqw+j42rIvzdk= Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Andrea.Corallo@arm.com; Received: from VI1PR08MB2765.eurprd08.prod.outlook.com (10.170.236.32) by VI1PR08MB2656.eurprd08.prod.outlook.com (10.175.244.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2750.22; Fri, 6 Mar 2020 08:07:59 +0000 Received: from VI1PR08MB2765.eurprd08.prod.outlook.com ([fe80::eca9:5f98:627d:571b]) by VI1PR08MB2765.eurprd08.prod.outlook.com ([fe80::eca9:5f98:627d:571b%6]) with mapi id 15.20.2772.019; Fri, 6 Mar 2020 08:07:58 +0000 From: Andrea Corallo To: David Malcolm Cc: "gcc-patches@gcc.gnu.org" , "jit@gcc.gnu.org" , nd Subject: Re: [PATCH][gcc] libgccjit: introduce version entry points References: Date: Wed, 01 Jan 2020 00:00:00 -0000 In-Reply-To: (David Malcolm's message of "Thu, 05 Mar 2020 21:34:53 -0500") Message-ID: <87r1y529ew.fsf@arm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: text/plain X-ClientProxiedBy: SN4PR0201CA0004.namprd02.prod.outlook.com (2603:10b6:803:2b::14) To VI1PR08MB2765.eurprd08.prod.outlook.com (2603:10a6:802:18::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from krcb (217.140.106.49) by SN4PR0201CA0004.namprd02.prod.outlook.com (2603:10b6:803:2b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2793.16 via Frontend Transport; Fri, 6 Mar 2020 08:07:56 +0000 X-Originating-IP: [217.140.106.49] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: b2f09936-6ff5-41bc-e51f-08d7c1a5803a X-MS-TrafficTypeDiagnostic: VI1PR08MB2656:|DB6PR0802MB2135: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000; X-Forefront-PRVS: 0334223192 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(376002)(39860400002)(366004)(136003)(346002)(396003)(189003)(199004)(6666004)(2616005)(956004)(4326008)(54906003)(6486002)(186003)(86362001)(16526019)(8676002)(2906002)(5660300002)(44832011)(316002)(36756003)(8936002)(81156014)(26005)(81166006)(6916009)(478600001)(6496006)(66476007)(66556008)(66946007)(52116002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR08MB2656;H:VI1PR08MB2765.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: NB/cR+jjkkmt9mLL3b/X7TnCftrZfD5VBupVRJMIwgZVGgLipydtWi0uvI26ebD0BjgPLjn7lFzCgNVWgOt5fUpy+bpxZr7wxOhBy1iNl5zgMY2QSIcrBFiNSw3O+pQkUyzRsA+Hcb3ryvjKeE3hy1YxpBr71RcgDY5J5SfW87hDD8ubWQfSbr4KnqiF9/L9/BNrvu/6VhUrQQNlMMr9d4qMSiEQ6owN5eaw6CAmvnnNPcWNTLz8oYIPDJdP1QchwKVRzXK/yYL4iBFnS3MwK+APxSvahwvZNhHwEuT+H4Ih7feqXW4dmYq5ebB1cyFDy1QIidD5gsyQ+DsAyq1AlyUYu4LYuK5tBpY4XqnAF03OwG01KvJLC/Sgf/suweZufcTU6mpPax/w1Hjud5M1Y3rdKxHwDPzDF5WpZFDTeyV3JCt41tbcL+BeebfYt+NZ X-MS-Exchange-AntiSpam-MessageData: /m599Mu4Iq6ptxq+oikEGuIkMEzMnFwq4tUnStnnmX/YKrqkbJjzPor8V+qJQkiwP1/ePZYqZjZBNJp0g0qb/4XoowHwt/mvC4ZX9KXCLV0hdxxhIoHeHiSYzwRiRm3bfpgaF3RRRC2v+1J85AqOXQ== X-MS-Exchange-Transport-Forked: True X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2656 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Andrea.Corallo@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT011.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(396003)(376002)(346002)(136003)(39860400002)(199004)(189003)(16526019)(54906003)(2616005)(450100002)(956004)(81156014)(478600001)(81166006)(2906002)(5660300002)(356004)(6666004)(186003)(70586007)(26005)(70206006)(336012)(36906005)(86362001)(6862004)(6496006)(316002)(4326008)(44832011)(26826003)(6486002)(8676002)(8936002)(36756003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2135;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:Pass;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;A:1;MX:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 85f01150-ce39-457b-b7ea-08d7c1a57b92 X-Forefront-PRVS: 0334223192 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sLzYTTK/agLu9PxDtSHWvgoKNB9c5+SyC8XFNI2tLYHopIayLXxInEf//L2aOzE9CjH7BXD4jrWCpfkqoHAaO+craTVahFbkld7ZyH82zoIFzOkMiZx/nx5XKdYOrA0p+U3zSBiFujp0c2cjltbehBYv2eIf24Sd/zSXVvdR4EaKJGWE8aAJVPDChgbgflxrFcPpXsLOXvy8kh0H/9M9c5ECA7k9tQEHe/u/Cmli8FCBkOPlVGt8WaRNA+JB/L+Osn04AvyruXrycaMQP1Ne/tTZV/WDe8mp/9WabU+B+tmWj1zxi017Ay3RFnuE4po33TE98fru9cnYeJjmPHfoEj4LYCJ+SCwsInK6PdoBw4C+b7+j8Vmh+vCxpcbC8C2g3N9CuXFrP9iGdIg2s5YdPreNFClyjZ+ny5IPtUt1Ke737Jgn8b51YS3lEba0MBnH X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2020 08:08:06.0551 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b2f09936-6ff5-41bc-e51f-08d7c1a5803a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2135 X-IsSubscribed: yes X-SW-Source: 2020-q1/txt/msg00010.txt David Malcolm writes: > On Thu, 2020-01-16 at 11:11 +0000, Andrea Corallo wrote: >> Hi, second version of the patch here cleaning up an unnecessary >> change. >> >> Does not introduce regressions with make check-jit. >> >> Andrea >> >> gcc/jit/ChangeLog >> 2020-??-?? Andrea Corallo >> >> * docs/topics/compatibility.rst (LIBGCCJIT_ABI_13): New ABI tag >> plus add version paragraph. >> * libgccjit++.h (namespace gccjit::version): Add new namespace. >> * libgccjit.c (gcc_jit_version_major, gcc_jit_version_minor) >> (gcc_jit_version_patchlevel): New functions. >> * libgccjit.h (LIBGCCJIT_HAVE_gcc_jit_version): New macro. >> (gcc_jit_version_major, gcc_jit_version_minor) >> (gcc_jit_version_patchlevel): New functions. >> * libgccjit.map (LIBGCCJIT_ABI_13) New ABI tag. >> >> gcc/testsuite/ChangeLog >> 2020-??-?? Andrea Corallo >> >> * jit.dg/test-version.c: New testcase. > > [...] > > Thanks for the patch; sorry for the delay in reviewing this. > > Out of interest, do you have a specific use for this, or is it more > speculative? Hi Dave, The use case is where client code wants to check specifically at run-time for the version. This to warn for a known to be buggy version or to take any other decision that depends on the libgccjit version. One could decide to layout the generated code differently depending on the compiler version. For these cases the granularity we have with with macros defining for the ABI may be not sufficient. As you say this is speculative now given that will become helpful only in the future. Thanks for reviewing both patches. I'll re-spin them this weekend. Andrea