From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id A4EB83858039 for ; Thu, 2 Sep 2021 15:20:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A4EB83858039 Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-456-MIG1Wy5DNUuhXlS8xVKPng-1; Thu, 02 Sep 2021 11:20:50 -0400 X-MC-Unique: MIG1Wy5DNUuhXlS8xVKPng-1 Received: by mail-qt1-f198.google.com with SMTP id r5-20020ac85e85000000b0029bd6ee5179so1474387qtx.18 for ; Thu, 02 Sep 2021 08:20:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=DMtae+VKDkvo9fQ+LYolYTJ+c5hHgN+R8zCa2jHwmmY=; b=FH7fPXbTug6cszjn8Ta92+d3hBaMZjin4h/MaILgMWjfyBaxTdGm3KQxSkhgtwWBJ7 A5jRU29+Dv+3gcy8JLYSDCO07R/SYZrB0DFhGsERMlHPL586EwlCQGLFRbmJ2yzZVb57 UDIExgdy7auVMrHpakrCkdaD6ildf9iKjFw7z7Vb5/Prj2BWZTEJX1G5SZtD1yqW+a89 Ezr2Z0XKRSEoTMoNNIe/LpryqAoZkUq3NFwi2RcGxsQFa6cgMTDNOMYYg2ZrviNdZMu9 hwc31vlnH6TQPyQBbeTwIazhLHj+G9hrwAmXS2r7ZK3IA3P2sftNmv6Sw34SajOqy5x9 C+1Q== X-Gm-Message-State: AOAM530QffQ9zFK+m+KtZO3Gh2pP0ELyRfOD/p+g41YJ2Wl+v3G1PiWw 4+64ajncmnHkvgH9OJ8nifIlJjb3d9nGSCNjUKVNK5POMyWEAXm3bCGDDzgNA//o4tgX/Y6HNEQ 0bfS4nm0= X-Received: by 2002:ac8:574b:: with SMTP id 11mr3414302qtx.342.1630596049701; Thu, 02 Sep 2021 08:20:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw+BvSooS+jdVKxs76FT91BKS5C5yNxt27ET1Oy53ZPu20jcqg/KWE6mo5wwFA9V6s/qjig4w== X-Received: by 2002:ac8:574b:: with SMTP id 11mr3414277qtx.342.1630596049441; Thu, 02 Sep 2021 08:20:49 -0700 (PDT) Received: from t14s.localdomain (c-73-69-212-193.hsd1.ma.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id c10sm1190812qtb.20.2021.09.02.08.20.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 08:20:49 -0700 (PDT) Message-ID: <88fec727a754cc46b1be76504fdcf706496d7bdb.camel@redhat.com> Subject: Re: Sv: [PATCH] jit : Generate debug info for variables From: David Malcolm To: Petter Tomner , "gcc-patches@gcc.gnu.org" , "jit@gcc.gnu.org" Date: Thu, 02 Sep 2021 11:20:48 -0400 In-Reply-To: <48eaaa78251343819d01ccf1f03db37f@kth.se> References: <005bad3cb21745d591cea63567d08d08@kth.se> <48eaaa78251343819d01ccf1f03db37f@kth.se> User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: jit@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Jit mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Sep 2021 15:21:03 -0000 On Tue, 2021-08-31 at 00:23 +0000, Petter Tomner via Gcc-patches wrote: > Well I seemed to have attached the wrong testcase. Here is the proper > one attached. > > Regards, > > -----Ursprungligt meddelande----- > Från: Petter Tomner > Skickat: den 31 augusti 2021 02:14 > Till: gcc-patches@gcc.gnu.org; jit@gcc.gnu.org > Ämne: [PATCH] jit : Generate debug info for variables > > Hi, > > This is a patch to generate debug info for local variables as well as > globals. > With this, "ptype foo", "info variables", "info locals" etc works when > debugging in GDB. > > Finalizing of global variable declares are moved to after locations are > handled and done > as Fortran, C, Go etc do it. Also, primitive types have their TYPE_NAME > set for debug info > on types to work. > > Below are the patch, and I attached a testcase. Since it requires GDB > to run it might > not be suitable? Make check-jit runs fine on Debian x64. > > Regards, > From 6a5d24cbe80429d19042e643bd4c23940cd185fa Mon Sep 17 00:00:00 2001 > From: Petter Tomner > Date: Mon, 30 Aug 2021 01:45:11 +0200 > Subject: [PATCH 2/2] libgccjit: Test cases for debug info > > Assure that debug info is available for variables. > > gcc/testsuite/jit.dg/ > jit.exp: Helper function > test-debuginfo.c Again, please provided non-empty ChangeLog entries. You can use contrib/gcc-changelog/git_check_commit.py to validate them. I don't see "Signed-off-by" tags in the patches. Have you either filed a copyright assignment with the FSF, or can you please add the tags to certify that you wrote the patches and can contribute them, see: https://gcc.gnu.org/contribute.html#legal https://gcc.gnu.org/dco.html [...snip...] > +proc jit-check-debug-info { obj_file cmds match } { > + verbose "Checking debug info for $obj_file with match: $match" > + > + if { [catch {exec gdb -v} fid] } { > + verbose "No gdb seems to be in path. Can't check debug info. Reporting expected fail." > + xfail "No gdb seems to be in path. Can't check debug info" I think this should be "unsupported" rather than "xfail". [...snip...] > diff --git a/gcc/testsuite/jit.dg/test-debuginfo.c b/gcc/testsuite/jit.dg/test-debuginfo.c > new file mode 100644 > index 00000000000..0af5779fdd1 > --- /dev/null > +++ b/gcc/testsuite/jit.dg/test-debuginfo.c > @@ -0,0 +1,72 @@ > +/* Essentially this test checks that debug info are generated for globals > + locals and functions, including type info. The comment bellow is used > + as fake code (does not affect the test, use for manual debugging). */ > +/* > +int a_global_for_test_debuginfo; > +int main (int argc, char **argv) > +{ > + int a_local_for_test_debuginfo = 2; > + return a_global_for_test_debuginfo + a_local_for_test_debuginfo; > +} > +*/ This is OK, but maybe using gcc_jit_context_dump_to_file with update_locations == 1 might be more sustainable in the long run? See: https://gcc.gnu.org/onlinedocs/jit/topics/locations.html#faking-it OK otherwise. Thanks Dave