From: David Malcolm <dmalcolm@redhat.com>
To: Guillaume Gomez <guillaume1.gomez@gmail.com>,
gcc-patches@gcc.gnu.org, jit@gcc.gnu.org,
Antoni <bouanto@zoho.com>
Subject: Re: [PATCH] Add missing declaration of get_restrict in C++ interface
Date: Thu, 09 Nov 2023 15:49:25 -0500 [thread overview]
Message-ID: <8cd36a7829ceb78c8e98d1d268403f9eed121128.camel@redhat.com> (raw)
In-Reply-To: <CAAOQCfQ3BuvdnvyxvwSP2h_VZK8tEkfKGrANnRomYbJRXvtg6w@mail.gmail.com>
On Thu, 2023-11-09 at 21:03 +0100, Guillaume Gomez wrote:
> Hi,
>
> This patch adds the `get_restrict` method declaration for
> the C++ interface as it was forgotten.
>
> Thanks in advance for the review.
Looking at my jit.sum results, it looks like the .cc files are indeed
FAILing on initial compilation, with errors such as:
In file included from gcc/testsuite/jit.dg/test-alignment.cc:4:
gcc/testsuite/../jit/libgccjit++.h:1414:1: error: no declaration matches 'gccjit::type gccjit::type::get_restrict()'
gcc/testsuite/../jit/libgccjit++.h:1414:1: note: no functions named 'gccjit::type gccjit::type::get_restrict()'
gcc/testsuite/../jit/libgccjit++.h:350:9: note: 'class gccjit::type' defined here
which presumably started with r14-3552-g29763b002459cb.
Hence the patch looks good to me - thanks!
Does this patch fix those test cases?
Dave
next prev parent reply other threads:[~2023-11-09 20:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 20:03 Guillaume Gomez
2023-11-09 20:49 ` David Malcolm [this message]
2023-11-09 20:51 ` Guillaume Gomez
2023-11-09 21:02 ` David Malcolm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cd36a7829ceb78c8e98d1d268403f9eed121128.camel@redhat.com \
--to=dmalcolm@redhat.com \
--cc=bouanto@zoho.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=guillaume1.gomez@gmail.com \
--cc=jit@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).