From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27070 invoked by alias); 6 May 2016 18:10:49 -0000 Mailing-List: contact jit-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: Sender: jit-owner@gcc.gnu.org Received: (qmail 26973 invoked by uid 89); 6 May 2016 18:10:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.1 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1084, FINAL X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Subject: Re: [PATCH 1/2] Add OVERRIDE and FINAL macros to coretypes.h To: Pedro Alves , David Malcolm , gcc-patches@gcc.gnu.org, jit@gcc.gnu.org References: <1462552846-17096-1-git-send-email-dmalcolm@redhat.com> From: Pedro Alves Message-ID: <8ce94f18-421f-9466-85cf-e17d9caee151@redhat.com> Date: Fri, 01 Jan 2016 00:00:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-SW-Source: 2016-q2/txt/msg00006.txt.bz2 On 05/06/2016 06:56 PM, Pedro Alves wrote: > If building gcc as a C++11 program is supported, then it > won't be possible to use these names as symbols for > anything else anyway? Just found out the above is not true. Apparently I've been stuck in C++98 for too long... Sorry about the noise. I was going to suggest to put this in include/ansidecl.h, so that all C++ libraries / programs in binutils-gdb use the same thing, instead of each reinventing the wheel, and I found there's already something there: /* This is used to mark a class or virtual function as final. */ #if __cplusplus >= 201103L #define GCC_FINAL final #elif GCC_VERSION >= 4007 #define GCC_FINAL __final #else #define GCC_FINAL #endif From: https://gcc.gnu.org/ml/gcc-patches/2015-08/msg00455.html Apparently the patch that actually uses that was reverted, as I can't find any use. I like your names without the GCC_ prefix better though, for the same reason of standardizing binutils-gdb + gcc on the same symbols. -- Thanks, Pedro Alves